URL: https://github.com/SSSD/sssd/pull/839 Author: alexey-tikhonov Title: #839: util/find_uid.c: fixed race condition bug Action: opened
PR body: """ It was wrong to return EOK from get_uid_from_pid() in case of failed open() or fstat() as this leaves `uid` uninitialized and no means for caller to detect this situation.
There was no reason to fail get_active_uid_linux() completely in case of failed get_uid_from_pid() for one of /proc entries. Function was changed to continue with next entry instead.
Resolves: https://pagure.io/SSSD/sssd/issue/2854
"""
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/839/head:pr839 git checkout pr839
URL: https://github.com/SSSD/sssd/pull/839 Title: #839: util/find_uid.c: fixed race condition bug
alexey-tikhonov commented: """ This code is only used by krb5_child and bug only affects #ifndef HAVE_SYSTEMD_LOGIN case, so this is not very crucial. But this causes sporadic CI fails thus good to have this fixed. """
See the full comment at https://github.com/SSSD/sssd/pull/839#issuecomment-505949936
URL: https://github.com/SSSD/sssd/pull/839 Author: alexey-tikhonov Title: #839: util/find_uid.c: fixed race condition bug Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/839/head:pr839 git checkout pr839
URL: https://github.com/SSSD/sssd/pull/839 Title: #839: util/find_uid.c: fixed race condition bug
alexey-tikhonov commented: """ I have amended the patch with: ``` DEBUG(SSSDBG_TRACE_ALL, "get_uid_from_pid() failed.\n"); + errno = 0; continue; ```
It is required to do before next `readdir()` accoring to `man 3 readdir` """
See the full comment at https://github.com/SSSD/sssd/pull/839#issuecomment-508403810
URL: https://github.com/SSSD/sssd/pull/839 Title: #839: util/find_uid.c: fixed race condition bug
jhrozek commented: """ Thank you, I started several CI runs to see if the tests are stable now """
See the full comment at https://github.com/SSSD/sssd/pull/839#issuecomment-508405072
URL: https://github.com/SSSD/sssd/pull/839 Title: #839: util/find_uid.c: fixed race condition bug
jhrozek commented: """ I ran several CI runs with these patches and this test was stable on all OSs and architectures. ACK. """
See the full comment at https://github.com/SSSD/sssd/pull/839#issuecomment-508708268
URL: https://github.com/SSSD/sssd/pull/839 Title: #839: util/find_uid.c: fixed race condition bug
Label: +Accepted
URL: https://github.com/SSSD/sssd/pull/839 Title: #839: util/find_uid.c: fixed race condition bug
jhrozek commented: """ * master: * 0897be2ab9943f5ce9ae03d57a646b2b4cd724d4 * e232a98a04554298e5517a167116f688ded8fabd * sssd-1-16: * fb50da239fedf5fc1163a0ecbbc68d0ca57c2895 * 7b3c8e8c5c5c152aaf7040a6c19df65036f3ff3d
"""
See the full comment at https://github.com/SSSD/sssd/pull/839#issuecomment-508712274
URL: https://github.com/SSSD/sssd/pull/839 Author: alexey-tikhonov Title: #839: util/find_uid.c: fixed race condition bug Action: closed
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/839/head:pr839 git checkout pr839
URL: https://github.com/SSSD/sssd/pull/839 Title: #839: util/find_uid.c: fixed race condition bug
Label: +Pushed
sssd-devel@lists.fedorahosted.org