-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Patch 0001: Add the user's primary group to the initgroups lookup The user may not be a direct member of their primary group, but we still want to make sure that group is cached on the system.
Patch 0002: Perform initgroups lookup for PAM Previously we were only looking up the user, but we need to make sure that all groups are available for use by access providers.
Fixes https://fedorahosted.org/sssd/ticket/778, but is also just generally useful.
- -- Stephen Gallagher RHCE 804006346421761
Delivering value year after year. Red Hat ranks #1 in value among software vendors. http://www.redhat.com/promo/vendor/
On Wed, 19 Jan 2011 15:59:16 -0500 Stephen Gallagher sgallagh@redhat.com wrote:
- subreq = sdap_get_initgr_send(state, state->ev,
- subreq = sdap_get_initgr_send(state,
state->ev, state->ctx->be->domain, state->ctx->be->sysdb,
state->ctx->opts,sdap_id_op_handle(state->op),
state->name, state->attrs);
state->ctx->opts,sdap_id_op_handle(state->op),state->ctx,state->name,state->attrs);
not a strong nack, but this could be simplified by simply passing state->ctx and then dereferencing it within the function instead of passing the structure and all its members explicitly.
Simo.
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 01/19/2011 04:36 PM, Simo Sorce wrote:
On Wed, 19 Jan 2011 15:59:16 -0500 Stephen Gallagher sgallagh@redhat.com wrote:
- subreq = sdap_get_initgr_send(state, state->ev,
- subreq = sdap_get_initgr_send(state,
state->ev, state->ctx->be->domain, state->ctx->be->sysdb,
state->ctx->opts,sdap_id_op_handle(state->op),
state->name, state->attrs);
state->ctx->opts,sdap_id_op_handle(state->op),state->ctx,state->name,state->attrs);not a strong nack, but this could be simplified by simply passing state->ctx and then dereferencing it within the function instead of passing the structure and all its members explicitly.
Simo.
Thanks for the review. New patches attached.
- -- Stephen Gallagher RHCE 804006346421761
Delivering value year after year. Red Hat ranks #1 in value among software vendors. http://www.redhat.com/promo/vendor/
On Thu, Jan 20, 2011 at 09:41:40AM -0500, Stephen Gallagher wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 01/19/2011 04:36 PM, Simo Sorce wrote:
On Wed, 19 Jan 2011 15:59:16 -0500 Stephen Gallagher sgallagh@redhat.com wrote:
- subreq = sdap_get_initgr_send(state, state->ev,
- subreq = sdap_get_initgr_send(state,
state->ev, state->ctx->be->domain, state->ctx->be->sysdb,
state->ctx->opts,sdap_id_op_handle(state->op),
state->name, state->attrs);
state->ctx->opts,sdap_id_op_handle(state->op),state->ctx,state->name,state->attrs);not a strong nack, but this could be simplified by simply passing state->ctx and then dereferencing it within the function instead of passing the structure and all its members explicitly.
Simo.
Thanks for the review. New patches attached.
ACK
bye, Sumit
Stephen Gallagher RHCE 804006346421761
Delivering value year after year. Red Hat ranks #1 in value among software vendors. http://www.redhat.com/promo/vendor/ -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
iEYEARECAAYFAk04SaQACgkQeiVVYja6o6OcKgCZAexK4QgkDXgUbF+yl+lIWZN/ D2wAn07saLL1qWZnnq8+sbN+ocXkklTN =Okny -----END PGP SIGNATURE-----
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 01/20/2011 03:49 PM, Sumit Bose wrote:
On Thu, Jan 20, 2011 at 09:41:40AM -0500, Stephen Gallagher wrote:
Thanks for the review. New patches attached.
ACK
Pushed to master.
- -- Stephen Gallagher RHCE 804006346421761
Delivering value year after year. Red Hat ranks #1 in value among software vendors. http://www.redhat.com/promo/vendor/
sssd-devel@lists.fedorahosted.org
-
Simo Sorce -
Stephen Gallagher -
Sumit Bose