Attached patch contains some changes that I'd like to propose. All modifications are based on spec file for Fedora rawhide.
Thanks Jan
On Mon, 2012-05-28 at 16:59 +0200, Jan Zelený wrote:
Attached patch contains some changes that I'd like to propose. All modifications are based on spec file for Fedora rawhide.
Nack
Please don't change the source URL for this file. It's intentionally NOT pointing at Fedora Hosted because it's used by 'make rpms'. In the future, RPM may auto-download such source-URLs and that would lead to confusion when 'make rpms' doesn't build the same sources you expected it to.
Otherwise, this would be an ack.
On Tue, May 29, 2012 at 07:49:50AM -0400, Stephen Gallagher wrote:
On Mon, 2012-05-28 at 16:59 +0200, Jan Zelený wrote:
Attached patch contains some changes that I'd like to propose. All modifications are based on spec file for Fedora rawhide.
Nack
Please don't change the source URL for this file. It's intentionally NOT pointing at Fedora Hosted because it's used by 'make rpms'. In the future, RPM may auto-download such source-URLs and that would lead to confusion when 'make rpms' doesn't build the same sources you expected it to.
Otherwise, this would be an ack.
It seems this patch has stalled, can we get another revision? Now that Dmitri has sent a couple of ding-libs patches might be a good time.
sssd-devel@lists.fedorahosted.org