[PATCH] More simple fixes

[Jan Zelený]

jzeleny-022-possible-memory-leak-fixed.patch
- this could cause leak in case filter was NULL

jzeleny-023-fixed-uninitialized-return-value.patch
- https://fedorahosted.org/sssd/ticket/858

jzeleny-024-fixed-unitialized-pointer.patch
- https://fedorahosted.org/sssd/ticket/857

Jan

[Jakub Hrozek]

On 05/14/2011 01:38 AM, Jan Zeleny wrote:
> jzeleny-022-possible-memory-leak-fixed.patch
> this could cause leak in case filter was NULL

member_dn is allocated on state, so it wouldn't leak, unlike filter in
the same function that is allocated on NULL. Both should be allocated on
tmp_ctx (which is what we're going to in the pre-deref refactoring).

But this correct, too, since we no longer need member_dn at that point.

Ack.
> jzeleny-023-fixed-uninitialized-return-value.patch
> https://fedorahosted.org/sssd/ticket/858

Ack
> jzeleny-024-fixed-unitialized-pointer.patch
> https://fedorahosted.org/sssd/ticket/857

Ack

[Stephen Gallagher]

On Mon, 2011-05-16 at 11:14 +0200, Jakub Hrozek wrote:
> On 05/14/2011 01:38 AM, Jan Zeleny wrote:
> > jzeleny-022-possible-memory-leak-fixed.patch
> > this could cause leak in case filter was NULL
>
> member_dn is allocated on state, so it wouldn't leak, unlike filter in
> the same function that is allocated on NULL. Both should be allocated on
> tmp_ctx (which is what we're going to in the pre-deref refactoring).
>
> But this correct, too, since we no longer need member_dn at that point.
>
> Ack.
> > jzeleny-023-fixed-uninitialized-return-value.patch
> > https://fedorahosted.org/sssd/ticket/858
>
> Ack
> > jzeleny-024-fixed-unitialized-pointer.patch
> > https://fedorahosted.org/sssd/ticket/857
>
> Ack

Pushed to master