[PATCH] Added a kerberos wrapper for building compatibility

[Jan Zelený]

Function sss_krb5_unparse_name_flags and some of its supporting functions have
been added in order to ensure compilation on systems having kerberos < 1.8.

Currently I don't have any machine with RHEL5, so please be sure to test the 
patch on it.

Thanks
Jan

[Jakub Hrozek]

On 05/03/2011 12:44 PM, Jan Zelený wrote:
> Function sss_krb5_unparse_name_flags and some of its supporting functions have
> been added in order to ensure compilation on systems having kerberos < 1.8.

Sorry, but this doesn't build for me (RHEL 5.6 + openldap24-libs from 5.7):

src/util/sss_krb5.c: In function 'select_principal_from_keytab':
src/util/sss_krb5.c:147: error: 'KRB5_PRINCIPAL_UNPARSE_NO_REALM'
undeclared (first use in this function)
src/util/sss_krb5.c:147: error: (Each undeclared identifier is reported
only once
src/util/sss_krb5.c:147: error: for each function it appears in.)
src/util/sss_krb5.c: In function 'match_principal':
src/util/sss_krb5.c:413: error: 'KRB5_PRINCIPAL_UNPARSE_NO_REALM'
undeclared (first use in this function)

I also think that the hunk in configure.ac should be moved to
src/external/krb5.m4 - it should be enough to just move the function
name into the existing AC_CHECK_FUNCS() call - that should be enough to
generate the HAVE_ macro.
> Currently I don't have any machine with RHEL5, so please be sure to test the 
> patch on it.

Feel free to ping me for a RHEL5 machine with the new openldap-libs.

[Jan Zelený]

Jakub Hrozek  wrote:
> On 05/03/2011 12:44 PM, Jan Zelený wrote:
> > Function sss_krb5_unparse_name_flags and some of its supporting functions
> > have been added in order to ensure compilation on systems having
> > kerberos < 1.8.
>
> Sorry, but this doesn't build for me (RHEL 5.6 + openldap24-libs from 5.7):
>
> src/util/sss_krb5.c: In function 'select_principal_from_keytab':
> src/util/sss_krb5.c:147: error: 'KRB5_PRINCIPAL_UNPARSE_NO_REALM'
> undeclared (first use in this function)
> src/util/sss_krb5.c:147: error: (Each undeclared identifier is reported
> only once
> src/util/sss_krb5.c:147: error: for each function it appears in.)
> src/util/sss_krb5.c: In function 'match_principal':
> src/util/sss_krb5.c:413: error: 'KRB5_PRINCIPAL_UNPARSE_NO_REALM'
> undeclared (first use in this function)
>
> I also think that the hunk in configure.ac should be moved to
> src/external/krb5.m4 - it should be enough to just move the function
> name into the existing AC_CHECK_FUNCS() call - that should be enough to
> generate the HAVE_ macro.
> > Currently I don't have any machine with RHEL5, so please be sure to test
> > the patch on it.
>
> Feel free to ping me for a RHEL5 machine with the new openldap-libs.

Thanks,
I'm sending corrected patch. Everything should be working now.

Jan

[Jakub Hrozek]

On 05/04/2011 06:51 PM, Jan Zeleny wrote:
> Thanks,
> I'm sending corrected patch. Everything should be working now.
>
> Jan

Please also include the "if (flags & KRB5_PRINCIPAL_UNPARSE_SHORT)" block.

[Jan Zelený]

> On 05/04/2011 06:51 PM, Jan Zeleny wrote:
> > Thanks,
> > I'm sending corrected patch. Everything should be working now.
> >
> > Jan
>
> Please also include the "if (flags & KRB5_PRINCIPAL_UNPARSE_SHORT)" block.

Done, thanks for catching that - I was doing some experiments with the code 
and forgot to put it back there.

Jan

[Jakub Hrozek]

On 05/05/2011 12:49 PM, Jan Zelený wrote:
> > On 05/04/2011 06:51 PM, Jan Zeleny wrote:
> > > Thanks,
> > > I'm sending corrected patch. Everything should be working now.
> > >
> > > Jan
> >
> > Please also include the "if (flags & KRB5_PRINCIPAL_UNPARSE_SHORT)" block.
>
> Done, thanks for catching that - I was doing some experiments with the code 
> and forgot to put it back there.
>
> Jan

Ack

[Stephen Gallagher]

On Thu, 2011-05-05 at 13:07 +0200, Jakub Hrozek wrote:
> On 05/05/2011 12:49 PM, Jan Zelený wrote:
> > > On 05/04/2011 06:51 PM, Jan Zeleny wrote:
> > > > Thanks,
> > > > I'm sending corrected patch. Everything should be working now.
> > > >
> > > > Jan
> > >
> > > Please also include the "if (flags & KRB5_PRINCIPAL_UNPARSE_SHORT)" block.
> >
> > Done, thanks for catching that - I was doing some experiments with the code 
> > and forgot to put it back there.
> >
> > Jan
>
> Ack

Pushed to master.

[Sumit Bose]

On Tue, May 03, 2011 at 12:44:46PM +0200, Jan Zelený wrote:
> Function sss_krb5_unparse_name_flags and some of its supporting functions have
> been added in order to ensure compilation on systems having kerberos < 1.8.
>
> Currently I don't have any machine with RHEL5, so please be sure to test the 
> patch on it.
>
> Thanks
> Jan
> +SAFE_LIBS="$LIBS"
> +LIBS="-lkrb5"
> +AC_CHECK_FUNC([krb5_unparse_name_flags],
>          AC_DEFINE([HAVE_KRB5_UNPARSE_NAME_FLAGS], [1],
>                    [Define if krb5_unparse_name_flags exists]))
>
> +LIBS="$SAFE_LIBS"
>
> if test x$HAVE_MANPAGES != x; then
>      CHECK_XML_TOOLS
>      CHECK_STYLESHEET([$SGML_CATALOG_FILES],

Please put this check in src/external/krb5.m4 there is already a
AC_CHECK_FUNC for calls from libkrb5.

bye,
Sumit