[PATCHES] The fast memory cache should cache initgroups

[Lukas Slebodnik]

ehlo,

patches are attached.

LS

[Lukas Slebodnik]

On (30/06/15 23:10), Lukas Slebodnik wrote:
> ehlo,
>
> patches are attached.

There was a missing break cuased by wrong rebase.

LS

[Michal Židek]

On 07/01/2015 12:08 AM, Lukas Slebodnik wrote:
> On (30/06/15 23:10), Lukas Slebodnik wrote:
> > ehlo,
> >
> > patches are attached.
>
> There was a missing break cuased by wrong rebase.
>
> LS

I do not like the change in the first patch
(mmap_cache-remove-dead-increment.patch)
It was written that way intentionally to
always have pos pointing to the end of the structure.
I know we currently do not use pos after the last
memcpy, but the code may change in the future.
I do not see this patch as an improvement. Was
there some tool giving you warnings about the
dead increment? I think it is OK to ignore such
warning. If you still want the patch being
pushed, send it in another thread so that
our discussion about it will not stand in the
way of the rest of the patches in this set.

ACK to the rest of the patches.

CI link (I ran the CI together with the
other memcache patches that Lukas sent in
another thread):
http://sssd-ci.duckdns.org/logs/job/18/43/summary.html

So again. ACK to all patches except for the first patch.

[Jakub Hrozek]

On Fri, Jul 03, 2015 at 02:31:39PM +0200, Michal Židek wrote:
> On 07/01/2015 12:08 AM, Lukas Slebodnik wrote:
> > On (30/06/15 23:10), Lukas Slebodnik wrote:
> > > ehlo,
> > >
> > > patches are attached.
> >
> > There was a missing break cuased by wrong rebase.
> >
> > LS
>
> I do not like the change in the first patch
> (mmap_cache-remove-dead-increment.patch)
> It was written that way intentionally to
> always have pos pointing to the end of the structure.
> I know we currently do not use pos after the last
> memcpy, but the code may change in the future.
> I do not see this patch as an improvement. Was
> there some tool giving you warnings about the
> dead increment? I think it is OK to ignore such
> warning. If you still want the patch being
> pushed, send it in another thread so that
> our discussion about it will not stand in the
> way of the rest of the patches in this set.
>
> ACK to the rest of the patches.
>
> CI link (I ran the CI together with the
> other memcache patches that Lukas sent in
> another thread):
> http://sssd-ci.duckdns.org/logs/job/18/43/summary.html
>
> So again. ACK to all patches except for the first patch.

* b08bcc387ad99b9c408183960c127dc77975b6ff
* 88e68607e474ab2ce46c562753ef2e988516d1e9
* 7c83c23177cdb43e23fe19935356e1319e2b6f39
* 6d292632a7176540dd317bba7457a12a3634789a
* ebf6735dd4f71bf3dc9105e5d04d11e744c64a59