URL: https://github.com/SSSD/sssd/pull/1012 Author: thalman Title: #1012: config: add dns_resolver_op_timeout to option list Action: opened
PR body: """ Resolves: https://pagure.io/SSSD/sssd/issue/3217
This is backport of commit 049f3906b9 into 1-16 branch """
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/1012/head:pr1012 git checkout pr1012
URL: https://github.com/SSSD/sssd/pull/1012 Title: #1012: config: add dns_resolver_op_timeout to option list
thalman commented: """ Resolves https://bugzilla.redhat.com/show_bug.cgi?id=1719718 """
See the full comment at https://github.com/SSSD/sssd/pull/1012#issuecomment-604575880
URL: https://github.com/SSSD/sssd/pull/1012 Title: #1012: config: add dns_resolver_op_timeout to option list
sumit-bose commented: """ Hi,
``` diff --git a/src/config/etc/sssd.api.conf b/src/config/etc/sssd.api.conf index 0747dea..882aa2a 100644 --- a/src/config/etc/sssd.api.conf +++ b/src/config/etc/sssd.api.conf @@ -217,3 +217,4 @@ dyndns_server = str, None, false [provider/deny]
[provider/deny/access] +# Please do not remove ```
The line after the section header is important for the tests. Not sure if the tests can be fixed easy, if not please keep the empty line at the end.
bye, Sumit """
See the full comment at https://github.com/SSSD/sssd/pull/1012#issuecomment-604963858
URL: https://github.com/SSSD/sssd/pull/1012 Author: thalman Title: #1012: config: add dns_resolver_op_timeout to option list Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/1012/head:pr1012 git checkout pr1012
URL: https://github.com/SSSD/sssd/pull/1012 Title: #1012: config: add dns_resolver_op_timeout to option list
thalman commented: """
The line after the section header is important for the tests. Not sure if the tests can be fixed easy, if not please keep the empty line at the end.
bye, Sumit
Fixed
"""
See the full comment at https://github.com/SSSD/sssd/pull/1012#issuecomment-605027150
URL: https://github.com/SSSD/sssd/pull/1012 Title: #1012: config: add dns_resolver_op_timeout to option list
thalman commented: """
The line after the section header is important for the tests. Not sure if the tests can be fixed easy, if not please keep the empty line at the end.
bye, Sumit
Fixed
"""
See the full comment at https://github.com/SSSD/sssd/pull/1012#issuecomment-605027150
URL: https://github.com/SSSD/sssd/pull/1012 Title: #1012: config: add dns_resolver_op_timeout to option list
sumit-bose commented: """ Hi,
thanks, testing went well. I finally just want to ask if you can replace the 'Resolves: https://pagure.io/SSSD/sssd/issue/3217' with 'Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1719718' because #3217 gives imo a wrong impression here.
bye, Sumit """
See the full comment at https://github.com/SSSD/sssd/pull/1012#issuecomment-606066029
URL: https://github.com/SSSD/sssd/pull/1012 Title: #1012: config: add dns_resolver_op_timeout to option list
pbrezina commented: """
Hi,
thanks, testing went well. I finally just want to ask if you can replace the 'Resolves: https://pagure.io/SSSD/sssd/issue/3217' with 'Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1719718' because #3217 gives imo a wrong impression here.
Or ideally clone the bugzilla to upstream and reference this new ticket. """
See the full comment at https://github.com/SSSD/sssd/pull/1012#issuecomment-606070053
URL: https://github.com/SSSD/sssd/pull/1012 Author: thalman Title: #1012: config: add dns_resolver_op_timeout to option list Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/1012/head:pr1012 git checkout pr1012
URL: https://github.com/SSSD/sssd/pull/1012 Title: #1012: config: add dns_resolver_op_timeout to option list
Label: +Waiting for review
URL: https://github.com/SSSD/sssd/pull/1012 Title: #1012: config: add dns_resolver_op_timeout to option list
thalman commented: """ @pbrezina, @sumit-bose BZ cloned to pagure and referenced from commit message. """
See the full comment at https://github.com/SSSD/sssd/pull/1012#issuecomment-606631048
URL: https://github.com/SSSD/sssd/pull/1012 Title: #1012: config: add dns_resolver_op_timeout to option list
sumit-bose commented: """ Thanks, ACK.
bye, Sumit """
See the full comment at https://github.com/SSSD/sssd/pull/1012#issuecomment-607147091
URL: https://github.com/SSSD/sssd/pull/1012 Title: #1012: config: add dns_resolver_op_timeout to option list
Label: -Waiting for review
URL: https://github.com/SSSD/sssd/pull/1012 Title: #1012: config: add dns_resolver_op_timeout to option list
Label: +Accepted
URL: https://github.com/SSSD/sssd/pull/1012 Title: #1012: config: add dns_resolver_op_timeout to option list
Label: +Ready to push
URL: https://github.com/SSSD/sssd/pull/1012 Title: #1012: config: add dns_resolver_op_timeout to option list
Label: +Pushed
URL: https://github.com/SSSD/sssd/pull/1012 Title: #1012: config: add dns_resolver_op_timeout to option list
Label: -Accepted
URL: https://github.com/SSSD/sssd/pull/1012 Title: #1012: config: add dns_resolver_op_timeout to option list
Label: -Ready to push
URL: https://github.com/SSSD/sssd/pull/1012 Author: thalman Title: #1012: config: add dns_resolver_op_timeout to option list Action: closed
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/1012/head:pr1012 git checkout pr1012
sssd-devel@lists.fedorahosted.org
-
pbrezina -
sumit-bose
-
thalman