[PATCH] ELAPI Shortening names

[Dmitri Pal]

Ticket #118
See patch comment.

[Sumit Bose]

On Thu, Aug 20, 2009 at 06:53:44PM -0400, Dmitri Pal wrote:
> Ticket #118
> See patch comment.
>
> -- 
> Thank you,
> Dmitri Pal
>
> Engineering Manager IPA project,
> Red Hat Inc.
>
> Looking to carve out IT costs?
> www.redhat.com/carveoutcosts/
> > From 14600553ef68b86038f8c2facb119979079a68d5 Mon Sep 17 00:00:00 2001
>
> From: Dmitri Pal 
> Date: Thu, 20 Aug 2009 18:50:24 -0400
> Subject: [PATCH] ELAPI Shortening names
>
> Per ticket #118 shortened naimes of some functions and structs I added
> into ELAPI during last big functional patch .
> There is no plan to do a global shortening of all names
> but miving forward I will try to make them shorter than I used to.

applies and compiles well. Tests pass ...

ACK

Btw. to keep the names shorter you can drop the elapi_ prefix for all
internal stuff (functions, structs, etc.). It is reasonable to have it
for everything external but imho quite useless internally (*), because
people who edit these files should know that they are working on elapi
code.

bye,
Sumit

(*) I have to admit that I have a tendency to use those prefixes, too.

[Dmitri Pal]

Sumit Bose wrote:
> On Thu, Aug 20, 2009 at 06:53:44PM -0400, Dmitri Pal wrote:
> > Ticket #118
> > See patch comment.
> >
> > -- 
> > Thank you,
> > Dmitri Pal
> >
> > Engineering Manager IPA project,
> > Red Hat Inc.
> >
> > Looking to carve out IT costs?
> > www.redhat.com/carveoutcosts/
> > > From 14600553ef68b86038f8c2facb119979079a68d5 Mon Sep 17 00:00:00 2001
> >
> > From: Dmitri Pal 
> > Date: Thu, 20 Aug 2009 18:50:24 -0400
> > Subject: [PATCH] ELAPI Shortening names
> >
> > Per ticket #118 shortened naimes of some functions and structs I added
> > into ELAPI during last big functional patch .
> > There is no plan to do a global shortening of all names
> > but miving forward I will try to make them shorter than I used to.
>
> applies and compiles well. Tests pass ...
>
> ACK
>
> Btw. to keep the names shorter you can drop the elapi_ prefix for all
> internal stuff (functions, structs, etc.). It is reasonable to have it
> for everything external but imho quite useless internally (*), because
> people who edit these files should know that they are working on elapi
> code.

I do not want to drop the prefix.
I like it when one can identify the name space even for internal functions.
> bye,
> Sumit
>
> (*) I have to admit that I have a tendency to use those prefixes, too.
> _______________________________________________
> sssd-devel mailing list
> [e-mail]
> https://fedorahosted.org/mailman/listinfo/sssd-devel

[Stephen Gallagher]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 08/21/2009 10:23 AM, Dmitri Pal wrote:
> Sumit Bose wrote:
> > On Thu, Aug 20, 2009 at 06:53:44PM -0400, Dmitri Pal wrote:
> > > Ticket #118
> > > See patch comment.
> > >
> > > -- 
> > > Thank you,
> > > Dmitri Pal
> > >
> > > Engineering Manager IPA project,
> > > Red Hat Inc.
> > >
> > > Looking to carve out IT costs?
> > > www.redhat.com/carveoutcosts/
> > > > From 14600553ef68b86038f8c2facb119979079a68d5 Mon Sep 17 00:00:00 2001
> > >
> > > From: Dmitri Pal 
> > > Date: Thu, 20 Aug 2009 18:50:24 -0400
> > > Subject: [PATCH] ELAPI Shortening names
> > >
> > > Per ticket #118 shortened naimes of some functions and structs I added
> > > into ELAPI during last big functional patch .
> > > There is no plan to do a global shortening of all names
> > > but miving forward I will try to make them shorter than I used to.
> >
> > applies and compiles well. Tests pass ...
> >
> > ACK
> >
> > Btw. to keep the names shorter you can drop the elapi_ prefix for all
> > internal stuff (functions, structs, etc.). It is reasonable to have it
> > for everything external but imho quite useless internally (*), because
> > people who edit these files should know that they are working on elapi
> > code.
>
> I do not want to drop the prefix.
> I like it when one can identify the name space even for internal functions.
> > bye,
> > Sumit
> >
> > (*) I have to admit that I have a tendency to use those prefixes, too.
> > _______________________________________________
> > sssd-devel mailing list
> > [e-mail]
> > https://fedorahosted.org/mailman/listinfo/sssd-devel

Pushed to master.

- -- 
Stephen Gallagher
RHCE 804006346421761

Looking to carve out IT costs?
www.redhat.com/carveoutcosts/
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.9 (GNU/Linux)
> Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
>
> iEYEARECAAYFAkqO0eIACgkQeiVVYja6o6OmfwCeMUGp9qsmplZ3sf+jn6E6G4sT
> FwcAn2bZMn4yuJu3t7k00mOZC6c4NYuy
> =lKTb
> -----END PGP SIGNATURE-----