[PATCH] UTILS: Fixing duplication of pid file declaration

[Petr Cech]

Hello list,

attached patch fixes duplication of pid file declaration. I hope that 
the util/util.h is the right place for it. Another opinion are welcome.

Regards

-- 
Petr^4 Čech

[Petr Cech]

bump

-- 
Petr^4 Čech

[Fabiano Fidêncio]

On Tue, Jul 26, 2016 at 4:01 PM, Petr Cech <pcech(a)redhat.com&gt; wrote:
>  Hello list,
>
>  attached patch fixes duplication of pid file declaration. I hope that the
>  util/util.h is the right place for it. Another opinion are welcome. 
LGTM!

I'd wait till someone else reviews the patch, in case you want to be
sure that util/util.h is the right place for the defines.


Best Regards,
-- 
Fabiano Fidêncio

[Jakub Hrozek]

On Thu, Aug 04, 2016 at 08:41:34AM +0200, Fabiano Fidêncio wrote:
>  On Tue, Jul 26, 2016 at 4:01 PM, Petr Cech <pcech(a)redhat.com&gt;
> wrote:
>  > Hello list,
>  >
>  > attached patch fixes duplication of pid file declaration. I hope that the
>  > util/util.h is the right place for it. Another opinion are welcome.
>  
>  LGTM!
>  
>  I'd wait till someone else reviews the patch, in case you want to be
>  sure that util/util.h is the right place for the defines. 
It is, but I don't think that MONITOR_NAME belongs there. I think the
pidfile declaration can just use hardcoded sssd (or just #define
PIDFILE_BASENAME to "sssd") and MONITOR_NAME should stay in monitor.c

[Petr Cech]

On 08/04/2016 11:06 AM, Jakub Hrozek wrote:
>  On Thu, Aug 04, 2016 at 08:41:34AM +0200, Fabiano Fidêncio wrote:
> > On Tue, Jul 26, 2016 at 4:01 PM, Petr Cech <pcech(a)redhat.com&gt; wrote:
> >> Hello list,
> >>
> >> attached patch fixes duplication of pid file declaration. I hope that the
> >> util/util.h is the right place for it. Another opinion are welcome.
> >
> > LGTM!
> >
> > I'd wait till someone else reviews the patch, in case you want to be
> > sure that util/util.h is the right place for the defines.
>
>  It is, but I don't think that MONITOR_NAME belongs there. I think the
>  pidfile declaration can just use hardcoded sssd (or just #define
>  PIDFILE_BASENAME to "sssd") and MONITOR_NAME should stay in monitor.c 
Right, thank you. Fixed patch attached :-)

Regards

-- 
Petr^4 Čech

[Jakub Hrozek]

On Fri, Aug 05, 2016 at 02:49:59PM +0200, Petr Cech wrote:
>  On 08/04/2016 11:06 AM, Jakub Hrozek wrote:
>  > On Thu, Aug 04, 2016 at 08:41:34AM +0200, Fabiano Fidêncio wrote:
>  > > On Tue, Jul 26, 2016 at 4:01 PM, Petr Cech <pcech(a)redhat.com&gt; wrote:
>  > > > Hello list,
>  > > > 
>  > > > attached patch fixes duplication of pid file declaration. I hope that the
>  > > > util/util.h is the right place for it. Another opinion are welcome.
>  > > 
>  > > LGTM!
>  > > 
>  > > I'd wait till someone else reviews the patch, in case you want to be
>  > > sure that util/util.h is the right place for the defines.
>  > 
>  > It is, but I don't think that MONITOR_NAME belongs there. I think the
>  > pidfile declaration can just use hardcoded sssd (or just #define
>  > PIDFILE_BASENAME to "sssd") and MONITOR_NAME should stay in monitor.c
>  
>  Right, thank you. Fixed patch attached :-) 
ACK

CI: http://sssd-ci.duckdns.org/logs/job/51/12/summary.html

[Jakub Hrozek]

On Tue, Aug 09, 2016 at 11:27:12AM +0200, Jakub Hrozek wrote:
>  On Fri, Aug 05, 2016 at 02:49:59PM +0200, Petr Cech wrote:
>  > On 08/04/2016 11:06 AM, Jakub Hrozek wrote:
>  > > On Thu, Aug 04, 2016 at 08:41:34AM +0200, Fabiano Fidêncio wrote:
>  > > > On Tue, Jul 26, 2016 at 4:01 PM, Petr Cech <pcech(a)redhat.com&gt;
> wrote:
>  > > > > Hello list,
>  > > > > 
>  > > > > attached patch fixes duplication of pid file declaration. I hope that
> the
>  > > > > util/util.h is the right place for it. Another opinion are welcome.
>  > > > 
>  > > > LGTM!
>  > > > 
>  > > > I'd wait till someone else reviews the patch, in case you want to be
>  > > > sure that util/util.h is the right place for the defines.
>  > > 
>  > > It is, but I don't think that MONITOR_NAME belongs there. I think the
>  > > pidfile declaration can just use hardcoded sssd (or just #define
>  > > PIDFILE_BASENAME to "sssd") and MONITOR_NAME should stay in
> monitor.c
>  > 
>  > Right, thank you. Fixed patch attached :-)
>  
>  ACK
>  
>  CI: http://sssd-ci.duckdns.org/logs/job/51/12/summary.html 
* master: 08cd034c8584b6f058cf565ce66f7f9f7120622f