[PATCH] BUILD: Do not build libsss_ad_common.la as standard library

[Lukas Slebodnik]

ehlo,

libsss_ad_common.la was a dynamic library and was linked just with unit tests.
It was a workaroud because module libsss_ad.so cannot be linked with tests
without portability issues. But it was addted to pkglib_LTLIBRARIES
and therefore it was installed with other libraries.
This patch changed it and libsss_ad_test.la (old name libsss_ad_common.la)
will be compiled only for unit tests (check_LTLIBRARIES) and will not
be installed with command "make install".

LS

[Jakub Hrozek]

On Wed, Sep 23, 2015 at 06:42:36AM +0200, Lukas Slebodnik wrote:
> ehlo,
>
> libsss_ad_common.la was a dynamic library and was linked just with unit tests.
> It was a workaroud because module libsss_ad.so cannot be linked with tests
> without portability issues. But it was addted to pkglib_LTLIBRARIES
> and therefore it was installed with other libraries.
> This patch changed it and libsss_ad_test.la (old name libsss_ad_common.la)
> will be compiled only for unit tests (check_LTLIBRARIES) and will not
> be installed with command "make install".
>
> LS

Lukas asked me to review these patches and include in 1.13.1 so that we
have a cleaner build.

CI: http://sssd-ci.duckdns.org/logs/job/27/79/summary.html

The code looks good to me as well.

ACK

[Jakub Hrozek]

On Thu, Sep 24, 2015 at 05:43:10PM +0200, Jakub Hrozek wrote:
> On Wed, Sep 23, 2015 at 06:42:36AM +0200, Lukas Slebodnik wrote:
> > ehlo,
> >
> > libsss_ad_common.la was a dynamic library and was linked just with unit tests.
> > It was a workaroud because module libsss_ad.so cannot be linked with tests
> > without portability issues. But it was addted to pkglib_LTLIBRARIES
> > and therefore it was installed with other libraries.
> > This patch changed it and libsss_ad_test.la (old name libsss_ad_common.la)
> > will be compiled only for unit tests (check_LTLIBRARIES) and will not
> > be installed with command "make install".
> >
> > LS
>
> Lukas asked me to review these patches and include in 1.13.1 so that we
> have a cleaner build.
>
> CI: http://sssd-ci.duckdns.org/logs/job/27/79/summary.html
>
> The code looks good to me as well.
>
> ACK

* master:
    * a801d42c4637bbdf9664d0d8b913ffcab81b904e
    * f3d84d2b6f95ac68142a8f2dd757a83eddeb1abd