[sssd PR#565][opened] CACHE_REQ: Do not fail the domain locator plugin if ID outside the domain range is looked up
URL: https://github.com/SSSD/sssd/pull/565 Author: jhrozek Title: #565: CACHE_REQ: Do not fail the domain locator plugin if ID outside the domain range is looked up Action: opened
PR body: """ A fix for upstream bug #3569 and the domain-locator feature were both developed in the context of the same upstream version and therefore touched the same code, but the domain locator did not account for the ERR_ID_OUTSIDE_RANGE error code.
Therefore lookups for IDs that are outside the range for the domain caused the whole lookup to fail instead of carrying on to the next domain.
This patch just handles ERR_ID_OUTSIDE_RANGE the same way as if the ID was not found at all. Also some whitespace errors are fixed.
Resolves: https://pagure.io/SSSD/sssd/issue/3728 """
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/565/head:pr565 git checkout pr565
URL: https://github.com/SSSD/sssd/pull/565 Title: #565: CACHE_REQ: Do not fail the domain locator plugin if ID outside the domain range is looked up
fidencio commented: """ Patch looks good. I'm running the internal CI just for the sake of the process and I'll add the accepted label as soon as I get the results. """
See the full comment at https://github.com/SSSD/sssd/pull/565#issuecomment-386207639
URL: https://github.com/SSSD/sssd/pull/565 Title: #565: CACHE_REQ: Do not fail the domain locator plugin if ID outside the domain range is looked up
fidencio commented: """ CI: http://vm-031.$%7Babc%7D/logs/job/88/44/summary.html test_ipa_subdom_server failed and I've ran it a bunch of times without noticing any failure.
Ack! """
See the full comment at https://github.com/SSSD/sssd/pull/565#issuecomment-386341264
URL: https://github.com/SSSD/sssd/pull/565 Title: #565: CACHE_REQ: Do not fail the domain locator plugin if ID outside the domain range is looked up
Label: +Accepted
URL: https://github.com/SSSD/sssd/pull/565 Title: #565: CACHE_REQ: Do not fail the domain locator plugin if ID outside the domain range is looked up
fidencio commented: """ master: 2952de7 """
See the full comment at https://github.com/SSSD/sssd/pull/565#issuecomment-386421306
URL: https://github.com/SSSD/sssd/pull/565 Author: jhrozek Title: #565: CACHE_REQ: Do not fail the domain locator plugin if ID outside the domain range is looked up Action: closed
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/565/head:pr565 git checkout pr565
URL: https://github.com/SSSD/sssd/pull/565 Title: #565: CACHE_REQ: Do not fail the domain locator plugin if ID outside the domain range is looked up
Label: +Pushed
URL: https://github.com/SSSD/sssd/pull/565 Title: #565: CACHE_REQ: Do not fail the domain locator plugin if ID outside the domain range is looked up
Label: -Accepted
sssd-devel@lists.fedorahosted.org
-
fidencio -
jhrozek