[sssd PR#5663][opened] cache_req: replace FQNs by shortnames

[ikerexxe]

   URL: https://github.com/SSSD/sssd/pull/5663
Author: ikerexxe
 Title: #5663: cache_req: replace FQNs by shortnames
Action: opened

PR body:
"""
Replace FQNs by shortnames in cache_req_XYZ_by_name_send() when the FQN
already contains the domain name. This is done to avoid appending again
the domain name to the FQN.

Includes a unit test to check that the FQN to shortname replacement
works correctly.

It also includes an integration test to check that UpdateMemberList()
and GetAll() return the correct users that are members of a group. This
is done by first adding a member to a group and checking that it is
returned correctly. Then, the member is deleted and the interface returns
no members.

Resolves: https://github.com/SSSD/sssd/issues/4255
"""

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5663/head:pr5663
git checkout pr5663

[sssd PR#5663][+Bugzilla] cache_req: replace FQNs by shortnames

[ikerexxe]

  URL: https://github.com/SSSD/sssd/pull/5663
Title: #5663: cache_req: replace FQNs by shortnames

Label: +Bugzilla

[sssd PR#5663][+Waiting for review] cache_req: replace FQNs by shortnames

[ikerexxe]

  URL: https://github.com/SSSD/sssd/pull/5663
Title: #5663: cache_req: replace FQNs by shortnames

Label: +Waiting for review

[sssd PR#5663][synchronized] cache_req: replace FQNs by shortnames

[ikerexxe]

   URL: https://github.com/SSSD/sssd/pull/5663
Author: ikerexxe
 Title: #5663: cache_req: replace FQNs by shortnames
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5663/head:pr5663
git checkout pr5663

[sssd PR#5663][synchronized] cache_req: replace FQNs by shortnames

[ikerexxe]

   URL: https://github.com/SSSD/sssd/pull/5663
Author: ikerexxe
 Title: #5663: cache_req: replace FQNs by shortnames
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5663/head:pr5663
git checkout pr5663

[sssd PR#5663][synchronized] cache_req: replace FQNs by shortnames

[ikerexxe]

   URL: https://github.com/SSSD/sssd/pull/5663
Author: ikerexxe
 Title: #5663: cache_req: replace FQNs by shortnames
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5663/head:pr5663
git checkout pr5663

[sssd PR#5663][synchronized] cache_req: replace FQNs by shortnames

[ikerexxe]

   URL: https://github.com/SSSD/sssd/pull/5663
Author: ikerexxe
 Title: #5663: cache_req: replace FQNs by shortnames
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5663/head:pr5663
git checkout pr5663

[sssd PR#5663][+Deferred] cache_req: replace FQNs by shortnames

[alexey-tikhonov]

  URL: https://github.com/SSSD/sssd/pull/5663
Title: #5663: cache_req: replace FQNs by shortnames

Label: +Deferred

[sssd PR#5663][comment] cache_req: replace FQNs by shortnames

[alexey-tikhonov]

  URL: https://github.com/SSSD/sssd/pull/5663
Title: #5663: cache_req: replace FQNs by shortnames

alexey-tikhonov commented:
"""
(Postponed a bit. But ready for review.)
"""

See the full comment at https://github.com/SSSD/sssd/pull/5663#issuecomment-854457162

[sssd PR#5663][comment] cache_req: replace FQNs by shortnames

[pbrezina]

  URL: https://github.com/SSSD/sssd/pull/5663
Title: #5663: cache_req: replace FQNs by shortnames

pbrezina commented:
"""
How can I reproduce the issue?
"""

See the full comment at https://github.com/SSSD/sssd/pull/5663#issuecomment-862177207

[sssd PR#5663][comment] cache_req: replace FQNs by shortnames

[ikerexxe]

  URL: https://github.com/SSSD/sssd/pull/5663
Title: #5663: cache_req: replace FQNs by shortnames

ikerexxe commented:
"""
>  How can I reproduce the issue?
>  
There are two ways of doing it: manually following the instructions in
https://bugzilla.redhat.com/show_bug.cgi?id=1364596#c28 or automatically using the
integration test included in the PR (src/tests/intg/test_infopipe.py)
"""

See the full comment at https://github.com/SSSD/sssd/pull/5663#issuecomment-862233862

[sssd PR#5663][comment] cache_req: replace FQNs by shortnames

[pbrezina]

  URL: https://github.com/SSSD/sssd/pull/5663
Title: #5663: cache_req: replace FQNs by shortnames

pbrezina commented:
"""
Hi Iker, this does not fix the root cause of the issue, it just hides it. The cause is:

1. In
[`resolv_ghosts_send`](https://github.com/SSSD/sssd/blob/master/src/responder/ifp/ifp_groups.c#L672)
we load the qualified name from the cache and send cache request with both group name and
domain name set.
2. Then in
[`cache_req_process_input`](https://github.com/SSSD/sssd/blob/master/src/responder/common/cache_req/cache_req.c#L1182)
we hit this branch (because domain != NULL) and we assume that the input name does not
need to be parsed.
3. Therefore the parsed name is set to the input name (group@domain) and then we construct
group@domain@domain as the lookup name.

If think what needs to be done is to parse the name anyway to always get non-qualified
name and then check if the domain from parsed group name equals to domain from the input
parameter for safety.

"""

See the full comment at https://github.com/SSSD/sssd/pull/5663#issuecomment-863160953

[sssd PR#5663][-Waiting for review] cache_req: replace FQNs by shortnames

[pbrezina]

  URL: https://github.com/SSSD/sssd/pull/5663
Title: #5663: cache_req: replace FQNs by shortnames

Label: -Waiting for review

[sssd PR#5663][+Changes requested] cache_req: replace FQNs by shortnames

[pbrezina]

  URL: https://github.com/SSSD/sssd/pull/5663
Title: #5663: cache_req: replace FQNs by shortnames

Label: +Changes requested

[sssd PR#5663][synchronized] cache_req: replace FQNs by shortnames

[ikerexxe]

   URL: https://github.com/SSSD/sssd/pull/5663
Author: ikerexxe
 Title: #5663: cache_req: replace FQNs by shortnames
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5663/head:pr5663
git checkout pr5663

[sssd PR#5663][synchronized] cache_req: replace FQNs by shortnames

[ikerexxe]

   URL: https://github.com/SSSD/sssd/pull/5663
Author: ikerexxe
 Title: #5663: cache_req: replace FQNs by shortnames
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5663/head:pr5663
git checkout pr5663

[sssd PR#5663][edited] [WIP] cache_req: replace FQNs by shortnames

[ikerexxe]

   URL: https://github.com/SSSD/sssd/pull/5663
Author: ikerexxe
 Title: #5663: [WIP] cache_req: replace FQNs by shortnames
Action: edited

 Changed field: title
Original value:
"""
cache_req: replace FQNs by shortnames
"""

[sssd PR#5663][synchronized] [WIP] cache_req: replace FQNs by shortnames

[ikerexxe]

   URL: https://github.com/SSSD/sssd/pull/5663
Author: ikerexxe
 Title: #5663: [WIP] cache_req: replace FQNs by shortnames
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5663/head:pr5663
git checkout pr5663

[sssd PR#5663][comment] [WIP] cache_req: replace FQNs by shortnames

[ikerexxe]

  URL: https://github.com/SSSD/sssd/pull/5663
Title: #5663: [WIP] cache_req: replace FQNs by shortnames

ikerexxe commented:
"""
>  If think what needs to be done is to parse the name anyway to always
> get non-qualified name and then check if the domain from parsed group name equals to
> domain from the input parameter for safety.
>  
This isn't possible for all plugins. The filter plugins should avoid parsing the name,
but I don't know how to do it cleanly. Two methods come to my mind. The first one
consists in changing the `parse_name` to false for `cache_req_group_by_filter` and 
`cache_req_user_by_filter`. The other one to check the plugin name in the condition as
follows:
`if (cr->plugin->parse_name == false || strstr(cr->plugin->name,
"filter"))`. What do you think?


"""

See the full comment at https://github.com/SSSD/sssd/pull/5663#issuecomment-864954486

[sssd PR#5663][-Deferred] [WIP] cache_req: replace FQNs by shortnames

[alexey-tikhonov]

  URL: https://github.com/SSSD/sssd/pull/5663
Title: #5663: [WIP] cache_req: replace FQNs by shortnames

Label: -Deferred

[sssd PR#5663][comment] [WIP] cache_req: replace FQNs by shortnames

[pbrezina]

  URL: https://github.com/SSSD/sssd/pull/5663
Title: #5663: [WIP] cache_req: replace FQNs by shortnames

pbrezina commented:
"""
>  > If think what needs to be done is to parse the name anyway to
> always get non-qualified name and then check if the domain from parsed group name equals
> to domain from the input parameter for safety.
>  
>  This isn't possible for all plugins. The filter plugins should avoid parsing the
> name, but I don't know how to do it cleanly. Two 
>  
Why should it avoid parsing the name?

"""

See the full comment at https://github.com/SSSD/sssd/pull/5663#issuecomment-865823323

[sssd PR#5663][synchronized] [WIP] cache_req: replace FQNs by shortnames

[ikerexxe]

   URL: https://github.com/SSSD/sssd/pull/5663
Author: ikerexxe
 Title: #5663: [WIP] cache_req: replace FQNs by shortnames
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5663/head:pr5663
git checkout pr5663

[sssd PR#5663][edited] cache_req: replace FQNs by shortnames

[ikerexxe]

   URL: https://github.com/SSSD/sssd/pull/5663
Author: ikerexxe
 Title: #5663: cache_req: replace FQNs by shortnames
Action: edited

 Changed field: title
Original value:
"""
[WIP] cache_req: replace FQNs by shortnames
"""

[sssd PR#5663][comment] cache_req: replace FQNs by shortnames

[ikerexxe]

  URL: https://github.com/SSSD/sssd/pull/5663
Title: #5663: cache_req: replace FQNs by shortnames

ikerexxe commented:
"""
>  Why should it avoid parsing the name?
>  
Sorry, my mistake. I thought that the unit test failures were related with the parsing
functionality being unable to parse correctly the filtered request data.

I think that the changes are ready for a new round of review.

"""

See the full comment at https://github.com/SSSD/sssd/pull/5663#issuecomment-866643715

[sssd PR#5663][-Changes requested] cache_req: replace FQNs by shortnames

[ikerexxe]

  URL: https://github.com/SSSD/sssd/pull/5663
Title: #5663: cache_req: replace FQNs by shortnames

Label: -Changes requested

[sssd PR#5663][+Waiting for review] cache_req: replace FQNs by shortnames

[ikerexxe]

  URL: https://github.com/SSSD/sssd/pull/5663
Title: #5663: cache_req: replace FQNs by shortnames

Label: +Waiting for review

[sssd PR#5663][-Waiting for review] cache_req: replace FQNs by shortnames

[pbrezina]

  URL: https://github.com/SSSD/sssd/pull/5663
Title: #5663: cache_req: replace FQNs by shortnames

Label: -Waiting for review

[sssd PR#5663][+Changes requested] cache_req: replace FQNs by shortnames

[pbrezina]

  URL: https://github.com/SSSD/sssd/pull/5663
Title: #5663: cache_req: replace FQNs by shortnames

Label: +Changes requested

[sssd PR#5663][synchronized] cache_req: replace FQNs by shortnames

[ikerexxe]

   URL: https://github.com/SSSD/sssd/pull/5663
Author: ikerexxe
 Title: #5663: cache_req: replace FQNs by shortnames
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5663/head:pr5663
git checkout pr5663

[sssd PR#5663][+Waiting for review] cache_req: replace FQNs by shortnames

[ikerexxe]

  URL: https://github.com/SSSD/sssd/pull/5663
Title: #5663: cache_req: replace FQNs by shortnames

Label: +Waiting for review

[sssd PR#5663][-Changes requested] cache_req: replace FQNs by shortnames

[ikerexxe]

  URL: https://github.com/SSSD/sssd/pull/5663
Title: #5663: cache_req: replace FQNs by shortnames

Label: -Changes requested

[sssd PR#5663][comment] cache_req: replace FQNs by shortnames

[pbrezina]

  URL: https://github.com/SSSD/sssd/pull/5663
Title: #5663: cache_req: replace FQNs by shortnames

pbrezina commented:
"""
Thank you. Ack.
"""

See the full comment at https://github.com/SSSD/sssd/pull/5663#issuecomment-876310432

[sssd PR#5663][-Waiting for review] cache_req: replace FQNs by shortnames

[pbrezina]

  URL: https://github.com/SSSD/sssd/pull/5663
Title: #5663: cache_req: replace FQNs by shortnames

Label: -Waiting for review

[sssd PR#5663][+Ready to push] cache_req: replace FQNs by shortnames

[pbrezina]

  URL: https://github.com/SSSD/sssd/pull/5663
Title: #5663: cache_req: replace FQNs by shortnames

Label: +Ready to push

[sssd PR#5663][+Accepted] cache_req: replace FQNs by shortnames

[pbrezina]

  URL: https://github.com/SSSD/sssd/pull/5663
Title: #5663: cache_req: replace FQNs by shortnames

Label: +Accepted

[sssd PR#5663][comment] cache_req: replace FQNs by shortnames

[pbrezina]

  URL: https://github.com/SSSD/sssd/pull/5663
Title: #5663: cache_req: replace FQNs by shortnames

pbrezina commented:
"""
Pushed PR: https://github.com/SSSD/sssd/pull/5663

* `master`
    * 865330c651064977477121961bcd084af02bb0d9 - cache_req: parse name to get shortname

"""

See the full comment at https://github.com/SSSD/sssd/pull/5663#issuecomment-876324108

[sssd PR#5663][+Pushed] cache_req: replace FQNs by shortnames

[pbrezina]

  URL: https://github.com/SSSD/sssd/pull/5663
Title: #5663: cache_req: replace FQNs by shortnames

Label: +Pushed

[sssd PR#5663][-Accepted] cache_req: replace FQNs by shortnames

[pbrezina]

  URL: https://github.com/SSSD/sssd/pull/5663
Title: #5663: cache_req: replace FQNs by shortnames

Label: -Accepted

[sssd PR#5663][-Ready to push] cache_req: replace FQNs by shortnames

[pbrezina]

  URL: https://github.com/SSSD/sssd/pull/5663
Title: #5663: cache_req: replace FQNs by shortnames

Label: -Ready to push

[sssd PR#5663][closed] cache_req: replace FQNs by shortnames

[pbrezina]

   URL: https://github.com/SSSD/sssd/pull/5663
Author: ikerexxe
 Title: #5663: cache_req: replace FQNs by shortnames
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5663/head:pr5663
git checkout pr5663