Hi,
While I was talking to the Fedora automake maintainer about an enhancement related to test environment, he suggested to make the change in the attached patch.
On Fri, 2014-10-03 at 16:46 +0200, Jakub Hrozek wrote:
Hi,
While I was talking to the Fedora automake maintainer about an enhancement related to test environment, he suggested to make the change in the attached patch.
How far back does that macro go? Does it cover all platforms that SSSD presently supports? (I'm thinking primarily of RHEL 6 here)
On (03/10/14 11:00), Stephen Gallagher wrote:
On Fri, 2014-10-03 at 16:46 +0200, Jakub Hrozek wrote:
Hi,
While I was talking to the Fedora automake maintainer about an enhancement related to test environment, he suggested to make the change in the attached patch.
How far back does that macro go? Does it cover all platforms that SSSD presently supports? (I'm thinking primarily of RHEL 6 here)
I checked and it is on rhel6, (/usr/share/autoconf/autoconf/programs.m4) but if we want to be good we can provide fallback, which was used in Makefile.am anyway.
diff --git a/configure.ac b/configure.ac index 2e1722d..eefb4e4 100644 --- a/configure.ac +++ b/configure.ac @@ -19,6 +19,9 @@ AM_PROG_CC_C_O m4_ifdef([AM_PROG_AR], [AM_PROG_AR]) AC_DISABLE_STATIC AC_PROG_INSTALL +m4_ifdef([AC_PROG_MKDIR_P], + [AC_PROG_MKDIR_P], + [MKDIR_P="mkdir -p"]) AC_PROG_LIBTOOL LT_LIB_DLLOAD AC_CONFIG_MACRO_DIR([m4])
LS
On Fri, Oct 03, 2014 at 05:37:29PM +0200, Lukas Slebodnik wrote:
On (03/10/14 11:00), Stephen Gallagher wrote:
On Fri, 2014-10-03 at 16:46 +0200, Jakub Hrozek wrote:
Hi,
While I was talking to the Fedora automake maintainer about an enhancement related to test environment, he suggested to make the change in the attached patch.
How far back does that macro go? Does it cover all platforms that SSSD presently supports? (I'm thinking primarily of RHEL 6 here)
I checked and it is on rhel6, (/usr/share/autoconf/autoconf/programs.m4) but if we want to be good we can provide fallback, which was used in Makefile.am anyway.
diff --git a/configure.ac b/configure.ac index 2e1722d..eefb4e4 100644 --- a/configure.ac +++ b/configure.ac @@ -19,6 +19,9 @@ AM_PROG_CC_C_O m4_ifdef([AM_PROG_AR], [AM_PROG_AR]) AC_DISABLE_STATIC AC_PROG_INSTALL +m4_ifdef([AC_PROG_MKDIR_P],
- [AC_PROG_MKDIR_P],
- [MKDIR_P="mkdir -p"])
AC_PROG_LIBTOOL LT_LIB_DLLOAD AC_CONFIG_MACRO_DIR([m4])
LS
That's a good idea, thank you.
On (03/10/14 18:07), Jakub Hrozek wrote:
On Fri, Oct 03, 2014 at 05:37:29PM +0200, Lukas Slebodnik wrote:
On (03/10/14 11:00), Stephen Gallagher wrote:
On Fri, 2014-10-03 at 16:46 +0200, Jakub Hrozek wrote:
Hi,
While I was talking to the Fedora automake maintainer about an enhancement related to test environment, he suggested to make the change in the attached patch.
How far back does that macro go? Does it cover all platforms that SSSD presently supports? (I'm thinking primarily of RHEL 6 here)
I checked and it is on rhel6, (/usr/share/autoconf/autoconf/programs.m4) but if we want to be good we can provide fallback, which was used in Makefile.am anyway.
diff --git a/configure.ac b/configure.ac index 2e1722d..eefb4e4 100644 --- a/configure.ac +++ b/configure.ac @@ -19,6 +19,9 @@ AM_PROG_CC_C_O m4_ifdef([AM_PROG_AR], [AM_PROG_AR]) AC_DISABLE_STATIC AC_PROG_INSTALL +m4_ifdef([AC_PROG_MKDIR_P],
- [AC_PROG_MKDIR_P],
- [MKDIR_P="mkdir -p"])
AC_PROG_LIBTOOL LT_LIB_DLLOAD AC_CONFIG_MACRO_DIR([m4])
LS
That's a good idea, thank you.
From 0560ae73e66d338733d3df60a595f647d4ed9a4d Mon Sep 17 00:00:00 2001 From: Jakub Hrozek jhrozek@redhat.com Date: Wed, 1 Oct 2014 14:26:34 +0200 Subject: [PATCH] BUILD: Use $(MKDIR_P) in Makefile.am
It was suggested by the Fedora automake maintainer to use the autoconf macro $(MKDIR_P) instead of calling "mkdir -p" directly as the macro is more portable and might actually expand to something else than "mkdir
-p" on some platforms (usually it would be a variant of install.sh)
Works even with epel5
ACK
LS
On Mon, Oct 06, 2014 at 10:08:08AM +0200, Lukas Slebodnik wrote:
On (03/10/14 18:07), Jakub Hrozek wrote:
On Fri, Oct 03, 2014 at 05:37:29PM +0200, Lukas Slebodnik wrote:
On (03/10/14 11:00), Stephen Gallagher wrote:
On Fri, 2014-10-03 at 16:46 +0200, Jakub Hrozek wrote:
Hi,
While I was talking to the Fedora automake maintainer about an enhancement related to test environment, he suggested to make the change in the attached patch.
How far back does that macro go? Does it cover all platforms that SSSD presently supports? (I'm thinking primarily of RHEL 6 here)
I checked and it is on rhel6, (/usr/share/autoconf/autoconf/programs.m4) but if we want to be good we can provide fallback, which was used in Makefile.am anyway.
diff --git a/configure.ac b/configure.ac index 2e1722d..eefb4e4 100644 --- a/configure.ac +++ b/configure.ac @@ -19,6 +19,9 @@ AM_PROG_CC_C_O m4_ifdef([AM_PROG_AR], [AM_PROG_AR]) AC_DISABLE_STATIC AC_PROG_INSTALL +m4_ifdef([AC_PROG_MKDIR_P],
- [AC_PROG_MKDIR_P],
- [MKDIR_P="mkdir -p"])
AC_PROG_LIBTOOL LT_LIB_DLLOAD AC_CONFIG_MACRO_DIR([m4])
LS
That's a good idea, thank you.
From 0560ae73e66d338733d3df60a595f647d4ed9a4d Mon Sep 17 00:00:00 2001 From: Jakub Hrozek jhrozek@redhat.com Date: Wed, 1 Oct 2014 14:26:34 +0200 Subject: [PATCH] BUILD: Use $(MKDIR_P) in Makefile.am
It was suggested by the Fedora automake maintainer to use the autoconf macro $(MKDIR_P) instead of calling "mkdir -p" directly as the macro is more portable and might actually expand to something else than "mkdir
-p" on some platforms (usually it would be a variant of install.sh)
Works even with epel5
ACK
LS
* master: 87d3b47abba6a40fcf809c85a2b138bc1013d9c5
sssd-devel@lists.fedorahosted.org
-
Jakub Hrozek -
Lukas Slebodnik -
Stephen Gallagher