URL: https://github.com/SSSD/sssd/pull/5260 Author: ikerexxe Title: #5260: config: allow prompting options in configuration Action: opened
PR body: """ False warnings were logged after enabling prompting options in configuration file. This change modifies the configuration rules to allow prompting options.
Resolves: https://github.com/SSSD/sssd/issues/5259 """
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5260/head:pr5260 git checkout pr5260
URL: https://github.com/SSSD/sssd/pull/5260 Title: #5260: config: allow prompting options in configuration
Label: +Waiting for review
URL: https://github.com/SSSD/sssd/pull/5260 Title: #5260: config: allow prompting options in configuration
sumit-bose commented: """ Hi,
thanks for the patch, it mostly works as expected but should be a bit more strict, see inline comments.
bye, Sumit """
See the full comment at https://github.com/SSSD/sssd/pull/5260#issuecomment-669985631
URL: https://github.com/SSSD/sssd/pull/5260 Author: ikerexxe Title: #5260: config: allow prompting options in configuration Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5260/head:pr5260 git checkout pr5260
URL: https://github.com/SSSD/sssd/pull/5260 Author: ikerexxe Title: #5260: config: allow prompting options in configuration Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5260/head:pr5260 git checkout pr5260
URL: https://github.com/SSSD/sssd/pull/5260 Title: #5260: config: allow prompting options in configuration
ikerexxe commented: """
Hi,
thanks for the patch, it mostly works as expected but should be a bit more strict, see inline comments.
bye, Sumit
I wasn't sure about those options, so I decided to include them. Taking into account your comment I have removed them. Thanks for your feedback. """
See the full comment at https://github.com/SSSD/sssd/pull/5260#issuecomment-670387946
URL: https://github.com/SSSD/sssd/pull/5260 Title: #5260: config: allow prompting options in configuration
sumit-bose commented: """ Hi,
thanks for the changes, ACK.
bye, Sumit """
See the full comment at https://github.com/SSSD/sssd/pull/5260#issuecomment-670474364
URL: https://github.com/SSSD/sssd/pull/5260 Title: #5260: config: allow prompting options in configuration
Label: -Waiting for review
URL: https://github.com/SSSD/sssd/pull/5260 Title: #5260: config: allow prompting options in configuration
Label: +Accepted
URL: https://github.com/SSSD/sssd/pull/5260 Title: #5260: config: allow prompting options in configuration
Label: +Ready to push
URL: https://github.com/SSSD/sssd/pull/5260 Title: #5260: config: allow prompting options in configuration
pbrezina commented: """ Pushed PR: https://github.com/SSSD/sssd/pull/5260
* `master` * 4526858adb58736066a0b2cf2dc793ddfe671b2b - config: allow prompting options in configuration
"""
See the full comment at https://github.com/SSSD/sssd/pull/5260#issuecomment-677496308
URL: https://github.com/SSSD/sssd/pull/5260 Title: #5260: config: allow prompting options in configuration
Label: +Pushed
URL: https://github.com/SSSD/sssd/pull/5260 Title: #5260: config: allow prompting options in configuration
Label: -Accepted
URL: https://github.com/SSSD/sssd/pull/5260 Title: #5260: config: allow prompting options in configuration
Label: -Ready to push
URL: https://github.com/SSSD/sssd/pull/5260 Author: ikerexxe Title: #5260: config: allow prompting options in configuration Action: closed
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5260/head:pr5260 git checkout pr5260
sssd-devel@lists.fedorahosted.org
-
ikerexxe -
pbrezina
-
sumit-bose