[sssd PR#564][opened] Do not keep allocating external groups on a long-lived context

[jhrozek]

URL: https://github.com/SSSD/sssd/pull/564
Author: jhrozek
 Title: #564: Do not keep allocating external groups on a long-lived context
Action: opened

PR body:
"""
The hash table with the external groups was never freed, so the
server_mode->ext_groups context was growing over time.

This patch keeps the new hash on the state if something failed, then frees
the previous hash and finally steals the new hash onto the server mode.

Resolves: https://pagure.io/SSSD/sssd/issue/3719
"""

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/564/head:pr564
git checkout pr564

[sssd PR#564][comment] Do not keep allocating external groups on a long-lived context

[fidencio]

URL: https://github.com/SSSD/sssd/pull/564
Title: #564: Do not keep allocating external groups on a long-lived context

fidencio commented:
"""
Patch looks good. I'm running the internal CI just for the sake of the process and I'll add the accepted label as soon as I get the results.
"""

See the full comment at https://github.com/SSSD/sssd/pull/564#issuecomment-386208049

[sssd PR#564][comment] Do not keep allocating external groups on a long-lived context

[jhrozek]

URL: https://github.com/SSSD/sssd/pull/564
Title: #564: Do not keep allocating external groups on a long-lived context

jhrozek commented:
"""
> On 3 May 2018, at 09:07, fidencio  wrote:
>
> Patch looks good. I'm running the internal CI just for the sake of the process and I'll add the accepted label as soon as I get the results.

btw if you are also going to push the patches, please add Sumit as the reviewer as well. He actually found the bug, I’m just the one who typed in the code, then Sumit reviewed it on IRC. I was even considering adding him as author, but that wouldn’t be ‘clean’ either and I hope it’s OK to commit like this.
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub, or mute the thread.

"""

See the full comment at https://github.com/SSSD/sssd/pull/564#issuecomment-386213826

[sssd PR#564][comment] Do not keep allocating external groups on a long-lived context

[fidencio]

URL: https://github.com/SSSD/sssd/pull/564
Title: #564: Do not keep allocating external groups on a long-lived context

fidencio commented:
"""
In situations like this I really would like to (if @sumit-bose agrees) to add a Signed-off-by: Sumit ...

Is that okay for you, @jhrozek?
"""

See the full comment at https://github.com/SSSD/sssd/pull/564#issuecomment-386214716

[sssd PR#564][comment] Do not keep allocating external groups on a long-lived context

[jhrozek]

URL: https://github.com/SSSD/sssd/pull/564
Title: #564: Do not keep allocating external groups on a long-lived context

jhrozek commented:
"""
> On 3 May 2018, at 09:41, fidencio  wrote:
>
> In situations like this I really would like to (if @sumit-bose agrees) to add a Signed-off-by: Sumit ...
>
> Is that okay for you, @jhrozek?

Anything is OK by me :)

"""

See the full comment at https://github.com/SSSD/sssd/pull/564#issuecomment-386215253

[sssd PR#564][comment] Do not keep allocating external groups on a long-lived context

[fidencio]

URL: https://github.com/SSSD/sssd/pull/564
Title: #564: Do not keep allocating external groups on a long-lived context

fidencio commented:
"""
Ack!
CI: http://vm-031.abc.idm.lab.eng.brq.redhat.com/logs/job/88/43/summary.html
"""

See the full comment at https://github.com/SSSD/sssd/pull/564#issuecomment-386280572

[sssd PR#564][+Accepted] Do not keep allocating external groups on a long-lived context

[fidencio]

URL: https://github.com/SSSD/sssd/pull/564
Title: #564: Do not keep allocating external groups on a long-lived context

Label: +Accepted

[sssd PR#564][comment] Do not keep allocating external groups on a long-lived context

[fidencio]

URL: https://github.com/SSSD/sssd/pull/564
Title: #564: Do not keep allocating external groups on a long-lived context

fidencio commented:
"""
Ack!
CI: http://vm-031.$%7Babc%7D/logs/job/88/43/summary.html
"""

See the full comment at https://github.com/SSSD/sssd/pull/564#issuecomment-386280572

[sssd PR#564][comment] Do not keep allocating external groups on a long-lived context

[fidencio]

URL: https://github.com/SSSD/sssd/pull/564
Title: #564: Do not keep allocating external groups on a long-lived context

fidencio commented:
"""
master:
 10213ef
"""

See the full comment at https://github.com/SSSD/sssd/pull/564#issuecomment-386420892

[sssd PR#564][closed] Do not keep allocating external groups on a long-lived context

[fidencio]

URL: https://github.com/SSSD/sssd/pull/564
Author: jhrozek
 Title: #564: Do not keep allocating external groups on a long-lived context
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/564/head:pr564
git checkout pr564

[sssd PR#564][-Accepted] Do not keep allocating external groups on a long-lived context

[fidencio]

URL: https://github.com/SSSD/sssd/pull/564
Title: #564: Do not keep allocating external groups on a long-lived context

Label: -Accepted

[sssd PR#564][+Pushed] Do not keep allocating external groups on a long-lived context

[fidencio]

URL: https://github.com/SSSD/sssd/pull/564
Title: #564: Do not keep allocating external groups on a long-lived context

Label: +Pushed