URL: https://github.com/SSSD/sssd/pull/408 Author: akamensky Title: #408: Backport of PR#275 to SSSD-1.14 Action: opened
PR body: """ This patch is a backport of PR #275 for SSSD v1.14
Should only be merged after original PR is accepted. """
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/408/head:pr408 git checkout pr408
URL: https://github.com/SSSD/sssd/pull/408 Title: #408: Backport of PR#275 to SSSD-1.14
centos-ci commented: """ Can one of the admins verify this patch? """
See the full comment at https://github.com/SSSD/sssd/pull/408#issuecomment-337165214
URL: https://github.com/SSSD/sssd/pull/408 Title: #408: Backport of PR#275 to SSSD-1.14
centos-ci commented: """ Can one of the admins verify this patch? """
See the full comment at https://github.com/SSSD/sssd/pull/408#issuecomment-337165216
URL: https://github.com/SSSD/sssd/pull/408 Title: #408: Backport of PR#275 to SSSD-1.14
fidencio commented: """ ok to test """
See the full comment at https://github.com/SSSD/sssd/pull/408#issuecomment-337266156
URL: https://github.com/SSSD/sssd/pull/408 Author: akamensky Title: #408: Backport of PR#275 to SSSD-1.14 Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/408/head:pr408 git checkout pr408
URL: https://github.com/SSSD/sssd/pull/408 Author: akamensky Title: #408: Backport of PR#275 to SSSD-1.14 Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/408/head:pr408 git checkout pr408
URL: https://github.com/SSSD/sssd/pull/408 Title: #408: Backport of PR#275 to SSSD-1.14
lslebodn commented: """ I would prefer have new features only in new versions of sssd. and this patch is not a bug fix but RFE.
BTW most of recent distributions already have sssd-1.15. which can easily backport this patch. Could you explain why did you decided to create PRs also for older branches? """
See the full comment at https://github.com/SSSD/sssd/pull/408#issuecomment-337922093
URL: https://github.com/SSSD/sssd/pull/408 Title: #408: Backport of PR#275 to SSSD-1.14
akamensky commented: """ I understand that it would be good to keep new functionality only in new versions. And in any other situation I would that the same.
However since the main patch comes from my business needs (actually my employers needs) and those needs require us using the same approach across wide variety of existing systems which include EL6 based systems as well as Ubuntu16.04/14.04 and Debian and Amazon Linux, I need to make it work on those systems. Also note many of our new coming customers still require el6 for legacy reasons. And I cannot keep maintaining self compiled packages over a long period of time. Thus it would be perfect (in my situation) if these could be backported to maintenance branches. """
See the full comment at https://github.com/SSSD/sssd/pull/408#issuecomment-337946672
URL: https://github.com/SSSD/sssd/pull/408 Title: #408: Backport of PR#275 to SSSD-1.14
lslebodn commented: """
I understand that it would be good to keep new functionality only in new versions. And in any other situation I would that the same.
Thank you very much for understanding.
However since the main patch comes from my business needs (actually my employers needs) and those needs require us using the same approach across wide variety of existing systems which include EL6 based systems as well as Ubuntu16.04/14.04 and Debian and Amazon Linux, I need to make it work on those systems. Also note many of our new coming customers still require el6 for legacy reasons. And I cannot keep maintaining self compiled packages over a long period of time. Thus it would be perfect (in my situation) if these could be backported to maintenance branches.
This is a problem of downstream distribution that they rely on new features and cannot rebase. I would prefer to backport it later to LTM branch(1.13) after confirmation from many users that it work reliably and they really need it there.
I'm quite fine with backporting it to 1.14 because it will soon become unsupported branch by upstream (the same as branches older then 1-13).
I will wait for opinion from other developers. (1 week :-) """
See the full comment at https://github.com/SSSD/sssd/pull/408#issuecomment-338171007
URL: https://github.com/SSSD/sssd/pull/408 Title: #408: Backport of PR#275 to SSSD-1.14
jhrozek commented: """ I'm not sure if it's realistic to get feedback from "many users" if this is something that @akamensky's environment needs and so far nobody else requested this feature either.
But let me ask differently - @akamensky, first if we released the 1.13 and 1.14 tarballs with this fix, do you expect the distributions that use those branches to pick up the tarball or are you going to patch them yourself or are you going to open a bug against those distriubutions to pick up this patch only? Do you have a timeline when you want to deploy the new packages?
In general, I don't have a huge issue with backporting this PR to older branches, because it's "opt-in", so it doesn't affect anyone without explicitly configuring the new feature. """
See the full comment at https://github.com/SSSD/sssd/pull/408#issuecomment-338174610
URL: https://github.com/SSSD/sssd/pull/408 Title: #408: Backport of PR#275 to SSSD-1.14
jhrozek commented: """ btw what I meant to say above is -- even if we backport the feature to stable branches of upstream, there is no guarantee that distributions will include it. At the very least, RHEL-6 won't, simply because it's too late in the RHEL-6 cycle and all bugs must be approved by the RHEL product management.. """
See the full comment at https://github.com/SSSD/sssd/pull/408#issuecomment-338174945
URL: https://github.com/SSSD/sssd/pull/408 Title: #408: Backport of PR#275 to SSSD-1.14
akamensky commented: """
I'm quite fine with backporting it to 1.14 because it will soon become unsupported branch by upstream (the same as branches older then 1-13).
On a good day I would be against doing even that. As per semver these changes technically should not go to any earlier version.
As I mentioned we manage quite a variety of systems, which are not _our_ systems, but we manage them. Thus we are not in control of what distribution or version it is.
SSSD is moving forward very fast, which is a good thing I believe and I wish it can keep doing so. However many other tools are not moving so fast. Which creates a situation where many systems (not only our systems but from my experience of doing this job for quite awhile most of the systems on the planet) are seriously behind. Yes, I wish everyone was on EL7 already, but in fact we only have about 2-3% of systems which are el7, most are for legacy reasons still on el6 (and a few are even el5, but let's disregard those). And that is for RHEL, there is also Debian and Ubuntu systems with the same problem. ALL except 1 of our Ubuntu customers are 14.04, which doesn't even have more recent 1.13 SSSD, and even 1.13 is not going to build there. We so far have only 1 customer with 16.04, which is going to build only 1.13 (any newer is out of the question there unless I want to build half of the system in my own repos). And not to mention Amazon Linux and Aliyun Linux which are outright "cronenbergs" of what should have been rhel6.
Unfortunately maintainers of packages on these systems do not want to introduce newer versions of packages easily, which means recent versions of SSSD won't make it to repositories or won't even build there (e.g. Ubuntu 16.04, only 1.13 branch builds there anything newer is out of the question due to many deps). However those maintainers do update packages on a patch releases which is what going to happen with all backports to 1.13 and 1.14 branches.
I am not so sure what is actually going to be policy for RHEL6, but AFAIK Centos6 will take any new release of 1.13 branch into updates repository (Centos6 still supported until 2020 as far as I recall). Ubuntu has a PPA for 16.04 with 1.13 branch in it, which I believe will also get updated (same is for Debian). Same comes for cronenbergs of cloud computing - they even moved on to 1.14, and they will include this update eventually if it is released.
As I mentioned in the beginning, I usually would not try to introduce new functionality in backports as that is only logical, but given the above and also the fact that these changes are not introducing any new dependencies (and in fact use so little of dependencies that it easily can be backported to 1.13), so I would like to give it a shot :)
Finally, I think I should not be pushing it too much as I know dev team is quite busy making a release and working on other tickets, which is a great thing, so I with the above concerns already expressed I will leave it for your consideration """
See the full comment at https://github.com/SSSD/sssd/pull/408#issuecomment-338195179
URL: https://github.com/SSSD/sssd/pull/408 Title: #408: Backport of PR#275 to SSSD-1.14
jhrozek commented: """ Again, I'm not against backporting the patches in principle. But at the very least RHEL-6 (and CentOS-6 is just a rebuilt of RHEL) will NOT pick the 1.13.5 release as a whole. RHEL-6, at this point, only cherry-picks important patches on a per-case-by-case basis.
So, that's what I'm getting at, I'm fine with backporting the patch to upstream, but I'm afraid your expectation that the patch will bubble to the next RHEL-6 release is incorrect. At this late stage of RHEL-6 lifetime, the only way to get a patch to RHEL-6 is to open a support request with Red Hat. (And no, I can't do it, despite working for Red Hat, the case must really come from a customer)
(That is not true for RHEL-7, where we rebase to the next available upstream release, which means your patch WILL be present in RHEL-7.5) """
See the full comment at https://github.com/SSSD/sssd/pull/408#issuecomment-338197109
URL: https://github.com/SSSD/sssd/pull/408 Title: #408: Backport of PR#275 to SSSD-1.14
jhrozek commented: """ btw you might be right about Ubuntu, IIRC they do rebase to newer releases in maintenance releases as well. But I don't know for sure. """
See the full comment at https://github.com/SSSD/sssd/pull/408#issuecomment-338197210
URL: https://github.com/SSSD/sssd/pull/408 Title: #408: Backport of PR#275 to SSSD-1.14
akamensky commented: """ Thank you for clarification on RH inner processes.
Yes, I understand it might not make its way to el6 (and we have a plan for next year to attempt to phase them all out in favor of el7, though it is up to a customer after all and it is a lengthy and painful process). However it will still make its way to Ubuntu/Debian/Amazon/Aliyun, without those backports however only option is to maintain our own patched package in our own repo (which is not the right way of doing things in my humble opinion). """
See the full comment at https://github.com/SSSD/sssd/pull/408#issuecomment-338201094
URL: https://github.com/SSSD/sssd/pull/408 Title: #408: Backport of PR#275 to SSSD-1.14
akamensky commented: """ Thank you for clarification on RH inner processes.
Yes, I understand it might not make its way to el6 (and we have a plan for next year to attempt to phase them all out in favor of el7, though it is up to a customer after all and it is a lengthy and painful process). However it will still make its way to Ubuntu/Debian/Amazon/Aliyun, without those backports however only option is to maintain our own patched package in our own repo (which is not the right way of doing things in my humble opinion).
On the other hand we might also file a request as a customer (we do have RHEL6 as well, not just Centos6). """
See the full comment at https://github.com/SSSD/sssd/pull/408#issuecomment-338201094
URL: https://github.com/SSSD/sssd/pull/408 Title: #408: Backport of PR#275 to SSSD-1.14
lslebodn commented: """ sssd-1-14: * 5b6157d7df029d760b8e8568a051c79077a42a03 """
See the full comment at https://github.com/SSSD/sssd/pull/408#issuecomment-344272652
URL: https://github.com/SSSD/sssd/pull/408 Author: akamensky Title: #408: Backport of PR#275 to SSSD-1.14 Action: closed
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/408/head:pr408 git checkout pr408
URL: https://github.com/SSSD/sssd/pull/408 Title: #408: Backport of PR#275 to SSSD-1.14
Label: +Pushed
sssd-devel@lists.fedorahosted.org
-
akamensky -
centos-ci
-
fidencio
-
jhrozek
-
lslebodn