URL: https://github.com/SSSD/sssd/pull/47 Author: jhrozek Title: #47: BUILD: Fix build without /sbin/service installed on the build host Action: opened
PR body: """ There were some issues in the sssctl-related patches that we pushed recently. First, the build failed if no service binary was around, which is wrong, we should just proceed and build without the sssctl functionality.
Second, we should make sure that on RHEL-6, /sbin/service is around during both build and runtime. """
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/47/head:pr47 git checkout pr47
URL: https://github.com/SSSD/sssd/pull/47 Title: #47: BUILD: Fix build without /sbin/service installed on the build host
pbrezina commented: """ Is there any system that doesn't have /sbin/service? """
See the full comment at https://github.com/SSSD/sssd/pull/47#issuecomment-253150301
URL: https://github.com/SSSD/sssd/pull/47 Title: #47: BUILD: Fix build without /sbin/service installed on the build host
jhrozek commented: """ Apparently our CI, see the master build status :). And I guess especially Debian-based systems or other distributions might rely on the bad old Unix way of restarting services (`/etc/rc.d/foo stop`) """
See the full comment at https://github.com/SSSD/sssd/pull/47#issuecomment-253156726
URL: https://github.com/SSSD/sssd/pull/47 Author: jhrozek Title: #47: BUILD: Fix build without /sbin/service installed on the build host Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/47/head:pr47 git checkout pr47
URL: https://github.com/SSSD/sssd/pull/47 Author: jhrozek Title: #47: BUILD: Fix build without /sbin/service installed on the build host Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/47/head:pr47 git checkout pr47
URL: https://github.com/SSSD/sssd/pull/47 Title: #47: BUILD: Fix build without /sbin/service installed on the build host
jhrozek commented: """ @lslebodn suggested on IRC to only search for service in /sbin and /usr/sbin. I added another patch that does that..
CI: http://sssd-ci.duckdns.org/logs/job/54/99/summary.html """
See the full comment at https://github.com/SSSD/sssd/pull/47#issuecomment-253755197
URL: https://github.com/SSSD/sssd/pull/47 Title: #47: BUILD: Fix build without /sbin/service installed on the build host
Label: +Changes requested
URL: https://github.com/SSSD/sssd/pull/47 Author: jhrozek Title: #47: BUILD: Fix build without /sbin/service installed on the build host Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/47/head:pr47 git checkout pr47
URL: https://github.com/SSSD/sssd/pull/47 Title: #47: BUILD: Fix build without /sbin/service installed on the build host
Label: -Changes requested
URL: https://github.com/SSSD/sssd/pull/47 Title: #47: BUILD: Fix build without /sbin/service installed on the build host
jhrozek commented: """ OK, new patches pushed """
See the full comment at https://github.com/SSSD/sssd/pull/47#issuecomment-253790438
URL: https://github.com/SSSD/sssd/pull/47 Title: #47: BUILD: Fix build without /sbin/service installed on the build host
lslebodn commented: """ I hope you noticed that CI build failed: https://ci.centos.org/job/sssd-CentOS6/87/ and https://ci.centos.org/job/sssd-CentOS7/100/ ``` error: Unclosed %if Traceback (most recent call last): File "/root/payload/contrib/ci/rpm-spec-builddeps", line 33, in <module> spec = rpm.spec(sys.argv[1]) ValueError: can't parse specfile
``` """
See the full comment at https://github.com/SSSD/sssd/pull/47#issuecomment-253799442
URL: https://github.com/SSSD/sssd/pull/47 Author: jhrozek Title: #47: BUILD: Fix build without /sbin/service installed on the build host Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/47/head:pr47 git checkout pr47
URL: https://github.com/SSSD/sssd/pull/47 Title: #47: BUILD: Fix build without /sbin/service installed on the build host
jhrozek commented: """ let's try again.. """
See the full comment at https://github.com/SSSD/sssd/pull/47#issuecomment-253802252
URL: https://github.com/SSSD/sssd/pull/47 Title: #47: BUILD: Fix build without /sbin/service installed on the build host
lslebodn commented: """ On (14/10/16 06:42), Jakub Hrozek wrote:
let's try again..
Finally, ACK :-)
http://sssd-ci.duckdns.org/logs/job/55/09/summary.html
And I would appreciate better review in future. We needn't have 4 one-linres for two patches.
LS
"""
See the full comment at https://github.com/SSSD/sssd/pull/47#issuecomment-253848586
URL: https://github.com/SSSD/sssd/pull/47 Title: #47: BUILD: Fix build without /sbin/service installed on the build host
lslebodn commented: """ master: * a2485c56319041f0021a46d63aac38ec2a5a6b2e * 0d52311adc48ecbe45e84c42332dece12c6d34fe * a3cf63eab87fc34bd871c7bab0676c3a06558011 * b7b92bafe759854ad05038f1d48a69e358a7ccbf
LS
"""
See the full comment at https://github.com/SSSD/sssd/pull/47#issuecomment-253849322
URL: https://github.com/SSSD/sssd/pull/47 Title: #47: BUILD: Fix build without /sbin/service installed on the build host
Label: +Pushed
URL: https://github.com/SSSD/sssd/pull/47 Author: jhrozek Title: #47: BUILD: Fix build without /sbin/service installed on the build host Action: closed
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/47/head:pr47 git checkout pr47
sssd-devel@lists.fedorahosted.org
-
fidencio