We only read the configured SIGKILL time for services and actually used the value of 0, which actually translated into tevent_schedule_immediate. That meant that after we sent the SIGTERM we also sent a SIGKILL right away, which is bad...
On 10/24/2012 10:18 PM, Jakub Hrozek wrote:
We only read the configured SIGKILL time for services and actually used the value of 0, which actually translated into tevent_schedule_immediate. That meant that after we sent the SIGTERM we also sent a SIGKILL right away, which is bad...
Nack,
I think that the debug message on line monitor.c:897 should be "Failed to get ping timeout for %s\n".
In the patch you allow kill_timeout = 0. In the original version it is replaced with default value. Is this desired behaviour?
On Fri, Oct 26, 2012 at 02:06:33PM +0200, Pavel Březina wrote:
On 10/24/2012 10:18 PM, Jakub Hrozek wrote:
We only read the configured SIGKILL time for services and actually used the value of 0, which actually translated into tevent_schedule_immediate. That meant that after we sent the SIGTERM we also sent a SIGKILL right away, which is bad...
Nack,
I think that the debug message on line monitor.c:897 should be "Failed to get ping timeout for %s\n".
In the patch you allow kill_timeout = 0. In the original version it is replaced with default value. Is this desired behaviour?
You are absolutely right, thank you. A new patch is attached.
On 10/29/2012 05:02 PM, Jakub Hrozek wrote:
On Fri, Oct 26, 2012 at 02:06:33PM +0200, Pavel Březina wrote:
On 10/24/2012 10:18 PM, Jakub Hrozek wrote:
We only read the configured SIGKILL time for services and actually used the value of 0, which actually translated into tevent_schedule_immediate. That meant that after we sent the SIGTERM we also sent a SIGKILL right away, which is bad...
Nack,
I think that the debug message on line monitor.c:897 should be "Failed to get ping timeout for %s\n".
In the patch you allow kill_timeout = 0. In the original version it is replaced with default value. Is this desired behaviour?
You are absolutely right, thank you. A new patch is attached.
Ack.
On Thu, Nov 01, 2012 at 11:49:19AM +0100, Pavel Březina wrote:
On 10/29/2012 05:02 PM, Jakub Hrozek wrote:
On Fri, Oct 26, 2012 at 02:06:33PM +0200, Pavel Březina wrote:
On 10/24/2012 10:18 PM, Jakub Hrozek wrote:
We only read the configured SIGKILL time for services and actually used the value of 0, which actually translated into tevent_schedule_immediate. That meant that after we sent the SIGTERM we also sent a SIGKILL right away, which is bad...
Nack,
I think that the debug message on line monitor.c:897 should be "Failed to get ping timeout for %s\n".
In the patch you allow kill_timeout = 0. In the original version it is replaced with default value. Is this desired behaviour?
You are absolutely right, thank you. A new patch is attached.
Ack.
Pushed to master and sssd-1-9
sssd-devel@lists.fedorahosted.org
-
Jakub Hrozek -
Pavel Březina