On Fri, Jun 3, 2016 at 3:38 PM, Jakub Hrozek <jhrozek(a)redhat.com> wrote:
On Fri, Jun 03, 2016 at 02:38:01PM +0200, Fabiano Fidêncio wrote:
> On Fri, Jun 3, 2016 at 2:32 PM, Lukas Slebodnik <lslebodn(a)redhat.com> wrote:
> > On (03/06/16 09:38), Sumit Bose wrote:
> >>On Fri, Jun 03, 2016 at 08:22:10AM +0200, Petr Cech wrote:
> >>> bump
> >>obvious ACK, just waiting for the CI to finish.
> > It might be a good idea to enable some compiler warning to catch such
> > issues.
> Using manywarnings.m4 is something desirable, I guess.
Did you try compiling sssd with these additional warnigns? I wonder how
many turn up and if there would be too many false positives to fix..
I didn't. But I'll put it in my (not-so-short-term) TODO list..
IMO we can get rid of setting the warnings manually and start taking
advantage of the warnings.m4 and manywarnings.m4 gnulib's files.
About the possible false positives, we can have a list of "dontwarn"
warnings, just excluding the non-interesting/false positive warnings,
as we do in spice-gtk/libosinfo.
Of course, this idea shouldn't block this patch, it's just an idea for
the future :-)