BUILD: ad_gpo_tests should be built only with samba

[Lukas Slebodnik]

ehlo,

ad_gpo_test is linked with library NDR_NBT, which is part of samba4.
Simple patch is attached.

LS

BTW I saw in Noam's nfs patches he is using $(NULL) after the end of lists in
Makefile.am. I saw it also in other projects. Do we want to use this patter as
well?

[Jakub Hrozek]

On Tue, Jul 01, 2014 at 12:23:45PM +0200, Lukas Slebodnik wrote:
> ehlo,
>
> ad_gpo_test is linked with library NDR_NBT, which is part of samba4.
> Simple patch is attached.

I didn't test a system without samba-libs, but I tested that when sssd
was configured --without-samba, the GPO tests were not built at all. I
think that still constitutes an ACK.
> LS
>
> BTW I saw in Noam's nfs patches he is using $(NULL) after the end of lists in
> Makefile.am. I saw it also in other projects. Do we want to use this patter as
> well?

I liked it as well, the additions at the end of the list can then be
truly one-liners.

[Sumit Bose]

On Tue, Jul 01, 2014 at 12:23:45PM +0200, Lukas Slebodnik wrote:
> ehlo,
>
> ad_gpo_test is linked with library NDR_NBT, which is part of samba4.
> Simple patch is attached.

ACK. Sorry I really forgot about checking Makefiles and spec-files when
doing the review.
> LS
>
> BTW I saw in Noam's nfs patches he is using $(NULL) after the end of lists in
> Makefile.am. I saw it also in other projects. Do we want to use this patter as
> well?

FreeIPA is using this as well. I find it useful but do not have a strong
opinion one way or the other.

bye,
Sumit

[Lukas Slebodnik]

On (01/07/14 13:33), Sumit Bose wrote:
> On Tue, Jul 01, 2014 at 12:23:45PM +0200, Lukas Slebodnik wrote:
> > ehlo,
> >
> > ad_gpo_test is linked with library NDR_NBT, which is part of samba4.
> > Simple patch is attached.
>
> ACK. Sorry I really forgot about checking Makefiles and spec-files when
> doing the review.

I was testing patches as well, but I didn't noticed all small problems.
> > LS
> >
> > BTW I saw in Noam's nfs patches he is using $(NULL) after the end of lists in
> > Makefile.am. I saw it also in other projects. Do we want to use this patter as
> > well?
>
> FreeIPA is using this as well. I find it useful but do not have a strong
> opinion one way or the other.

There are two positive responses. I will wait little bit more and if there
aren't any other objections. I will send new path.

LS

[Jakub Hrozek]

On Tue, Jul 01, 2014 at 01:41:29PM +0200, Lukas Slebodnik wrote:
> On (01/07/14 13:33), Sumit Bose wrote:
> > On Tue, Jul 01, 2014 at 12:23:45PM +0200, Lukas Slebodnik wrote:
> > > ehlo,
> > >
> > > ad_gpo_test is linked with library NDR_NBT, which is part of samba4.
> > > Simple patch is attached.
> >
> > ACK. Sorry I really forgot about checking Makefiles and spec-files when
> > doing the review.
>
> I was testing patches as well, but I didn't noticed all small problems.
> > > LS
> > >
> > > BTW I saw in Noam's nfs patches he is using $(NULL) after the end of lists in
> > > Makefile.am. I saw it also in other projects. Do we want to use this patter as
> > > well?
> >
> > FreeIPA is using this as well. I find it useful but do not have a strong
> > opinion one way or the other.
>
> There are two positive responses. I will wait little bit more and if there
> aren't any other objections. I will send new path.

Sorry, too late:
99f8be128274eba264ea1434a7eb2800bced5902

I thought you were asking in general or for future patches, not for this
one...

[Lukas Slebodnik]

On (01/07/14 13:44), Jakub Hrozek wrote:
> On Tue, Jul 01, 2014 at 01:41:29PM +0200, Lukas Slebodnik wrote:
> > On (01/07/14 13:33), Sumit Bose wrote:
> > > On Tue, Jul 01, 2014 at 12:23:45PM +0200, Lukas Slebodnik wrote:
> > > > ehlo,
> > > >
> > > > ad_gpo_test is linked with library NDR_NBT, which is part of samba4.
> > > > Simple patch is attached.
> > >
> > > ACK. Sorry I really forgot about checking Makefiles and spec-files when
> > > doing the review.
> >
> > I was testing patches as well, but I didn't noticed all small problems.
> > > > LS
> > > >
> > > > BTW I saw in Noam's nfs patches he is using $(NULL) after the end of lists in
> > > > Makefile.am. I saw it also in other projects. Do we want to use this patter as
> > > > well?
> > >
> > > FreeIPA is using this as well. I find it useful but do not have a strong
> > > opinion one way or the other.
> >
> > There are two positive responses. I will wait little bit more and if there
> > aren't any other objections. I will send new path.
>
> Sorry, too late:
> 99f8be128274eba264ea1434a7eb2800bced5902
>
> I thought you were asking in general or for future patches, not for this
> one...

No problem :-)
In future, we can use "$(NULL)" at the end of automate list.

LS