Re: [SSSD] [PATCH] Suppress warning maybe-uninitialized

[Lukas Slebodnik]

On (08/10/14 00:16), Simo Sorce wrote:
> On Tue, 7 Oct 2014 23:57:34 +0200
> Lukas Slebodnik  wrote:
> >            name = map[a].sys_name;
> >            name = map[i].sys_name;
> >            base_attr_idx = 1;
>
> this should be base_attr_idx = i; I think.

/me facepalms

fixed version attached.

LS

[PATCH] Suppress warning maybe-uninitialized

[Simo Sorce]

On Wed, 8 Oct 2014 09:12:53 +0200
Lukas Slebodnik  wrote:
>                    for (ai = a; ai < attrs_num; ai++) {
>                    for (ai = base_attr_idx; ai < attrs_num;
>
> ai++) { /* check if this attr is valid with the chosen
>                               * schema */

I still think adding ai > 0 to the condition would better reflect the
existing code behavior, but I won't insist if nobody else cares.

Otherwise Ack.

Simo.

[PATCH] Suppress warning maybe-uninitialized

[Jakub Hrozek]

On Thu, Oct 09, 2014 at 10:33:54AM -0400, Simo Sorce wrote:
> On Wed, 8 Oct 2014 09:12:53 +0200
> Lukas Slebodnik  wrote:
> >                    for (ai = a; ai < attrs_num; ai++) {
> >                    for (ai = base_attr_idx; ai < attrs_num;
> >
> > ai++) { /* check if this attr is valid with the chosen
> >                               * schema */
>
> I still think adding ai > 0 to the condition would better reflect the
> existing code behavior, but I won't insist if nobody else cares.
>
> Otherwise Ack.
>
> Simo.

* master: d66d15bf97bfaf4b851e96717caeeef8581d5777