[sssd PR#5537][opened] negcache: use right domain in nss_protocol_fill_initgr()

[sumit-bose]

URL: https://github.com/SSSD/sssd/pull/5537
Author: sumit-bose
 Title: #5537: negcache: use right domain in nss_protocol_fill_initgr()
Action: opened

PR body:
"""
When checking if a group returned by an initgroups request is filtered
in the negative cache the domain of the user was used. This does not
work reliable if the user can be a member of groups from multiple
domains.

With this patch th domain the group belongs to is determined and used
while checking the negative cache.

Resolves: https://github.com/SSSD/sssd/issues/5534
"""

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5537/head:pr5537
git checkout pr5537

[sssd PR#5537][+Changes requested] negcache: use right domain in nss_protocol_fill_initgr()

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/5537
Title: #5537: negcache: use right domain in nss_protocol_fill_initgr()

Label: +Changes requested

[sssd PR#5537][synchronized] negcache: use right domain in nss_protocol_fill_initgr()

[sumit-bose]

URL: https://github.com/SSSD/sssd/pull/5537
Author: sumit-bose
 Title: #5537: negcache: use right domain in nss_protocol_fill_initgr()
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5537/head:pr5537
git checkout pr5537

[sssd PR#5537][comment] negcache: use right domain in nss_protocol_fill_initgr()

[sumit-bose]

URL: https://github.com/SSSD/sssd/pull/5537
Title: #5537: negcache: use right domain in nss_protocol_fill_initgr()

sumit-bose commented:
"""
Hi,

thanks for the review. I tired to use a single return but I agree that with your suggestions to code is more readable. New version contains the fixes.

bye,
Sumit
"""

See the full comment at https://github.com/SSSD/sssd/pull/5537#issuecomment-809496754

[sssd PR#5537][-Changes requested] negcache: use right domain in nss_protocol_fill_initgr()

[sumit-bose]

URL: https://github.com/SSSD/sssd/pull/5537
Title: #5537: negcache: use right domain in nss_protocol_fill_initgr()

Label: -Changes requested

[sssd PR#5537][+Waiting for review] negcache: use right domain in nss_protocol_fill_initgr()

[sumit-bose]

URL: https://github.com/SSSD/sssd/pull/5537
Title: #5537: negcache: use right domain in nss_protocol_fill_initgr()

Label: +Waiting for review

[sssd PR#5537][comment] negcache: use right domain in nss_protocol_fill_initgr()

[alexey-tikhonov]

URL: https://github.com/SSSD/sssd/pull/5537
Title: #5537: negcache: use right domain in nss_protocol_fill_initgr()

alexey-tikhonov commented:
"""
Shall this target 1-16 as well? (https://bugzilla.redhat.com/show_bug.cgi?id=1945552)
"""

See the full comment at https://github.com/SSSD/sssd/pull/5537#issuecomment-811785975

[sssd PR#5537][comment] negcache: use right domain in nss_protocol_fill_initgr()

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/5537
Title: #5537: negcache: use right domain in nss_protocol_fill_initgr()

pbrezina commented:
"""
Ack to the code but there is conflict. Can you please rebase it?
"""

See the full comment at https://github.com/SSSD/sssd/pull/5537#issuecomment-811823186

[sssd PR#5537][synchronized] negcache: use right domain in nss_protocol_fill_initgr()

[sumit-bose]

URL: https://github.com/SSSD/sssd/pull/5537
Author: sumit-bose
 Title: #5537: negcache: use right domain in nss_protocol_fill_initgr()
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5537/head:pr5537
git checkout pr5537

[sssd PR#5537][comment] negcache: use right domain in nss_protocol_fill_initgr()

[sumit-bose]

URL: https://github.com/SSSD/sssd/pull/5537
Title: #5537: negcache: use right domain in nss_protocol_fill_initgr()

sumit-bose commented:
"""
> Shall this target 1-16 as well? (https://bugzilla.redhat.com/show_bug.cgi?id=1945552)

yes
"""

See the full comment at https://github.com/SSSD/sssd/pull/5537#issuecomment-813945305

[sssd PR#5537][comment] negcache: use right domain in nss_protocol_fill_initgr()

[sumit-bose]

URL: https://github.com/SSSD/sssd/pull/5537
Title: #5537: negcache: use right domain in nss_protocol_fill_initgr()

sumit-bose commented:
"""
> Ack to the code but there is conflict. Can you please rebase it?

done
"""

See the full comment at https://github.com/SSSD/sssd/pull/5537#issuecomment-813945541

[sssd PR#5537][+branch: sssd-1-16] negcache: use right domain in nss_protocol_fill_initgr()

[alexey-tikhonov]

URL: https://github.com/SSSD/sssd/pull/5537
Title: #5537: negcache: use right domain in nss_protocol_fill_initgr()

Label: +branch: sssd-1-16

[sssd PR#5537][+Bugzilla] negcache: use right domain in nss_protocol_fill_initgr()

[alexey-tikhonov]

URL: https://github.com/SSSD/sssd/pull/5537
Title: #5537: negcache: use right domain in nss_protocol_fill_initgr()

Label: +Bugzilla

[sssd PR#5537][comment] negcache: use right domain in nss_protocol_fill_initgr()

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/5537
Title: #5537: negcache: use right domain in nss_protocol_fill_initgr()

pbrezina commented:
"""
Thank you. Ack.
"""

See the full comment at https://github.com/SSSD/sssd/pull/5537#issuecomment-818669134

[sssd PR#5537][-Waiting for review] negcache: use right domain in nss_protocol_fill_initgr()

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/5537
Title: #5537: negcache: use right domain in nss_protocol_fill_initgr()

Label: -Waiting for review

[sssd PR#5537][+Accepted] negcache: use right domain in nss_protocol_fill_initgr()

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/5537
Title: #5537: negcache: use right domain in nss_protocol_fill_initgr()

Label: +Accepted

[sssd PR#5537][+Ready to push] negcache: use right domain in nss_protocol_fill_initgr()

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/5537
Title: #5537: negcache: use right domain in nss_protocol_fill_initgr()

Label: +Ready to push

[sssd PR#5537][-Ready to push] negcache: use right domain in nss_protocol_fill_initgr()

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/5537
Title: #5537: negcache: use right domain in nss_protocol_fill_initgr()

Label: -Ready to push

[sssd PR#5537][-branch: sssd-1-16] negcache: use right domain in nss_protocol_fill_initgr()

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/5537
Title: #5537: negcache: use right domain in nss_protocol_fill_initgr()

Label: -branch: sssd-1-16

[sssd PR#5537][comment] negcache: use right domain in nss_protocol_fill_initgr()

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/5537
Title: #5537: negcache: use right domain in nss_protocol_fill_initgr()

pbrezina commented:
"""
1.16 did not apply, please open separate PR
"""

See the full comment at https://github.com/SSSD/sssd/pull/5537#issuecomment-818673129

[sssd PR#5537][+Ready to push] negcache: use right domain in nss_protocol_fill_initgr()

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/5537
Title: #5537: negcache: use right domain in nss_protocol_fill_initgr()

Label: +Ready to push

[sssd PR#5537][comment] negcache: use right domain in nss_protocol_fill_initgr()

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/5537
Title: #5537: negcache: use right domain in nss_protocol_fill_initgr()

pbrezina commented:
"""
Pushed PR: https://github.com/SSSD/sssd/pull/5537

* `master`
    * 231d1118727b989a4af9911a45a465912fe659d6 - negcache: use right domain in nss_protocol_fill_initgr()

"""

See the full comment at https://github.com/SSSD/sssd/pull/5537#issuecomment-818673390

[sssd PR#5537][+Pushed] negcache: use right domain in nss_protocol_fill_initgr()

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/5537
Title: #5537: negcache: use right domain in nss_protocol_fill_initgr()

Label: +Pushed

[sssd PR#5537][-Accepted] negcache: use right domain in nss_protocol_fill_initgr()

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/5537
Title: #5537: negcache: use right domain in nss_protocol_fill_initgr()

Label: -Accepted

[sssd PR#5537][-Ready to push] negcache: use right domain in nss_protocol_fill_initgr()

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/5537
Title: #5537: negcache: use right domain in nss_protocol_fill_initgr()

Label: -Ready to push

[sssd PR#5537][closed] negcache: use right domain in nss_protocol_fill_initgr()

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/5537
Author: sumit-bose
 Title: #5537: negcache: use right domain in nss_protocol_fill_initgr()
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5537/head:pr5537
git checkout pr5537