[PATCH] An idea for a default commit message

[Simo Sorce]

This is just an idea, but if people like it and agree with the format it
would be nice to have it in tree.

Simo.

[Stephen Gallagher]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 08/05/2013 02:11 PM, Simo Sorce wrote:
> This is just an idea, but if people like it and agree with the
> format it would be nice to have it in tree.

I like it. Ack from me.
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.13 (GNU/Linux)
> Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
>
> iEYEARECAAYFAlH/7DgACgkQeiVVYja6o6OJ+ACfS7hdmsi1zCVLJ2A6+byisDmC
> 7yQAn2ghwJq0tZH094Zan9guR0lpTuf0
> =jlrT
> -----END PGP SIGNATURE-----

[Jakub Hrozek]

On Mon, Aug 05, 2013 at 02:17:28PM -0400, Stephen Gallagher wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On 08/05/2013 02:11 PM, Simo Sorce wrote:
> > This is just an idea, but if people like it and agree with the
> > format it would be nice to have it in tree.
>
> I like it. Ack from me.

Ack++

There is a lot of commits that don't need any ticket references but a
template makes it easier to follow the best practices.

[Jakub Hrozek]

On Mon, Aug 05, 2013 at 11:44:42PM +0200, Jakub Hrozek wrote:
> On Mon, Aug 05, 2013 at 02:17:28PM -0400, Stephen Gallagher wrote:
> > -----BEGIN PGP SIGNED MESSAGE-----
> > Hash: SHA1
> >
> > On 08/05/2013 02:11 PM, Simo Sorce wrote:
> > > This is just an idea, but if people like it and agree with the
> > > format it would be nice to have it in tree.
> >
> > I like it. Ack from me.
>
> Ack++
>
> There is a lot of commits that don't need any ticket references but a
> template makes it easier to follow the best practices.

Pushed to master.

[Jakub Hrozek]

On Tue, Aug 06, 2013 at 09:41:56PM +0200, Jakub Hrozek wrote:
> On Mon, Aug 05, 2013 at 11:44:42PM +0200, Jakub Hrozek wrote:
> > On Mon, Aug 05, 2013 at 02:17:28PM -0400, Stephen Gallagher wrote:
> > > -----BEGIN PGP SIGNED MESSAGE-----
> > > Hash: SHA1
> > >
> > > On 08/05/2013 02:11 PM, Simo Sorce wrote:
> > > > This is just an idea, but if people like it and agree with the
> > > > format it would be nice to have it in tree.
> > >
> > > I like it. Ack from me.
> >
> > Ack++
> >
> > There is a lot of commits that don't need any ticket references but a
> > template makes it easier to follow the best practices.
>
> Pushed to master.

I think we should push the patch to sssd-1-10 and sssd-1-9 as well to
avoid errors like (on sssd-1-9 where I've been doing quite a lot of
backports lately)

$ git commit -a
fatal: could not read '.git-commit-template': No such file or directory

[Pavel Březina]

----- Jakub Hrozek  wrote:
> On Tue, Aug 06, 2013 at 09:41:56PM +0200, Jakub Hrozek wrote:
> > On Mon, Aug 05, 2013 at 11:44:42PM +0200, Jakub Hrozek wrote:
> > > On Mon, Aug 05, 2013 at 02:17:28PM -0400, Stephen Gallagher wrote:
> > > > -----BEGIN PGP SIGNED MESSAGE-----
> > > > Hash: SHA1
> > > >
> > > > On 08/05/2013 02:11 PM, Simo Sorce wrote:
> > > > > This is just an idea, but if people like it and agree with the
> > > > > format it would be nice to have it in tree.
> > > >
> > > > I like it. Ack from me.
> > >
> > > Ack++
> > >
> > > There is a lot of commits that don't need any ticket references but a
> > > template makes it easier to follow the best practices.
> >
> > Pushed to master.
>
> I think we should push the patch to sssd-1-10 and sssd-1-9 as well to
> avoid errors like (on sssd-1-9 where I've been doing quite a lot of
> backports lately)
>
> $ git commit -a
> fatal: could not read '.git-commit-template': No such file or directory

This certainly won't break anything, so yes, do it.

[Jakub Hrozek]

On Fri, Aug 09, 2013 at 07:26:47AM -0400, Pavel Brezina wrote:
> ----- Jakub Hrozek  wrote:
> > On Tue, Aug 06, 2013 at 09:41:56PM +0200, Jakub Hrozek wrote:
> > > On Mon, Aug 05, 2013 at 11:44:42PM +0200, Jakub Hrozek wrote:
> > > > On Mon, Aug 05, 2013 at 02:17:28PM -0400, Stephen Gallagher wrote:
> > > > > -----BEGIN PGP SIGNED MESSAGE-----
> > > > > Hash: SHA1
> > > > >
> > > > > On 08/05/2013 02:11 PM, Simo Sorce wrote:
> > > > > > This is just an idea, but if people like it and agree with the
> > > > > > format it would be nice to have it in tree.
> > > > >
> > > > > I like it. Ack from me.
> > > >
> > > > Ack++
> > > >
> > > > There is a lot of commits that don't need any ticket references but a
> > > > template makes it easier to follow the best practices.
> > >
> > > Pushed to master.
> >
> > I think we should push the patch to sssd-1-10 and sssd-1-9 as well to
> > avoid errors like (on sssd-1-9 where I've been doing quite a lot of
> > backports lately)
> >
> > $ git commit -a
> > fatal: could not read '.git-commit-template': No such file or directory
>
> This certainly won't break anything, so yes, do it.

Thanks, also pushed to sssd-1-10 and sssd-1-9