[PATCH] Do not set HAVE_SYSTEMD_LOGIN if libsystemd-login is not available

[Sumit Bose]

Hi,

I found this on a system where systemd-devel was not installed. Since we
already know that systemd is available at this stage of the configure
run I wonder if AC_MSG_NOTICE is ok or if AC_MSG_ERROR asking to install
systemd-devel would be better?

bye,
Sumit

[Jakub Hrozek]

On Tue, Sep 17, 2013 at 01:00:07PM +0200, Sumit Bose wrote:
> Hi,
>
> I found this on a system where systemd-devel was not installed. Since we
> already know that systemd is available at this stage of the configure
> run I wonder if AC_MSG_NOTICE is ok or if AC_MSG_ERROR asking to install
> systemd-devel would be better?
>
> bye,
> Sumit
> From fd2e8098aa53603172a6070ea423cecc7b4230c5 Mon Sep 17 00:00:00 2001
> From: Sumit Bose 
> Date: Tue, 17 Sep 2013 12:31:45 +0200
> Subject: [PATCH] Do not set HAVE_SYSTEMD_LOGIN if libsystemd-login is not
>  available
>
> Even if HAVE_SYSTEMD_LOGIN is set to 0 #ifdef will still see it as
> defined.
>
> src/external/systemd.m4 |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/src/external/systemd.m4 b/src/external/systemd.m4
> index 202915a..9afb65d 100644
> --- a/src/external/systemd.m4
> +++ b/src/external/systemd.m4
> @@ -9,4 +9,4 @@ AC_DEFUN([AM_CHECK_SYSTEMD],
>  AM_COND_IF([HAVE_SYSTEMD],
>             [PKG_CHECK_MODULES([SYSTEMD_LOGIN], [libsystemd-login],
>              [AC_DEFINE_UNQUOTED(HAVE_SYSTEMD_LOGIN, 1, [Build with libsystemdlogin support])],
>        [AC_DEFINE_UNQUOTED(HAVE_SYSTEMD_LOGIN, 0, [Build without libsystemd-login support])])])
>        [AC_MSG_NOTICE([Build without libsystemd-login support])])])
>
> -- 
> 1.7.7.6

Thank you, Pavel pinged me about the same issue just a while ago. I
think that notice is fine because we still support systems without
systemd with master.

But currently there is no way to enable/disable the support without
having the right library installed. Do you think there would be value in
a switch like this or the autodetection is OK?

ACK to this patch, we can decide about the option later.

[Pavel Březina]

On 09/17/2013 01:26 PM, Jakub Hrozek wrote:
> On Tue, Sep 17, 2013 at 01:00:07PM +0200, Sumit Bose wrote:
> > Hi,
> >
> > I found this on a system where systemd-devel was not installed. Since we
> > already know that systemd is available at this stage of the configure
> > run I wonder if AC_MSG_NOTICE is ok or if AC_MSG_ERROR asking to install
> > systemd-devel would be better?
> >
> > bye,
> > Sumit
> > From fd2e8098aa53603172a6070ea423cecc7b4230c5 Mon Sep 17 00:00:00 2001
> > From: Sumit Bose 
> > Date: Tue, 17 Sep 2013 12:31:45 +0200
> > Subject: [PATCH] Do not set HAVE_SYSTEMD_LOGIN if libsystemd-login is not
> >   available
> >
> > Even if HAVE_SYSTEMD_LOGIN is set to 0 #ifdef will still see it as
> > defined.
> >
> > src/external/systemd.m4 |    2 +-
> >   1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/src/external/systemd.m4 b/src/external/systemd.m4
> > index 202915a..9afb65d 100644
> > --- a/src/external/systemd.m4
> > +++ b/src/external/systemd.m4
> > @@ -9,4 +9,4 @@ AC_DEFUN([AM_CHECK_SYSTEMD],
> >   AM_COND_IF([HAVE_SYSTEMD],
> >              [PKG_CHECK_MODULES([SYSTEMD_LOGIN], [libsystemd-login],
> >               [AC_DEFINE_UNQUOTED(HAVE_SYSTEMD_LOGIN, 1, [Build with libsystemdlogin support])],
> >        [AC_DEFINE_UNQUOTED(HAVE_SYSTEMD_LOGIN, 0, [Build without libsystemd-login support])])])
> >        [AC_MSG_NOTICE([Build without libsystemd-login support])])])
> >
> > --
> > 1.7.7.6
>
> Thank you, Pavel pinged me about the same issue just a while ago. I
> think that notice is fine because we still support systems without
> systemd with master.

Yeah, I stepped into this just before lunch :)
> But currently there is no way to enable/disable the support without
> having the right library installed. Do you think there would be value in
> a switch like this or the autodetection is OK?

I don't see a point to disable it on systemd distros. Autodetection is 
OK IMHO.
> ACK to this patch, we can decide about the option later.

Ack from me as well.

[Jakub Hrozek]

On Tue, Sep 17, 2013 at 03:23:48PM +0200, Pavel Březina wrote:
> > But currently there is no way to enable/disable the support without
> > having the right library installed. Do you think there would be value in
> > a switch like this or the autodetection is OK?
>
> I don't see a point to disable it on systemd distros. Autodetection
> is OK IMHO.

I was more worried about distributions where they'd want the logind
support but want the configure script to check if it's available and
abort if not. We solved that on the specfile level, so we're fine..

But for now I think autodetection is OK.

[Jakub Hrozek]

On Tue, Sep 17, 2013 at 03:23:48PM +0200, Pavel Březina wrote:
> > ACK to this patch, we can decide about the option later.
>
> Ack from me as well.

Pushed to master.