[PATCHES] Build fixes and improvements

[Nikolai Kondrashov]

Hi everyone,

Here is a bunch of various build fixes and improvements mainly concerned with
libini_config detection.

Nick

[Jakub Hrozek]

On Mon, Jul 28, 2014 at 08:45:41PM +0300, Nikolai Kondrashov wrote:
> Hi everyone,
>
> Here is a bunch of various build fixes and improvements mainly concerned with
> libini_config detection.
>
> Nick
> From d1bd23332bb504b3780fb4ba6ad1a92e4d2ab3f5 Mon Sep 17 00:00:00 2001
> From: Nikolai Kondrashov 
> Date: Mon, 28 Jul 2014 17:02:10 +0300
> Subject: [PATCH 1/6] build: Remove substitution of *_OBJ variables
>
> Remove substitution of *_OBJ variables (e.g. POPT_OBJ or PCRE_OBJ) from
> configure scripts as they don't seem to be set or used by anything.

ACK, they are truly unused.
> From 0050f897f4c33fc277f22831dddf40bc820ea499 Mon Sep 17 00:00:00 2001
> From: Nikolai Kondrashov 
> Date: Fri, 25 Jul 2014 16:01:02 +0300
> Subject: [PATCH 2/6] build: Mention required libini_config version
>
> Specify minimum required libini_config version in a message in samba.m4
> explaining the need for the library.

ACK
> From b65fc04e19a8ed212485e2e812579ddfaa261085 Mon Sep 17 00:00:00 2001
> From: Nikolai Kondrashov 
> Date: Mon, 28 Jul 2014 12:57:32 +0300
> Subject: [PATCH 3/6] build: Distinguish libini_config version checks

ACK, nice catch
> From c221453a5acde8a75cbd51a07d9f823751454be9 Mon Sep 17 00:00:00 2001
> From: Nikolai Kondrashov 
> Date: Fri, 25 Jul 2014 16:41:42 +0300
> Subject: [PATCH 4/6] build: Distinguish libnl version checks

ACK
> From 964e6a076397bc554efb0a86fa69e8899a23bcaf Mon Sep 17 00:00:00 2001
> From: Nikolai Kondrashov 
> Date: Mon, 28 Jul 2014 15:11:20 +0300
> Subject: [PATCH 5/6] build: Reverse order of libini_config checks

ACK
> From d597c5d7c6d1e312a8d1adac95f336deb0b1b135 Mon Sep 17 00:00:00 2001
> From: Nikolai Kondrashov 
> Date: Mon, 28 Jul 2014 15:21:21 +0300
> Subject: [PATCH 6/6] build: Move libini_config 1.1.0 check to libini_config.m4

ACK, we just need to keep in mind that checking for libini must happen
before checking for Samba in the build system. But I guess a failed
build would tell us exactly :)

I tested the patches on Fedora-20 and RHEL-6 (latest and oldest OS
releases we support). With libini 1.1 everything went fine, with stocke
RHEL-6.5 libini the build failed during configure phase.

[Nikolai Kondrashov]

On 07/29/2014 05:42 PM, Jakub Hrozek wrote:
> > From d597c5d7c6d1e312a8d1adac95f336deb0b1b135 Mon Sep 17 00:00:00 2001
> > From: Nikolai Kondrashov 
> > Date: Mon, 28 Jul 2014 15:21:21 +0300
> > Subject: [PATCH 6/6] build: Move libini_config 1.1.0 check to libini_config.m4
>
> ACK, we just need to keep in mind that checking for libini must happen
> before checking for Samba in the build system. But I guess a failed
> build would tell us exactly :)

Yes, that's a drawback, but keeping all the checks in one place seems to still
be better to me so far.
> I tested the patches on Fedora-20 and RHEL-6 (latest and oldest OS
> releases we support). With libini 1.1 everything went fine, with stocke
> RHEL-6.5 libini the build failed during configure phase.

I noticed the same problem on RHEL7, but it should be fixed by patch #3.

Thanks for the review, Jakub!

Sincerely,
Nick

[Jakub Hrozek]

On Tue, Jul 29, 2014 at 04:42:35PM +0200, Jakub Hrozek wrote:
> On Mon, Jul 28, 2014 at 08:45:41PM +0300, Nikolai Kondrashov wrote:
> > Hi everyone,
> >
> > Here is a bunch of various build fixes and improvements mainly concerned with
> > libini_config detection.
> >
> > Nick
> > From d1bd23332bb504b3780fb4ba6ad1a92e4d2ab3f5 Mon Sep 17 00:00:00 2001
> > From: Nikolai Kondrashov 
> > Date: Mon, 28 Jul 2014 17:02:10 +0300
> > Subject: [PATCH 1/6] build: Remove substitution of *_OBJ variables
> >
> > Remove substitution of *_OBJ variables (e.g. POPT_OBJ or PCRE_OBJ) from
> > configure scripts as they don't seem to be set or used by anything.
>
> ACK, they are truly unused.
> > From 0050f897f4c33fc277f22831dddf40bc820ea499 Mon Sep 17 00:00:00 2001
> > From: Nikolai Kondrashov 
> > Date: Fri, 25 Jul 2014 16:01:02 +0300
> > Subject: [PATCH 2/6] build: Mention required libini_config version
> >
> > Specify minimum required libini_config version in a message in samba.m4
> > explaining the need for the library.
>
> ACK
> > From b65fc04e19a8ed212485e2e812579ddfaa261085 Mon Sep 17 00:00:00 2001
> > From: Nikolai Kondrashov 
> > Date: Mon, 28 Jul 2014 12:57:32 +0300
> > Subject: [PATCH 3/6] build: Distinguish libini_config version checks
>
> ACK, nice catch
> > From c221453a5acde8a75cbd51a07d9f823751454be9 Mon Sep 17 00:00:00 2001
> > From: Nikolai Kondrashov 
> > Date: Fri, 25 Jul 2014 16:41:42 +0300
> > Subject: [PATCH 4/6] build: Distinguish libnl version checks
>
> ACK
> > From 964e6a076397bc554efb0a86fa69e8899a23bcaf Mon Sep 17 00:00:00 2001
> > From: Nikolai Kondrashov 
> > Date: Mon, 28 Jul 2014 15:11:20 +0300
> > Subject: [PATCH 5/6] build: Reverse order of libini_config checks
>
> ACK
> > From d597c5d7c6d1e312a8d1adac95f336deb0b1b135 Mon Sep 17 00:00:00 2001
> > From: Nikolai Kondrashov 
> > Date: Mon, 28 Jul 2014 15:21:21 +0300
> > Subject: [PATCH 6/6] build: Move libini_config 1.1.0 check to libini_config.m4
>
> ACK, we just need to keep in mind that checking for libini must happen
> before checking for Samba in the build system. But I guess a failed
> build would tell us exactly :)
>
> I tested the patches on Fedora-20 and RHEL-6 (latest and oldest OS
> releases we support). With libini 1.1 everything went fine, with stocke
> RHEL-6.5 libini the build failed during configure phase.

Pushed all to master:
    7a719ffa79161694a354c8d18a28d33377d87db8
    a81e80c817808f4bb41d5219b04dbf73c943821e
    d9424a4d40f5f77e70c77d39f33ffed87370c21b
    93f295496dc6dc0838c09692b6a3a008b35d461b
    9cb4d19c40dcf14b270e39a503f7c5d0a92ab28f
    7b99fc9643001e22737c2c872c5d666218fc7ddc