[PATCH] Consolidation of functions that make realm upper-case

[Ondrej Kos]

https://fedorahosted.org/sssd/ticket/1491

I prepared function *get_uppercase_realm* accessible through 
src/util/util.h which returns uppercase realm string. If whole principal 
is passed, it transforms only the part after '@' character. Multiple 
uses of *toupper* have been replaced and modified to use mentioned new 
function.

Ondrej
-- 
Ondrej Kos
Associate Software Engineer
Identity Management
Red Hat Czech

cell:  [phone]
phone: [phone]
ext.:  82-62558
irc:   okos @ #brno

[Jakub Hrozek]

On Tue, Aug 21, 2012 at 04:11:19PM +0200, Ondrej Kos wrote:
>  https://fedorahosted.org/sssd/ticket/1491
>  
>  I prepared function *get_uppercase_realm* accessible through
>  src/util/util.h which returns uppercase realm string. If whole
>  principal is passed, it transforms only the part after '@'
>  character. Multiple uses of *toupper* have been replaced and
>  modified to use mentioned new function.
>  
>  Ondrej 
I nacked the patch off-list, test statements were left in and the code
violated style guidelines.

[Ondrej Kos]

Fixed

Function was modified to just return the given string as uppercase. The 
part where the whole principal is being processed was restored to it's 
previous state.

New patch is attached

Ondrej

On 08/21/2012 04:21 PM, Jakub Hrozek wrote:
>  On Tue, Aug 21, 2012 at 04:11:19PM +0200, Ondrej Kos wrote:
> > https://fedorahosted.org/sssd/ticket/1491
> >
> > I prepared function *get_uppercase_realm* accessible through
> > src/util/util.h which returns uppercase realm string. If whole
> > principal is passed, it transforms only the part after '@'
> > character. Multiple uses of *toupper* have been replaced and
> > modified to use mentioned new function.
> >
> > Ondrej
>
>  I nacked the patch off-list, test statements were left in and the code
>  violated style guidelines.
>  _______________________________________________
>  sssd-devel mailing list
>  sssd-devel(a)lists.fedorahosted.org
>  https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
>  

-- 
Ondrej Kos
Associate Software Engineer
Identity Management
Red Hat Czech

cell:  [phone]
phone: [phone]
ext.:  82-62558
irc:   okos @ #brno

[Jakub Hrozek]

On Tue, Aug 21, 2012 at 04:48:08PM +0200, Ondrej Kos wrote:
>  Fixed
>  
>  Function was modified to just return the given string as uppercase.
>  The part where the whole principal is being processed was restored
>  to it's previous state.
>  
>  New patch is attached
>  
>  Ondrej
>   
Fix the braces in this hunk:
>  +
>  +    realm = talloc_strdup(memctx, name);
>  +    if (!realm)
>  +    {
>  +        return NULL;
>  +    } 
and I'll ack :-)

See http://www.freeipa.org/page/Coding_Style#Conditions_and_Statements
for the full guidelines.

[Jakub Hrozek]

On Wed, Aug 22, 2012 at 03:18:05PM +0200, Jakub Hrozek wrote:
>  On Tue, Aug 21, 2012 at 04:48:08PM +0200, Ondrej Kos wrote:
>  > Fixed
>  > 
>  > Function was modified to just return the given string as uppercase.
>  > The part where the whole principal is being processed was restored
>  > to it's previous state.
>  > 
>  > New patch is attached
>  > 
>  > Ondrej
>  > 
>  
>  Fix the braces in this hunk:
>  > +
>  > +    realm = talloc_strdup(memctx, name);
>  > +    if (!realm)
>  > +    {
>  > +        return NULL;
>  > +    }
>  
>  and I'll ack :-)
>  
>  See http://www.freeipa.org/page/Coding_Style#Conditions_and_Statements
>  for the full guidelines. 
Also these two new warnings seems to be caused by the patch:
src/providers/ipa/ipa_common.c:50:9: warning: unused variable 'i'
[-Wunused-variable]
src/providers/ad/ad_common.c:36:12: warning: unused variable 'i'
[-Wunused-variable]

[Ondrej Kos]

hmm, those warnings didn't appear, flags probably got somehow mixed up.

fixed patch is attached

O.

On 08/22/2012 05:20 PM, Jakub Hrozek wrote:
>  On Wed, Aug 22, 2012 at 03:18:05PM +0200, Jakub Hrozek wrote:
> > On Tue, Aug 21, 2012 at 04:48:08PM +0200, Ondrej Kos wrote:
> >> Fixed
> >>
> >> Function was modified to just return the given string as uppercase.
> >> The part where the whole principal is being processed was restored
> >> to it's previous state.
> >>
> >> New patch is attached
> >>
> >> Ondrej
> >>
> >
> > Fix the braces in this hunk:
> >> +
> >> +    realm = talloc_strdup(memctx, name);
> >> +    if (!realm)
> >> +    {
> >> +        return NULL;
> >> +    }
> >
> > and I'll ack :-)
> >
> > See http://www.freeipa.org/page/Coding_Style#Conditions_and_Statements
> > for the full guidelines.
>
>  Also these two new warnings seems to be caused by the patch:
>  src/providers/ipa/ipa_common.c:50:9: warning: unused variable 'i'
>  [-Wunused-variable]
>  src/providers/ad/ad_common.c:36:12: warning: unused variable 'i'
>  [-Wunused-variable]
>  _______________________________________________
>  sssd-devel mailing list
>  sssd-devel(a)lists.fedorahosted.org
>  https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
>  

-- 
Ondrej Kos
Associate Software Engineer
Identity Management
Red Hat Czech

cell:  [phone]
phone: [phone]
ext.:  82-62558
irc:   okos @ #brno

[Jakub Hrozek]

On Thu, Aug 23, 2012 at 08:25:43AM +0200, Ondrej Kos wrote:
>  hmm, those warnings didn't appear, flags probably got somehow
> mixed up.
>  
>  fixed patch is attached
>  
>  O.
>   
Ack

[Jakub Hrozek]

On Thu, Aug 23, 2012 at 01:15:11PM +0200, Jakub Hrozek wrote:
>  On Thu, Aug 23, 2012 at 08:25:43AM +0200, Ondrej Kos wrote:
>  > hmm, those warnings didn't appear, flags probably got somehow mixed up.
>  > 
>  > fixed patch is attached
>  > 
>  > O.
>  > 
>  
>  Ack 
Pushed to master.