[PATCH] Process all groups from a single nesting level

[Jakub Hrozek]

https://bugzilla.redhat.com/show_bug.cgi?id=846664

If the first group was cached when processing the nested group membership,
we would call tevent_req_done, effectivelly marking the whole nesting
level as done. That is wrong, we should only move to next group in the
same nesting level.

Attached are two patches. One that applies on the 1.5 branch and another
one that can be applied on top of both 1.8 and master.

I haven't yet figured out why we're not seeing the bug on master even
though the buggy code is there. Probably this issue is being shadowed b
another bug in the ghost users..I'll investigate more.

For now, I'm sending the patches for review to unblock the branches that
are affected by the bug.

[Pavel Březina]

On 08/17/2012 12:25 AM, Jakub Hrozek wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=846664
>
> If the first group was cached when processing the nested group membership,
> we would call tevent_req_done, effectivelly marking the whole nesting
> level as done. That is wrong, we should only move to next group in the
> same nesting level.
>
> Attached are two patches. One that applies on the 1.5 branch and another
> one that can be applied on top of both 1.8 and master.
>
> I haven't yet figured out why we're not seeing the bug on master even
> though the buggy code is there. Probably this issue is being shadowed b
> another bug in the ghost users..I'll investigate more.
>
> For now, I'm sending the patches for review to unblock the branches that
> are affected by the bug.

Nack (minor).
Can you write the same code for both branches?

[Jakub Hrozek]

On Fri, Aug 17, 2012 at 10:07:00AM +0200, Pavel Březina wrote:
> On 08/17/2012 12:25 AM, Jakub Hrozek wrote:
> > https://bugzilla.redhat.com/show_bug.cgi?id=846664
> >
> > If the first group was cached when processing the nested group membership,
> > we would call tevent_req_done, effectivelly marking the whole nesting
> > level as done. That is wrong, we should only move to next group in the
> > same nesting level.
> >
> > Attached are two patches. One that applies on the 1.5 branch and another
> > one that can be applied on top of both 1.8 and master.
> >
> > I haven't yet figured out why we're not seeing the bug on master even
> > though the buggy code is there. Probably this issue is being shadowed b
> > another bug in the ghost users..I'll investigate more.
> >
> > For now, I'm sending the patches for review to unblock the branches that
> > are affected by the bug.
>
> Nack (minor).
> Can you write the same code for both branches?

Attached.

[Pavel Březina]

On 08/17/2012 01:37 PM, Jakub Hrozek wrote:
> On Fri, Aug 17, 2012 at 10:07:00AM +0200, Pavel Březina wrote:
> > On 08/17/2012 12:25 AM, Jakub Hrozek wrote:
> > > https://bugzilla.redhat.com/show_bug.cgi?id=846664
> > >
> > > If the first group was cached when processing the nested group membership,
> > > we would call tevent_req_done, effectivelly marking the whole nesting
> > > level as done. That is wrong, we should only move to next group in the
> > > same nesting level.
> > >
> > > Attached are two patches. One that applies on the 1.5 branch and another
> > > one that can be applied on top of both 1.8 and master.
> > >
> > > I haven't yet figured out why we're not seeing the bug on master even
> > > though the buggy code is there. Probably this issue is being shadowed b
> > > another bug in the ghost users..I'll investigate more.
> > >
> > > For now, I'm sending the patches for review to unblock the branches that
> > > are affected by the bug.
> >
> > Nack (minor).
> > Can you write the same code for both branches?
>
> Attached.

Ack.

[Jakub Hrozek]

On Fri, Aug 17, 2012 at 01:47:10PM +0200, Pavel Březina wrote:
> On 08/17/2012 01:37 PM, Jakub Hrozek wrote:
> > On Fri, Aug 17, 2012 at 10:07:00AM +0200, Pavel Březina wrote:
> > > On 08/17/2012 12:25 AM, Jakub Hrozek wrote:
> > > > https://bugzilla.redhat.com/show_bug.cgi?id=846664
> > > >
> > > > If the first group was cached when processing the nested group membership,
> > > > we would call tevent_req_done, effectivelly marking the whole nesting
> > > > level as done. That is wrong, we should only move to next group in the
> > > > same nesting level.
> > > >
> > > > Attached are two patches. One that applies on the 1.5 branch and another
> > > > one that can be applied on top of both 1.8 and master.
> > > >
> > > > I haven't yet figured out why we're not seeing the bug on master even
> > > > though the buggy code is there. Probably this issue is being shadowed b
> > > > another bug in the ghost users..I'll investigate more.
> > > >
> > > > For now, I'm sending the patches for review to unblock the branches that
> > > > are affected by the bug.
> > >
> > > Nack (minor).
> > > Can you write the same code for both branches?
> >
> > Attached.
>
> Ack.

The first patch was pushed to master and sssd-1-8.

The second patch was pushed to sssd-1-5.