[sssd PR#5929][opened] Tests: Add tests for poor man's backtrace

[sgoveas]

   URL: https://github.com/SSSD/sssd/pull/5929
Author: sgoveas
 Title: #5929: Tests: Add tests for poor man's backtrace
Action: opened

PR body:
"""
Tests are added to check that no duplicate backtrace is generated and it
is generated when
* no debug level is defined / default debug level
* debug level is set to 0 or 1
* no backtrace when debug level is >= 9
* backtrace can be disabled

Verifies: #5585
          https://bugzilla.redhat.com/show_bug.cgi?id=1949149
          https://bugzilla.redhat.com/show_bug.cgi?id=2021196
"""

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5929/head:pr5929
git checkout pr5929

[sssd PR#5929][+Waiting for review] Tests: Add tests for poor man's backtrace

[sgoveas]

  URL: https://github.com/SSSD/sssd/pull/5929
Title: #5929: Tests: Add tests for poor man's backtrace

Label: +Waiting for review

[sssd PR#5929][+Tests] Tests: Add tests for poor man's backtrace

[sgoveas]

  URL: https://github.com/SSSD/sssd/pull/5929
Title: #5929: Tests: Add tests for poor man's backtrace

Label: +Tests

[sssd PR#5929][synchronized] Tests: Add tests for poor man's backtrace

[sgoveas]

   URL: https://github.com/SSSD/sssd/pull/5929
Author: sgoveas
 Title: #5929: Tests: Add tests for poor man's backtrace
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5929/head:pr5929
git checkout pr5929

[sssd PR#5929][synchronized] Tests: Add tests for poor man's backtrace

[sgoveas]

   URL: https://github.com/SSSD/sssd/pull/5929
Author: sgoveas
 Title: #5929: Tests: Add tests for poor man's backtrace
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5929/head:pr5929
git checkout pr5929

[sssd PR#5929][comment] Tests: Add tests for poor man's backtrace

[shridhargadekar]

  URL: https://github.com/SSSD/sssd/pull/5929
Title: #5929: Tests: Add tests for poor man's backtrace

shridhargadekar commented:
"""
Some places in code, are using f-strings and some are not. Like line34,37 and other. Try
to implement f-strings through out the MR.
"""

See the full comment at https://github.com/SSSD/sssd/pull/5929#issuecomment-1006391313

[sssd PR#5929][synchronized] Tests: Add tests for poor man's backtrace

[sgoveas]

   URL: https://github.com/SSSD/sssd/pull/5929
Author: sgoveas
 Title: #5929: Tests: Add tests for poor man's backtrace
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5929/head:pr5929
git checkout pr5929

[sssd PR#5929][comment] Tests: Add tests for poor man's backtrace

[alexey-tikhonov]

  URL: https://github.com/SSSD/sssd/pull/5929
Title: #5929: Tests: Add tests for poor man's backtrace

alexey-tikhonov commented:
"""
Hi,

I have a couple of questions, but in general looks good to me.
"""

See the full comment at https://github.com/SSSD/sssd/pull/5929#issuecomment-1007764283

[sssd PR#5929][comment] Tests: Add tests for poor man's backtrace

[shridhargadekar]

  URL: https://github.com/SSSD/sssd/pull/5929
Title: #5929: Tests: Add tests for poor man's backtrace

shridhargadekar commented:
"""
PR looks good from code perspective. Once questions from Alexey are answered, we could
merge it.
"""

See the full comment at https://github.com/SSSD/sssd/pull/5929#issuecomment-1009633768