[PATCH] sss_cache: support invalidating services and autofs maps

[Jakub Hrozek]

I already had the autofs part done from when I wrote the autofs support,
so adding the services was quite easy.

[Jan Zelený]

>  I already had the autofs part done from when I wrote the autofs
> support,
>  so adding the services was quite easy. 
You have a typo in man page (--autofs-map -> --autofs-maps). Also I wonder if 
we maybe want finer granularity for services, i.e. not only filter by name but 
also by port and protocol. What do you think?

Other than that both patches are fine.

Thanks
Jan

[Stephen Gallagher]

On Wed, 2012-04-11 at 09:10 +0200, Jan Zelený wrote:
>  > I already had the autofs part done from when I wrote the autofs
> support,
>  > so adding the services was quite easy.
>  
>  You have a typo in man page (--autofs-map -> --autofs-maps). Also I wonder if 
>  we maybe want finer granularity for services, i.e. not only filter by name but 
>  also by port and protocol. What do you think? 

I think it's overkill unless someone asks for it. In the general case,
it's not really too harsh to expire all entries (since we're not
actually removing them, thus even expired entries will be returned if
we're offline).

[Jan Zelený]

>  On Wed, 2012-04-11 at 09:10 +0200, Jan Zelený wrote:
>  > > I already had the autofs part done from when I wrote the autofs
>  > > support, so adding the services was quite easy.
>  > 
>  > You have a typo in man page (--autofs-map -> --autofs-maps). Also I
>  > wonder if we maybe want finer granularity for services, i.e. not only
>  > filter by name but also by port and protocol. What do you think?
>  
>  I think it's overkill unless someone asks for it. In the general case,
>  it's not really too harsh to expire all entries (since we're not
>  actually removing them, thus even expired entries will be returned if
>  we're offline). 
Ok, Ack for both patches. Just correct the typo before pushing.

Thanks
Jan

[Jakub Hrozek]

On Thu, Apr 12, 2012 at 08:57:12AM +0200, Jan Zelený wrote:
>  > On Wed, 2012-04-11 at 09:10 +0200, Jan Zelený wrote:
>  > > > I already had the autofs part done from when I wrote the autofs
>  > > > support, so adding the services was quite easy.
>  > > 
>  > > You have a typo in man page (--autofs-map -> --autofs-maps). Also I
>  > > wonder if we maybe want finer granularity for services, i.e. not only
>  > > filter by name but also by port and protocol. What do you think?
>  > 
>  > I think it's overkill unless someone asks for it. In the general case,
>  > it's not really too harsh to expire all entries (since we're not
>  > actually removing them, thus even expired entries will be returned if
>  > we're offline).
>  
>  Ok, Ack for both patches. Just correct the typo before pushing.
>  
>  Thanks
>  Jan 
attached are patches with the typo fixed

[Jan Zelený]

>  On Thu, Apr 12, 2012 at 08:57:12AM +0200, Jan Zelený wrote:
>  > > On Wed, 2012-04-11 at 09:10 +0200, Jan Zelený wrote:
>  > > > > I already had the autofs part done from when I wrote the autofs
>  > > > > support, so adding the services was quite easy.
>  > > > 
>  > > > You have a typo in man page (--autofs-map -> --autofs-maps). Also I
>  > > > wonder if we maybe want finer granularity for services, i.e. not only
>  > > > filter by name but also by port and protocol. What do you think?
>  > > 
>  > > I think it's overkill unless someone asks for it. In the general case,
>  > > it's not really too harsh to expire all entries (since we're not
>  > > actually removing them, thus even expired entries will be returned if
>  > > we're offline).
>  > 
>  > Ok, Ack for both patches. Just correct the typo before pushing.
>  > 
>  > Thanks
>  > Jan
>  
>  attached are patches with the typo fixed 
Ack
(just for the record)

Thanks
Jan

[Stephen Gallagher]

On Wed, 2012-04-18 at 14:04 +0200, Jan Zelený wrote:
>  > On Thu, Apr 12, 2012 at 08:57:12AM +0200, Jan Zelený wrote:
>  > > > On Wed, 2012-04-11 at 09:10 +0200, Jan Zelený wrote:
>  > > > > > I already had the autofs part done from when I wrote the autofs
>  > > > > > support, so adding the services was quite easy.
>  > > > > 
>  > > > > You have a typo in man page (--autofs-map -> --autofs-maps). Also
> I
>  > > > > wonder if we maybe want finer granularity for services, i.e. not
> only
>  > > > > filter by name but also by port and protocol. What do you think?
>  > > > 
>  > > > I think it's overkill unless someone asks for it. In the general
> case,
>  > > > it's not really too harsh to expire all entries (since we're not
>  > > > actually removing them, thus even expired entries will be returned if
>  > > > we're offline).
>  > > 
>  > > Ok, Ack for both patches. Just correct the typo before pushing.
>  > > 
>  > > Thanks
>  > > Jan
>  > 
>  > attached are patches with the typo fixed
>  
>  Ack
>  (just for the record) 

Pushed to master.

[Jakub Hrozek]

On Wed, Apr 11, 2012 at 09:10:35AM +0200, Jan Zelený wrote:
>  > I already had the autofs part done from when I wrote the autofs
> support,
>  > so adding the services was quite easy.
>  
>  You have a typo in man page (--autofs-map -> --autofs-maps). Also I wonder if 
>  we maybe want finer granularity for services, i.e. not only filter by name but 
>  also by port and protocol. What do you think?
>   
If this is a real usecase I will add it.