[PATCH] IPA subdomains - ask for information about master domain

[Jan Zelený]

This functionality will be utilized by PAC responder once it lands in the 
master branch. One round of review already done by Sumit. Also the patch has 
been tested together with the PAC responder.

The query is performed only if there is missing information in the
cache. That means this should be done only once after restart when cache
doesn't exist. All subsequent requests for subdomains won't include the
request for master domain. This is done to save time since it is not possible 
to change this information once IPA server is installed.

https://fedorahosted.org/sssd/ticket/1351

Thanks
Jan

[Jakub Hrozek]

On Wed, May 30, 2012 at 12:34:26PM +0200, Jan Zelený wrote:
> This functionality will be utilized by PAC responder once it lands in the 
> master branch. One round of review already done by Sumit. Also the patch has 
> been tested together with the PAC responder.
>
> The query is performed only if there is missing information in the
> cache. That means this should be done only once after restart when cache
> doesn't exist. All subsequent requests for subdomains won't include the
> request for master domain. This is done to save time since it is not possible 
> to change this information once IPA server is installed.
>
> https://fedorahosted.org/sssd/ticket/1351
>
> Thanks
> Jan

Why is IPA_SUBDOMAINS_SEARCH_BASE set twice in ipa_get_id_options() ?

In which cases is the be_req->sysdb set and when not? Can you add a
comment?
+        sysdb = (be_req->sysdb)?be_req->sysdb:be_req->be_ctx->sysdb;

I always forget if we still keep documenting the low level IPA options such
as search bases..anyway, ipa_subdomains_search_base is included in configAPI
and manpage, but the newly added ipa_master_domain_search_base is not.

[Jan Zelený]

Jakub Hrozek  wrote:
> On Wed, May 30, 2012 at 12:34:26PM +0200, Jan Zelený wrote:
> > This functionality will be utilized by PAC responder once it lands in the
> > master branch. One round of review already done by Sumit. Also the patch
> > has been tested together with the PAC responder.
> >
> > The query is performed only if there is missing information in the
> > cache. That means this should be done only once after restart when cache
> > doesn't exist. All subsequent requests for subdomains won't include the
> > request for master domain. This is done to save time since it is not
> > possible to change this information once IPA server is installed.
> >
> > https://fedorahosted.org/sssd/ticket/1351
> >
> > Thanks
> > Jan
>
> Why is IPA_SUBDOMAINS_SEARCH_BASE set twice in ipa_get_id_options() ?

copy-paste error, sorry for that
> In which cases is the be_req->sysdb set and when not? Can you add a
> comment?
>    sysdb = (be_req->sysdb)?be_req->sysdb:be_req->be_ctx->sysdb;

It is used in my other patch, I guess I got confused while implementing both 
at the same time. In this case sysdb will be always taken from be_ctx.
> I always forget if we still keep documenting the low level IPA options such
> as search bases..anyway, ipa_subdomains_search_base is included in
> configAPI and manpage, but the newly added ipa_master_domain_search_base
> is not.

Oh man, how did I grep through the file while looking for it I don't know ... 
the new option should be there as well of course. As for documentation, I 
don't think we want to document this, setting it can only break things.

Patch with all three issues addressed is in attachment.

Thanks
Jan

[Jakub Hrozek]

On Thu, May 31, 2012 at 09:35:49PM +0200, Jan Zeleny wrote:
> Jakub Hrozek  wrote:
> > On Wed, May 30, 2012 at 12:34:26PM +0200, Jan Zelený wrote:
> > > This functionality will be utilized by PAC responder once it lands in the
> > > master branch. One round of review already done by Sumit. Also the patch
> > > has been tested together with the PAC responder.
> > >
> > > The query is performed only if there is missing information in the
> > > cache. That means this should be done only once after restart when cache
> > > doesn't exist. All subsequent requests for subdomains won't include the
> > > request for master domain. This is done to save time since it is not
> > > possible to change this information once IPA server is installed.
> > >
> > > https://fedorahosted.org/sssd/ticket/1351
> > >
> > > Thanks
> > > Jan
> >
> > Why is IPA_SUBDOMAINS_SEARCH_BASE set twice in ipa_get_id_options() ?
>
> copy-paste error, sorry for that
> > In which cases is the be_req->sysdb set and when not? Can you add a
> > comment?
> >    sysdb = (be_req->sysdb)?be_req->sysdb:be_req->be_ctx->sysdb;
>
> It is used in my other patch, I guess I got confused while implementing both 
> at the same time. In this case sysdb will be always taken from be_ctx.
> > I always forget if we still keep documenting the low level IPA options such
> > as search bases..anyway, ipa_subdomains_search_base is included in
> > configAPI and manpage, but the newly added ipa_master_domain_search_base
> > is not.
>
> Oh man, how did I grep through the file while looking for it I don't know ... 
> the new option should be there as well of course. As for documentation, I 
> don't think we want to document this, setting it can only break things.
>
> Patch with all three issues addressed is in attachment.
>
> Thanks
> Jan

The code is now OK but the option is still not included in
src/config/SSSDConfig/__init__.py.in or the manpage.

[Jan Zelený]

> On Thu, May 31, 2012 at 09:35:49PM +0200, Jan Zeleny wrote:
> > Jakub Hrozek  wrote:
> > > On Wed, May 30, 2012 at 12:34:26PM +0200, Jan Zelený wrote:
> > > > This functionality will be utilized by PAC responder once it lands in
> > > > the master branch. One round of review already done by Sumit. Also
> > > > the patch has been tested together with the PAC responder.
> > > >
> > > > The query is performed only if there is missing information in the
> > > > cache. That means this should be done only once after restart when
> > > > cache doesn't exist. All subsequent requests for subdomains won't
> > > > include the request for master domain. This is done to save time
> > > > since it is not possible to change this information once IPA server
> > > > is installed.
> > > >
> > > > https://fedorahosted.org/sssd/ticket/1351
> > > >
> > > > Thanks
> > > > Jan
> > >
> > > Why is IPA_SUBDOMAINS_SEARCH_BASE set twice in ipa_get_id_options() ?
> >
> > copy-paste error, sorry for that
> > > In which cases is the be_req->sysdb set and when not? Can you add a
> > > comment?
> > >    sysdb = (be_req->sysdb)?be_req->sysdb:be_req->be_ctx->sysdb;
> >
> > It is used in my other patch, I guess I got confused while implementing
> > both at the same time. In this case sysdb will be always taken from
> > be_ctx.
> > > I always forget if we still keep documenting the low level IPA options
> > > such as search bases..anyway, ipa_subdomains_search_base is included
> > > in configAPI and manpage, but the newly added
> > > ipa_master_domain_search_base is not.
> >
> > Oh man, how did I grep through the file while looking for it I don't know
> > ... the new option should be there as well of course. As for
> > documentation, I don't think we want to document this, setting it can
> > only break things.
> >
> > Patch with all three issues addressed is in attachment.
> >
> > Thanks
> > Jan
>
> The code is now OK but the option is still not included in
> src/config/SSSDConfig/__init__.py.in or the manpage.

I still don't think we should document this. If it was up to me, I'd delete 
the documentation of ipa_subdomains_search_base as well. Anyway, new patch is 
attached.

Jan

[Jakub Hrozek]

On Fri, Jun 08, 2012 at 02:18:14PM +0200, Jan Zelený wrote:
> > On Thu, May 31, 2012 at 09:35:49PM +0200, Jan Zeleny wrote:
> > > Jakub Hrozek  wrote:
> > > > On Wed, May 30, 2012 at 12:34:26PM +0200, Jan Zelený wrote:
> > > > > This functionality will be utilized by PAC responder once it lands in
> > > > > the master branch. One round of review already done by Sumit. Also
> > > > > the patch has been tested together with the PAC responder.
> > > > >
> > > > > The query is performed only if there is missing information in the
> > > > > cache. That means this should be done only once after restart when
> > > > > cache doesn't exist. All subsequent requests for subdomains won't
> > > > > include the request for master domain. This is done to save time
> > > > > since it is not possible to change this information once IPA server
> > > > > is installed.
> > > > >
> > > > > https://fedorahosted.org/sssd/ticket/1351
> > > > >
> > > > > Thanks
> > > > > Jan
> > > >
> > > > Why is IPA_SUBDOMAINS_SEARCH_BASE set twice in ipa_get_id_options() ?
> > >
> > > copy-paste error, sorry for that
> > > > In which cases is the be_req->sysdb set and when not? Can you add a
> > > > comment?
> > > >    sysdb = (be_req->sysdb)?be_req->sysdb:be_req->be_ctx->sysdb;
> > >
> > > It is used in my other patch, I guess I got confused while implementing
> > > both at the same time. In this case sysdb will be always taken from
> > > be_ctx.
> > > > I always forget if we still keep documenting the low level IPA options
> > > > such as search bases..anyway, ipa_subdomains_search_base is included
> > > > in configAPI and manpage, but the newly added
> > > > ipa_master_domain_search_base is not.
> > >
> > > Oh man, how did I grep through the file while looking for it I don't know
> > > ... the new option should be there as well of course. As for
> > > documentation, I don't think we want to document this, setting it can
> > > only break things.
> > >
> > > Patch with all three issues addressed is in attachment.
> > >
> > > Thanks
> > > Jan
> >
> > The code is now OK but the option is still not included in
> > src/config/SSSDConfig/__init__.py.in or the manpage.
>
> I still don't think we should document this. If it was up to me, I'd delete 
> the documentation of ipa_subdomains_search_base as well. Anyway, new patch is 
> attached.
>
> Jan

Ack

[Stephen Gallagher]

On Sun, 2012-06-10 at 08:10 +0200, Jakub Hrozek wrote:
> On Fri, Jun 08, 2012 at 02:18:14PM +0200, Jan Zelený wrote:
> > > On Thu, May 31, 2012 at 09:35:49PM +0200, Jan Zeleny wrote:
> > > > Jakub Hrozek  wrote:
> > > > > On Wed, May 30, 2012 at 12:34:26PM +0200, Jan Zelený wrote:
> > > > > > This functionality will be utilized by PAC responder once it lands in
> > > > > > the master branch. One round of review already done by Sumit. Also
> > > > > > the patch has been tested together with the PAC responder.
> > > > > >
> > > > > > The query is performed only if there is missing information in the
> > > > > > cache. That means this should be done only once after restart when
> > > > > > cache doesn't exist. All subsequent requests for subdomains won't
> > > > > > include the request for master domain. This is done to save time
> > > > > > since it is not possible to change this information once IPA server
> > > > > > is installed.
> > > > > >
> > > > > > https://fedorahosted.org/sssd/ticket/1351
> > > > > >
> > > > > > Thanks
> > > > > > Jan
> > > > >
> > > > > Why is IPA_SUBDOMAINS_SEARCH_BASE set twice in ipa_get_id_options() ?
> > > >
> > > > copy-paste error, sorry for that
> > > > > In which cases is the be_req->sysdb set and when not? Can you add a
> > > > > comment?
> > > > >    sysdb = (be_req->sysdb)?be_req->sysdb:be_req->be_ctx->sysdb;
> > > >
> > > > It is used in my other patch, I guess I got confused while implementing
> > > > both at the same time. In this case sysdb will be always taken from
> > > > be_ctx.
> > > > > I always forget if we still keep documenting the low level IPA options
> > > > > such as search bases..anyway, ipa_subdomains_search_base is included
> > > > > in configAPI and manpage, but the newly added
> > > > > ipa_master_domain_search_base is not.
> > > >
> > > > Oh man, how did I grep through the file while looking for it I don't know
> > > > ... the new option should be there as well of course. As for
> > > > documentation, I don't think we want to document this, setting it can
> > > > only break things.
> > > >
> > > > Patch with all three issues addressed is in attachment.
> > > >
> > > > Thanks
> > > > Jan
> > >
> > > The code is now OK but the option is still not included in
> > > src/config/SSSDConfig/__init__.py.in or the manpage.
> >
> > I still don't think we should document this. If it was up to me, I'd delete 
> > the documentation of ipa_subdomains_search_base as well. Anyway, new patch is 
> > attached.
> >
> > Jan
>
> Ack

Pushed to master.