[PATCH] LDAP: Print extended failure message for SASL bind

[Stephen Gallagher]

Adds a useful DEBUG message if SASL binds fail. This was helpful in
tracking down issues while working on the Active Directory ID provider.

[Jan Zelený]

Dne pondělí 25 června 2012 15:17:27, Stephen Gallagher napsal(a):
> Adds a useful DEBUG message if SASL binds fail. This was helpful in
> tracking down issues while working on the Active Directory ID provider.

Nack,
you are comparing optret to LDAP_SUCCESS while you should be comparing it to 
EOK.

Thanks
Jan

[Stephen Gallagher]

On Thu, 2012-06-28 at 17:06 +0200, Jan Zelený wrote:
> Dne pondělí 25 června 2012 15:17:27, Stephen Gallagher napsal(a):
> > Adds a useful DEBUG message if SASL binds fail. This was helpful in
> > tracking down issues while working on the Active Directory ID provider.
>
> Nack,
> you are comparing optret to LDAP_SUCCESS while you should be comparing it to 
> EOK.

Thanks for catching that. Fixed in the attached patch.

[Simo Sorce]

On Mon, 2012-07-02 at 10:40 -0400, Stephen Gallagher wrote:
> On Thu, 2012-06-28 at 17:06 +0200, Jan Zelený wrote:
> > Dne pondělí 25 června 2012 15:17:27, Stephen Gallagher napsal(a):
> > > Adds a useful DEBUG message if SASL binds fail. This was helpful in
> > > tracking down issues while working on the Active Directory ID provider.
> >
> > Nack,
> > you are comparing optret to LDAP_SUCCESS while you should be comparing it to 
> > EOK.
>
> Thanks for catching that. Fixed in the attached patch.

ACK.

Simo.

[Stephen Gallagher]

On Mon, 2012-07-02 at 15:04 -0400, Simo Sorce wrote:
> On Mon, 2012-07-02 at 10:40 -0400, Stephen Gallagher wrote:
> > On Thu, 2012-06-28 at 17:06 +0200, Jan Zelený wrote:
> > > Dne pondělí 25 června 2012 15:17:27, Stephen Gallagher napsal(a):
> > > > Adds a useful DEBUG message if SASL binds fail. This was helpful in
> > > > tracking down issues while working on the Active Directory ID provider.
> > >
> > > Nack,
> > > you are comparing optret to LDAP_SUCCESS while you should be comparing it to 
> > > EOK.
> >
> > Thanks for catching that. Fixed in the attached patch.
>
> ACK.

Pushed to master.