URL: https://github.com/SSSD/sssd/pull/133 Author: pbrezina Title: #133: sbus: use sss_ptr_hash for hash tables Action: opened
PR body: """ This patch reuses `sss_ptr_hash` module introduced in NSS patches in `sbus` code. """
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/133/head:pr133 git checkout pr133
URL: https://github.com/SSSD/sssd/pull/133 Title: #133: sbus: use sss_ptr_hash for hash tables
fidencio commented: """ All the patches look sane.
I, personally, would like to see some message in the commit log. If you don't think it's needed, feel free to just ignore this comment.
Also, tt's really a nitpick, but I'd change "sbus" to "SBUS" in the commit short-log for all patches, but this can be easily done before pushing.
I'll ack the patch as soon as I get CI results. """
See the full comment at https://github.com/SSSD/sssd/pull/133#issuecomment-275105854
URL: https://github.com/SSSD/sssd/pull/133 Title: #133: sbus: use sss_ptr_hash for hash tables
fidencio commented: """ All the patches look sane.
I, personally, would like to see some message in the commit log. If you don't think it's needed, feel free to just ignore this comment.
Also, tt's really a nitpick, but I'd change "sbus" to "SBUS" in the commit short-log for all patches, but this can be easily done before pushing.
I'll ack the patch as soon as I get CI results. """
See the full comment at https://github.com/SSSD/sssd/pull/133#issuecomment-275105854
URL: https://github.com/SSSD/sssd/pull/133 Title: #133: sbus: use sss_ptr_hash for hash tables
Label: +Accepted
URL: https://github.com/SSSD/sssd/pull/133 Title: #133: sbus: use sss_ptr_hash for hash tables
fidencio commented: """ Tests have passed but our CI seems half broken. """
See the full comment at https://github.com/SSSD/sssd/pull/133#issuecomment-275129545
URL: https://github.com/SSSD/sssd/pull/133 Title: #133: sbus: use sss_ptr_hash for hash tables
pbrezina commented: """ What would you like to see in the commit message? Description of `sss_ptr_hash`? """
See the full comment at https://github.com/SSSD/sssd/pull/133#issuecomment-275364436
URL: https://github.com/SSSD/sssd/pull/133 Title: #133: sbus: use sss_ptr_hash for hash tables
fidencio commented: """ "This patch reuses sss_ptr_hash module introduced in NSS patches in sbus code", as in the description of the PR would be more than enough. """
See the full comment at https://github.com/SSSD/sssd/pull/133#issuecomment-275368883
URL: https://github.com/SSSD/sssd/pull/133 Author: pbrezina Title: #133: sbus: use sss_ptr_hash for hash tables Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/133/head:pr133 git checkout pr133
URL: https://github.com/SSSD/sssd/pull/133 Author: pbrezina Title: #133: sbus: use sss_ptr_hash for hash tables Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/133/head:pr133 git checkout pr133
URL: https://github.com/SSSD/sssd/pull/133 Title: #133: sbus: use sss_ptr_hash for hash tables
pbrezina commented: """ Ok, pushed. """
See the full comment at https://github.com/SSSD/sssd/pull/133#issuecomment-275369657
URL: https://github.com/SSSD/sssd/pull/133 Title: #133: sbus: use sss_ptr_hash for hash tables
fidencio commented: """ Acked! Thanks for the changes! """
See the full comment at https://github.com/SSSD/sssd/pull/133#issuecomment-275381727
URL: https://github.com/SSSD/sssd/pull/133 Title: #133: sbus: use sss_ptr_hash for hash tables
lslebodn commented: """ master: * b1afef0bc8d98c389a7f71307bee8ef9fc991ced * ea872f140a04419fba3f2b9722da74d7fd1ca1ee * a3b2bc38263191f23eba2ad98470d8ecd016a60b * bc898b360b9667195a7ae59537587c3ec696ac19
"""
See the full comment at https://github.com/SSSD/sssd/pull/133#issuecomment-276659291
URL: https://github.com/SSSD/sssd/pull/133 Title: #133: sbus: use sss_ptr_hash for hash tables
Label: +Pushed
URL: https://github.com/SSSD/sssd/pull/133 Author: pbrezina Title: #133: sbus: use sss_ptr_hash for hash tables Action: closed
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/133/head:pr133 git checkout pr133
sssd-devel@lists.fedorahosted.org
-
fidencio