[sssd PR#696][opened] DYNDNS: SSSD does not batch DDNS update requests

[thalman]

URL: https://github.com/SSSD/sssd/pull/696
Author: thalman
 Title: #696: DYNDNS: SSSD does not batch DDNS update requests
Action: opened

PR body:
"""
SSSD includes a 'send' command in between each record modification
and does not batch DDNS update requests. This is problematic in
complex AD environments because those requests may not be processed
by the same server.

Now zone update is done in two steps - one per
protocol family. If dyndns_update_per_family is set
to false, update is performed in single step.

Resolves:
https://pagure.io/SSSD/sssd/issue/3829
"""

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/696/head:pr696
git checkout pr696

[sssd PR#696][+Changes requested] DYNDNS: SSSD does not batch DDNS update requests

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/696
Title: #696: DYNDNS: SSSD does not batch DDNS update requests

Label: +Changes requested

[sssd PR#696][synchronized] DYNDNS: SSSD does not batch DDNS update requests

[thalman]

URL: https://github.com/SSSD/sssd/pull/696
Author: thalman
 Title: #696: DYNDNS: SSSD does not batch DDNS update requests
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/696/head:pr696
git checkout pr696

[sssd PR#696][synchronized] DYNDNS: SSSD does not batch DDNS update requests

[thalman]

URL: https://github.com/SSSD/sssd/pull/696
Author: thalman
 Title: #696: DYNDNS: SSSD does not batch DDNS update requests
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/696/head:pr696
git checkout pr696

[sssd PR#696][synchronized] DYNDNS: SSSD does not batch DDNS update requests

[thalman]

URL: https://github.com/SSSD/sssd/pull/696
Author: thalman
 Title: #696: DYNDNS: SSSD does not batch DDNS update requests
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/696/head:pr696
git checkout pr696

[sssd PR#696][-Changes requested] DYNDNS: SSSD does not batch DDNS update requests

[thalman]

URL: https://github.com/SSSD/sssd/pull/696
Title: #696: DYNDNS: SSSD does not batch DDNS update requests

Label: -Changes requested

[sssd PR#696][comment] DYNDNS: SSSD does not batch DDNS update requests

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/696
Title: #696: DYNDNS: SSSD does not batch DDNS update requests

pbrezina commented:
"""
There is one typo that needs to be fixed otherwise the patch looks good.

Code-style wise, we usually use an empty line after closing bracket, i.e.

```
  if (...) {
  }

if (...) {
      ....
  }

return xyz;
```

Since the patch need one more change, perhaps you could change this as well. Thank you.
"""

See the full comment at https://github.com/SSSD/sssd/pull/696#issuecomment-445184876

[sssd PR#696][synchronized] DYNDNS: SSSD does not batch DDNS update requests

[thalman]

URL: https://github.com/SSSD/sssd/pull/696
Author: thalman
 Title: #696: DYNDNS: SSSD does not batch DDNS update requests
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/696/head:pr696
git checkout pr696

[sssd PR#696][comment] DYNDNS: SSSD does not batch DDNS update requests

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/696
Title: #696: DYNDNS: SSSD does not batch DDNS update requests

pbrezina commented:
"""
Ack. Thank you.
"""

See the full comment at https://github.com/SSSD/sssd/pull/696#issuecomment-445211142

[sssd PR#696][+Accepted] DYNDNS: SSSD does not batch DDNS update requests

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/696
Title: #696: DYNDNS: SSSD does not batch DDNS update requests

Label: +Accepted

[sssd PR#696][comment] DYNDNS: SSSD does not batch DDNS update requests

[jhrozek]

URL: https://github.com/SSSD/sssd/pull/696
Title: #696: DYNDNS: SSSD does not batch DDNS update requests

jhrozek commented:
"""
* master: 5565dd365e704f6ded4f95db5bfbefd5dffc888b
"""

See the full comment at https://github.com/SSSD/sssd/pull/696#issuecomment-445996712

[sssd PR#696][closed] DYNDNS: SSSD does not batch DDNS update requests

[jhrozek]

URL: https://github.com/SSSD/sssd/pull/696
Author: thalman
 Title: #696: DYNDNS: SSSD does not batch DDNS update requests
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/696/head:pr696
git checkout pr696

[sssd PR#696][+Pushed] DYNDNS: SSSD does not batch DDNS update requests

[jhrozek]

URL: https://github.com/SSSD/sssd/pull/696
Title: #696: DYNDNS: SSSD does not batch DDNS update requests

Label: +Pushed