[sssd PR#25] TESTS: Add integration tests for the proxy provider of sssd-secrets (opened)

[fidencio]

jhrozek's pull request #25: "TESTS: Add integration tests for the proxy provider
of sssd-secrets" was opened

PR body:
"""
Execrcies the basic operations of the sssd-secrets responder and can be
used as a basis to add more tests.
"""

See the full pull-request at https://github.com/SSSD/sssd/pull/25
... or pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/25/head:pr25
git checkout pr25

[sssd PR#25] TESTS: Add integration tests for the proxy provider of sssd-secrets (comment)

[fidencio]

jhrozek commented on a pull request

"""
btw here are CI tests on all supported systems:
http://sssd-ci.duckdns.org/logs/job/53/41/summary.html
"""

See the full comment at https://github.com/SSSD/sssd/pull/25#issuecomment-246998696

[sssd PR#25] TESTS: Add integration tests for the proxy provider of sssd-secrets (+Changes requested)

[fidencio]

jhrozek's pull request #25: "TESTS: Add integration tests for the proxy provider
of sssd-secrets" label *Changes requested* has been added

See the full pull-request at https://github.com/SSSD/sssd/pull/25

[Lukas Slebodnik]

On (14/09/16 12:02), jhrozek wrote:
> jhrozek's pull request #25: "TESTS: Add integration tests for
> the proxy provider of sssd-secrets" was opened
>
> PR body:
> """
> Execrcies the basic operations of the sssd-secrets responder and can be
> used as a basis to add more tests.
> """
>
> See the full pull-request at https://github.com/SSSD/sssd/pull/25
> ... or pull the PR as Git branch:
> git remote add ghsssd https://github.com/SSSD/sssd
> git fetch ghsssd pull/25/head:pr25
> git checkout pr25 
> From 5be3820f25b0eb30f3bd63538a3900cf51f7ae21 Mon Sep 17 00:00:00
> 2001
> From: Jakub Hrozek <jhrozek(a)redhat.com&gt;
> Date: Mon, 8 Aug 2016 17:49:05 +0200
> Subject: [PATCH] TESTS: Add integration tests for the sssd-secrets local
>  provider
>
> Resolves:
>     https://fedorahosted.org/sssd/ticket/3054
>
> Implements a simple HTTP client and uses it to talk to the sssd-secrets
> responder. Only the local provider is tested at the moment. 
BTW it looks like you do not use our commit template.

  sh$ cat .git-commit-template
  COMPONENT: Subject

  Explanation

  Resolves:
  https://fedorahosted.org/sssd/ticket/XXXX

  # Try to keep the subject line within 52 chars ----|
  # Also please try to not exceed 72 characters of length for the body --|

LS

[sssd PR#25][synchronized] TESTS: Add integration tests for the proxy provider of sssd-secrets

[fidencio]

   URL: https://github.com/SSSD/sssd/pull/25
Author: jhrozek
 Title: #25: TESTS: Add integration tests for the proxy provider of sssd-secrets
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/25/head:pr25
git checkout pr25

[sssd PR#25][-Changes requested] TESTS: Add integration tests for the proxy provider of sssd-secrets

[fidencio]

  URL: https://github.com/SSSD/sssd/pull/25
Title: #25: TESTS: Add integration tests for the proxy provider of sssd-secrets

Label: -Changes requested

[sssd PR#25][synchronized] TESTS: Add integration tests for the proxy provider of sssd-secrets

[fidencio]

   URL: https://github.com/SSSD/sssd/pull/25
Author: jhrozek
 Title: #25: TESTS: Add integration tests for the proxy provider of sssd-secrets
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/25/head:pr25
git checkout pr25

[sssd PR#25][synchronized] TESTS: Add integration tests for the proxy provider of sssd-secrets

[fidencio]

   URL: https://github.com/SSSD/sssd/pull/25
Author: jhrozek
 Title: #25: TESTS: Add integration tests for the proxy provider of sssd-secrets
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/25/head:pr25
git checkout pr25

[sssd PR#25][comment] TESTS: Add integration tests for the proxy provider of sssd-secrets

[fidencio]

  URL: https://github.com/SSSD/sssd/pull/25
Title: #25: TESTS: Add integration tests for the proxy provider of sssd-secrets

jhrozek commented:
"""
I also added a test for one of Fabiano's patches in the last patch iteration
"""

See the full comment at https://github.com/SSSD/sssd/pull/25#issuecomment-247614911

[sssd PR#25][synchronized] TESTS: Add integration tests for the proxy provider of sssd-secrets

[fidencio]

   URL: https://github.com/SSSD/sssd/pull/25
Author: jhrozek
 Title: #25: TESTS: Add integration tests for the proxy provider of sssd-secrets
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/25/head:pr25
git checkout pr25

[sssd PR#25][comment] TESTS: Add integration tests for the proxy provider of sssd-secrets

[fidencio]

  URL: https://github.com/SSSD/sssd/pull/25
Title: #25: TESTS: Add integration tests for the proxy provider of sssd-secrets

celestian commented:
"""
LGTM,
I will push it to our CI.

And how Lukas mentioned in mail, it could be nice to fix commit message before pushing.
"""

See the full comment at https://github.com/SSSD/sssd/pull/25#issuecomment-247617592

[sssd PR#25][comment] TESTS: Add integration tests for the proxy provider of sssd-secrets

[fidencio]

  URL: https://github.com/SSSD/sssd/pull/25
Title: #25: TESTS: Add integration tests for the proxy provider of sssd-secrets

celestian commented:
"""
CI passed:
http://sssd-ci.duckdns.org/logs/job/53/55/summary.html

ACK
"""

See the full comment at https://github.com/SSSD/sssd/pull/25#issuecomment-247921565

[sssd PR#25][+Accepted] TESTS: Add integration tests for the proxy provider of sssd-secrets

[fidencio]

  URL: https://github.com/SSSD/sssd/pull/25
Title: #25: TESTS: Add integration tests for the proxy provider of sssd-secrets

Label: +Accepted

[sssd PR#25][comment] TESTS: Add integration tests for the proxy provider of sssd-secrets

[fidencio]

  URL: https://github.com/SSSD/sssd/pull/25
Title: #25: TESTS: Add integration tests for the proxy provider of sssd-secrets

lslebodn commented:
"""
On (16/09/16 06:56), Jakub Hrozek wrote:
> jhrozek commented on this pull request.
> > +#
> +
> +import socket
> +import requests
> +
> +from requests.adapters import HTTPAdapter
> +from requests.packages.urllib3.connection import HTTPConnection
> +from requests.packages.urllib3.connectionpool import HTTPConnectionPool
> +from requests.compat import quote, unquote, urlparse
> +
> +
> +class HTTPUnixConnection(HTTPConnection):
> +    def __init__(self, host, timeout=60, **kwargs):
> +        # pylint: disable=bad-super-call
> +        super(HTTPConnection, self).__init__('localhost')
> +        self.unix_socket = host
>
> ok
>  
There is not reason to use pylint disable anymore.

LS

"""

See the full comment at https://github.com/SSSD/sssd/pull/25#issuecomment-247957539

[sssd PR#25][-Accepted] TESTS: Add integration tests for the proxy provider of sssd-secrets

[fidencio]

  URL: https://github.com/SSSD/sssd/pull/25
Title: #25: TESTS: Add integration tests for the proxy provider of sssd-secrets

Label: -Accepted

[sssd PR#25][+Changes requested] TESTS: Add integration tests for the proxy provider of sssd-secrets

[fidencio]

  URL: https://github.com/SSSD/sssd/pull/25
Title: #25: TESTS: Add integration tests for the proxy provider of sssd-secrets

Label: +Changes requested

[sssd PR#25][synchronized] TESTS: Add integration tests for the proxy provider of sssd-secrets

[fidencio]

   URL: https://github.com/SSSD/sssd/pull/25
Author: jhrozek
 Title: #25: TESTS: Add integration tests for the proxy provider of sssd-secrets
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/25/head:pr25
git checkout pr25

[sssd PR#25][comment] TESTS: Add integration tests for the proxy provider of sssd-secrets

[fidencio]

  URL: https://github.com/SSSD/sssd/pull/25
Title: #25: TESTS: Add integration tests for the proxy provider of sssd-secrets

jhrozek commented:
"""
On Mon, Sep 19, 2016 at 03:19:51AM -0700, lslebodn wrote:
>  On (16/09/16 06:56), Jakub Hrozek wrote:
>  >jhrozek commented on this pull request.
>  >> +#
>  >+
>  >+import socket
>  >+import requests
>  >+
>  >+from requests.adapters import HTTPAdapter
>  >+from requests.packages.urllib3.connection import HTTPConnection
>  >+from requests.packages.urllib3.connectionpool import HTTPConnectionPool
>  >+from requests.compat import quote, unquote, urlparse
>  >+
>  >+
>  >+class HTTPUnixConnection(HTTPConnection):
>  >+    def __init__(self, host, timeout=60, **kwargs):
>  >+        # pylint: disable=bad-super-call
>  >+        super(HTTPConnection, self).__init__('localhost')
>  >+        self.unix_socket = host
>  >
>  >ok
>  >
>  There is not reason to use pylint disable anymore. 
OK, fixed.

"""

See the full comment at https://github.com/SSSD/sssd/pull/25#issuecomment-247958533

[sssd PR#25][comment] TESTS: Add integration tests for the proxy provider of sssd-secrets

[fidencio]

  URL: https://github.com/SSSD/sssd/pull/25
Title: #25: TESTS: Add integration tests for the proxy provider of sssd-secrets

celestian commented:
"""
Well,

LGTM. In my opinion we do not have to run CI again for removing of comment.

One last point. Jakub, please, could you fix the commit message? It is not due to our
template how Lukas pointed out in mail.

Regards, Petr
"""

See the full comment at https://github.com/SSSD/sssd/pull/25#issuecomment-247967544

[sssd PR#25][comment] TESTS: Add integration tests for the proxy provider of sssd-secrets

[fidencio]

  URL: https://github.com/SSSD/sssd/pull/25
Title: #25: TESTS: Add integration tests for the proxy provider of sssd-secrets

jhrozek commented:
"""
On Mon, Sep 19, 2016 at 04:21:08AM -0700, celestian wrote:
>  Well,
>  
>  LGTM. In my opinion we do not have to run CI again for removing of comment.
>  
>  One last point. Jakub, please, could you fix the commit message? It is not due to our
> template how Lukas pointed out in mail. 
What is wrong with the commit message? it points to a ticket and
provides some verbose explanation..

"""

See the full comment at https://github.com/SSSD/sssd/pull/25#issuecomment-247970728

[sssd PR#25][comment] TESTS: Add integration tests for the proxy provider of sssd-secrets

[fidencio]

  URL: https://github.com/SSSD/sssd/pull/25
Title: #25: TESTS: Add integration tests for the proxy provider of sssd-secrets

celestian commented:
"""
Jakub,
IMHO we have description and the link to ticket. If it is not so strict then I am OK with
it.

"""

See the full comment at https://github.com/SSSD/sssd/pull/25#issuecomment-247973055

[sssd PR#25][synchronized] TESTS: Add integration tests for the proxy provider of sssd-secrets

[fidencio]

   URL: https://github.com/SSSD/sssd/pull/25
Author: jhrozek
 Title: #25: TESTS: Add integration tests for the proxy provider of sssd-secrets
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/25/head:pr25
git checkout pr25

[sssd PR#25][comment] TESTS: Add integration tests for the proxy provider of sssd-secrets

[fidencio]

  URL: https://github.com/SSSD/sssd/pull/25
Title: #25: TESTS: Add integration tests for the proxy provider of sssd-secrets

jhrozek commented:
"""
ok, description order changed :)
"""

See the full comment at https://github.com/SSSD/sssd/pull/25#issuecomment-247973580

[sssd PR#25][-Changes requested] TESTS: Add integration tests for the proxy provider of sssd-secrets

[fidencio]

  URL: https://github.com/SSSD/sssd/pull/25
Title: #25: TESTS: Add integration tests for the proxy provider of sssd-secrets

Label: -Changes requested

[sssd PR#25][comment] TESTS: Add integration tests for the proxy provider of sssd-secrets

[fidencio]

  URL: https://github.com/SSSD/sssd/pull/25
Title: #25: TESTS: Add integration tests for the proxy provider of sssd-secrets

lslebodn commented:
"""
On (19/09/16 04:39), Jakub Hrozek wrote:
> On Mon, Sep 19, 2016 at 04:21:08AM -0700, celestian wrote:
> > Well,
> > 
> > LGTM. In my opinion we do not have to run CI again for removing of comment.
> > 
> > One last point. Jakub, please, could you fix the commit message? It is not due to our
> template how Lukas pointed out in mail.
>
> What is wrong with the commit message? it points to a ticket and
> provides some verbose explanation..
>  
There are extra spaces before URL.

Try to look into out git commit template
sh$ cat .git-commit-template
COMPONENT: Subject

Explanation

Resolves:
https://fedorahosted.org/sssd/ticket/XXXX

# Try to keep the subject line within 52 chars ----|
# Also please try to not exceed 72 characters of length for the body --|

And also try too lok into commit message ot patch
when it was introduced 3d9edb4c510028def2df41aa7b0ce705b197e6fc

LS

"""

See the full comment at https://github.com/SSSD/sssd/pull/25#issuecomment-247975887

[sssd PR#25][synchronized] TESTS: Add integration tests for the proxy provider of sssd-secrets

[fidencio]

   URL: https://github.com/SSSD/sssd/pull/25
Author: jhrozek
 Title: #25: TESTS: Add integration tests for the proxy provider of sssd-secrets
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/25/head:pr25
git checkout pr25

[sssd PR#25][comment] TESTS: Add integration tests for the proxy provider of sssd-secrets

[fidencio]

  URL: https://github.com/SSSD/sssd/pull/25
Title: #25: TESTS: Add integration tests for the proxy provider of sssd-secrets

jhrozek commented:
"""
On Mon, Sep 19, 2016 at 05:08:51AM -0700, lslebodn wrote:
>  On (19/09/16 04:39), Jakub Hrozek wrote:
>  >On Mon, Sep 19, 2016 at 04:21:08AM -0700, celestian wrote:
>  >> Well,
>  >> 
>  >> LGTM. In my opinion we do not have to run CI again for removing of comment.
>  >> 
>  >> One last point. Jakub, please, could you fix the commit message? It is not due
> to our template how Lukas pointed out in mail.
>  >
>  >What is wrong with the commit message? it points to a ticket and
>  >provides some verbose explanation..
>  >
>  There are extra spaces before URL.
>  
>  Try to look into out git commit template
>  sh$ cat .git-commit-template
>  COMPONENT: Subject
>  
>  Explanation
>  
>  Resolves:
>  https://fedorahosted.org/sssd/ticket/XXXX
>  
>  # Try to keep the subject line within 52 chars ----|
>  # Also please try to not exceed 72 characters of length for the body --|
>  
>  And also try too lok into commit message ot patch
>  when it was introduced 3d9edb4c510028def2df41aa7b0ce705b197e6fc 
OK, third attempt at passing review of commit message.

"""

See the full comment at https://github.com/SSSD/sssd/pull/25#issuecomment-247980318

[sssd PR#25][comment] TESTS: Add integration tests for the proxy provider of sssd-secrets

[fidencio]

  URL: https://github.com/SSSD/sssd/pull/25
Title: #25: TESTS: Add integration tests for the proxy provider of sssd-secrets

celestian commented:
"""
Thanks, Jakub.
I would like to wait for pending check. I hope we could ACK this patch soon.

"""

See the full comment at https://github.com/SSSD/sssd/pull/25#issuecomment-247981532

[sssd PR#25][comment] TESTS: Add integration tests for the proxy provider of sssd-secrets

[fidencio]

  URL: https://github.com/SSSD/sssd/pull/25
Title: #25: TESTS: Add integration tests for the proxy provider of sssd-secrets

celestian commented:
"""
ACK
"""

See the full comment at https://github.com/SSSD/sssd/pull/25#issuecomment-247988840

[sssd PR#25][+Accepted] TESTS: Add integration tests for the proxy provider of sssd-secrets

[fidencio]

  URL: https://github.com/SSSD/sssd/pull/25
Title: #25: TESTS: Add integration tests for the proxy provider of sssd-secrets

Label: +Accepted

[sssd PR#25][-Accepted] TESTS: Add integration tests for the proxy provider of sssd-secrets

[fidencio]

  URL: https://github.com/SSSD/sssd/pull/25
Title: #25: TESTS: Add integration tests for the proxy provider of sssd-secrets

Label: -Accepted

[sssd PR#25][synchronized] TESTS: Add integration tests for the proxy provider of sssd-secrets

[fidencio]

   URL: https://github.com/SSSD/sssd/pull/25
Author: jhrozek
 Title: #25: TESTS: Add integration tests for the proxy provider of sssd-secrets
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/25/head:pr25
git checkout pr25

[sssd PR#25][comment] TESTS: Add integration tests for the proxy provider of sssd-secrets

[fidencio]

  URL: https://github.com/SSSD/sssd/pull/25
Title: #25: TESTS: Add integration tests for the proxy provider of sssd-secrets

jhrozek commented:
"""
On Mon, Sep 19, 2016 at 06:54:12AM -0700, lslebodn wrote:
>  lslebodn commented on this pull request.
>  
>  
>  
>  > +    os.chmod(config.CONF_PATH, stat.S_IRUSR | stat.S_IWUSR)
>  +    request.addfinalizer(lambda: os.unlink(config.CONF_PATH))
>  +
>  +
>  +def create_sssd_secrets_fixture(request):
>  +    if subprocess.call(['sssd', "--genconf"]) != 0:
>  +        raise Exception("failed to regenerate confdb")
>  +
>  +    resp_path = os.path.join(config.LIBEXEC_PATH, "sssd",
> "sssd_secrets")
>  +
>  +    secpid = os.fork()
>  +    if secpid == 0:
>  +        if subprocess.call([resp_path, "--uid=0", "--gid=0"]) != 0:
>  +            raise Exception("sssd_secrets failed to start")
>  +
>  +    time.sleep(1)
>  
>  Is there a reason for this sleep?
>  
>  The test passed for me in 0.39 second without it.
>  With the sleep it took 2.40 seconds. 
I was getting random failures where the socket was not yet ready without
the sleep, like this:
    ConnectionError: ('Connection aborted.', error(2, 'No such file or
    directory'))

I think the test was just too fast. I pushed a new version that instead
tries to connect to the socket and waits 0.2 sec if it cannot. The test
gives up after a second.

"""

See the full comment at https://github.com/SSSD/sssd/pull/25#issuecomment-248271267

[sssd PR#25][comment] TESTS: Add integration tests for the proxy provider of sssd-secrets

[fidencio]

  URL: https://github.com/SSSD/sssd/pull/25
Title: #25: TESTS: Add integration tests for the proxy provider of sssd-secrets

lslebodn commented:
"""
On (20/09/16 04:09), Jakub Hrozek wrote:
> I was getting random failures where the socket was not yet ready
> without
> the sleep, like this:
>     ConnectionError: ('Connection aborted.', error(2, 'No such file or
>     directory'))
>
> I think the test was just too fast. I pushed a new version that instead
> tries to connect to the socket and waits 0.2 sec if it cannot. The test
> gives up after a second.
>  
Active checking of socket is much better approach.
I think you forgot to close socket :-)

I would also appreciate smaller waits (0.1 or even 0.05)
it's up to you.

LS

"""

See the full comment at https://github.com/SSSD/sssd/pull/25#issuecomment-248278221

[sssd PR#25][synchronized] TESTS: Add integration tests for the proxy provider of sssd-secrets

[fidencio]

   URL: https://github.com/SSSD/sssd/pull/25
Author: jhrozek
 Title: #25: TESTS: Add integration tests for the proxy provider of sssd-secrets
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/25/head:pr25
git checkout pr25

[sssd PR#25][comment] TESTS: Add integration tests for the proxy provider of sssd-secrets

[fidencio]

  URL: https://github.com/SSSD/sssd/pull/25
Title: #25: TESTS: Add integration tests for the proxy provider of sssd-secrets

jhrozek commented:
"""
On Tue, Sep 20, 2016 at 04:45:53AM -0700, lslebodn wrote:
>  On (20/09/16 04:09), Jakub Hrozek wrote:
>  >I was getting random failures where the socket was not yet ready without
>  >the sleep, like this:
>  >    ConnectionError: ('Connection aborted.', error(2, 'No such file or
>  >    directory'))
>  >
>  >I think the test was just too fast. I pushed a new version that instead
>  >tries to connect to the socket and waits 0.2 sec if it cannot. The test
>  >gives up after a second.
>  >
>  Active checking of socket is much better approach.
>  I think you forgot to close socket :-) 
No, I was relying on garbage collector:
    socket.close()
    Close the socket. All future operations on the socket object will
    fail. The remote end will receive no more data (after queued data is
    flushed). Sockets are automatically closed when they are
    garbage-collected.

But it's a good idea to add close explicitly, because at least we get an
exception if the socket was not connected.

>  
>  I would also appreciate smaller waits (0.1 or even 0.05)
>  it's up to you. 
changed.

"""

See the full comment at https://github.com/SSSD/sssd/pull/25#issuecomment-248281373

[sssd PR#25][comment] TESTS: Add integration tests for the proxy provider of sssd-secrets

[fidencio]

  URL: https://github.com/SSSD/sssd/pull/25
Title: #25: TESTS: Add integration tests for the proxy provider of sssd-secrets

celestian commented:
"""
So, code LGTM, thanks for Lukas's watchful eye.
I pushed patch to CI.
"""

See the full comment at https://github.com/SSSD/sssd/pull/25#issuecomment-248297059

[sssd PR#25][comment] TESTS: Add integration tests for the proxy provider of sssd-secrets

[fidencio]

  URL: https://github.com/SSSD/sssd/pull/25
Title: #25: TESTS: Add integration tests for the proxy provider of sssd-secrets

lslebodn commented:
"""
On (20/09/16 05:02), Jakub Hrozek wrote:
> On Tue, Sep 20, 2016 at 04:45:53AM -0700, lslebodn wrote:
> > On (20/09/16 04:09), Jakub Hrozek wrote:
> > >I was getting random failures where the socket was not yet ready without
> > >the sleep, like this:
> > >    ConnectionError: ('Connection aborted.', error(2, 'No such file
> or
> > >    directory'))
> > >
> > >I think the test was just too fast. I pushed a new version that instead
> > >tries to connect to the socket and waits 0.2 sec if it cannot. The test
> > >gives up after a second.
> > >
> > Active checking of socket is much better approach.
> > I think you forgot to close socket :-)
>
> No, I was relying on garbage collector:
>     socket.close()
>     Close the socket. All future operations on the socket object will
>     fail. The remote end will receive no more data (after queued data is
>     flushed). Sockets are automatically closed when they are
>     garbage-collected.
>
> But it's a good idea to add close explicitly, because at least we get an
> exception if the socket was not connected.
>
> > 
> > I would also appreciate smaller waits (0.1 or even 0.05)
> > it's up to you.
>
> changed.
>  
Actually, your version did not work properly because
socket.SOCK_DGRAM is not supported with unix socket.
As a result of this we were always waiting 1 second.

There were lots of iteration therefore
I changed that before pushing.
I also removed semocolon after break (it's not a ansi-C :-)
and replaced "unused variable" i with "_"
replace xrange with range (due to python3 compatibility)
I also changed checking of errors in exception to by python3
compatible

e.g.
-    assert err409.value.message.startswith("409")
+    assert str(err409.value).startswith("409")

The rest of test are not very python3 friendly due to
lack of pthon3-ldb or issues ith ldap. But this
test does not depend on ldap or ldb :-)
Sorry that I did not catch python3 related issues earlier

I hope you don't mint these small changes.
If you do not like it I will not do that in future.

I could not see any failure in CI
http://sssd-ci.duckdns.org/logs-test/job/4/54/summary.html
http://sssd-ci.duckdns.org/logs-test/job/4/55/summary.html
http://sssd-ci.duckdns.org/logs-test/job/4/56/summary.html
http://sssd-ci.duckdns.org/logs-test/job/4/57/summary.html
http://sssd-ci.duckdns.org/logs-test/job/4/58/summary.html

master:
* db0982c52294ee5ea08ed242d27660783fde29cd

LS

"""

See the full comment at https://github.com/SSSD/sssd/pull/25#issuecomment-248340608

[sssd PR#25][comment] TESTS: Add integration tests for the proxy provider of sssd-secrets

[fidencio]

  URL: https://github.com/SSSD/sssd/pull/25
Title: #25: TESTS: Add integration tests for the proxy provider of sssd-secrets

jhrozek commented:
"""
On Tue, Sep 20, 2016 at 08:40:08AM -0700, lslebodn wrote:
>  On (20/09/16 05:02), Jakub Hrozek wrote:
>  >On Tue, Sep 20, 2016 at 04:45:53AM -0700, lslebodn wrote:
>  >> On (20/09/16 04:09), Jakub Hrozek wrote:
>  >> >I was getting random failures where the socket was not yet ready without
>  >> >the sleep, like this:
>  >> >    ConnectionError: ('Connection aborted.', error(2, 'No such
> file or
>  >> >    directory'))
>  >> >
>  >> >I think the test was just too fast. I pushed a new version that instead
>  >> >tries to connect to the socket and waits 0.2 sec if it cannot. The test
>  >> >gives up after a second.
>  >> >
>  >> Active checking of socket is much better approach.
>  >> I think you forgot to close socket :-)
>  >
>  >No, I was relying on garbage collector:
>  >    socket.close()
>  >    Close the socket. All future operations on the socket object will
>  >    fail. The remote end will receive no more data (after queued data is
>  >    flushed). Sockets are automatically closed when they are
>  >    garbage-collected.
>  >
>  >But it's a good idea to add close explicitly, because at least we get an
>  >exception if the socket was not connected.
>  >
>  >> 
>  >> I would also appreciate smaller waits (0.1 or even 0.05)
>  >> it's up to you.
>  >
>  >changed.
>  >
>  Actually, your version did not work properly because
>  socket.SOCK_DGRAM is not supported with unix socket.
>  As a result of this we were always waiting 1 second.
>  
>  There were lots of iteration therefore
>  I changed that before pushing.
>  I also removed semocolon after break (it's not a ansi-C :-)
>  and replaced "unused variable" i with "_"
>  replace xrange with range (due to python3 compatibility)
>  I also changed checking of errors in exception to by python3
>  compatible
>  
>  e.g.
>  -    assert err409.value.message.startswith("409")
>  +    assert str(err409.value).startswith("409")
>  
>  The rest of test are not very python3 friendly due to
>  lack of pthon3-ldb or issues ith ldap. But this
>  test does not depend on ldap or ldb :-)
>  Sorry that I did not catch python3 related issues earlier
>  
>  I hope you don't mint these small changes.
>  If you do not like it I will not do that in future.
>  
>  I could not see any failure in CI
>  http://sssd-ci.duckdns.org/logs-test/job/4/54/summary.html
>  http://sssd-ci.duckdns.org/logs-test/job/4/55/summary.html
>  http://sssd-ci.duckdns.org/logs-test/job/4/56/summary.html
>  http://sssd-ci.duckdns.org/logs-test/job/4/57/summary.html
>  http://sssd-ci.duckdns.org/logs-test/job/4/58/summary.html
>  
>  master:
>  * db0982c52294ee5ea08ed242d27660783fde29cd 
Great, thank you for doing this, I'm just glad we have tests in master
and can add regression tests for other stuff that Fabiano is fixing..

"""

See the full comment at https://github.com/SSSD/sssd/pull/25#issuecomment-248359999

[sssd PR#25][+Pushed] TESTS: Add integration tests for the proxy provider of sssd-secrets

[fidencio]

  URL: https://github.com/SSSD/sssd/pull/25
Title: #25: TESTS: Add integration tests for the proxy provider of sssd-secrets

Label: +Pushed

[sssd PR#25][closed] TESTS: Add integration tests for the proxy provider of sssd-secrets

[fidencio]

   URL: https://github.com/SSSD/sssd/pull/25
Author: jhrozek
 Title: #25: TESTS: Add integration tests for the proxy provider of sssd-secrets
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/25/head:pr25
git checkout pr25