Hi,
I would like to propose this patch as an alternative fix for ticket #533. This patch puts parallel auth requests of a user in a wait queue and handles them one after the other. This will delay parallel auth requests a bit but avoids all kind of race conditions I still can see in the approach for creating the potential new ccache file at the beginning of the request.
bye, Sumit
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 12/17/2010 11:33 AM, Sumit Bose wrote:
Hi,
I would like to propose this patch as an alternative fix for ticket #533. This patch puts parallel auth requests of a user in a wait queue and handles them one after the other. This will delay parallel auth requests a bit but avoids all kind of race conditions I still can see in the approach for creating the potential new ccache file at the beginning of the request.
This patch will need to be updated with the automatic ticket renewal patch (change to sss_hash_create)
Also: cc1: warnings being treated as errors ../src/providers/krb5/krb5_wait_queue.c: In function 'check_wait_queue': ../src/providers/krb5/krb5_wait_queue.c:171:17: error: 'return' with a value, in function returning void cc1: warnings being treated as errors ../src/providers/krb5/krb5_wait_queue.c: In function 'check_wait_queue': ../src/providers/krb5/krb5_wait_queue.c:171:17: error: 'return' with a value, in function returning void make[1]: *** [src/providers/krb5/libsss_krb5_la-krb5_wait_queue.lo] Error 1
Otherwise, the patch looks good to me.
- -- Stephen Gallagher RHCE 804006346421761
Delivering value year after year. Red Hat ranks #1 in value among software vendors. http://www.redhat.com/promo/vendor/
On Fri, Dec 17, 2010 at 04:22:34PM -0500, Stephen Gallagher wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 12/17/2010 11:33 AM, Sumit Bose wrote:
Hi,
I would like to propose this patch as an alternative fix for ticket #533. This patch puts parallel auth requests of a user in a wait queue and handles them one after the other. This will delay parallel auth requests a bit but avoids all kind of race conditions I still can see in the approach for creating the potential new ccache file at the beginning of the request.
This patch will need to be updated with the automatic ticket renewal patch (change to sss_hash_create)
Also: cc1: warnings being treated as errors ../src/providers/krb5/krb5_wait_queue.c: In function 'check_wait_queue': ../src/providers/krb5/krb5_wait_queue.c:171:17: error: 'return' with a value, in function returning void cc1: warnings being treated as errors ../src/providers/krb5/krb5_wait_queue.c: In function 'check_wait_queue': ../src/providers/krb5/krb5_wait_queue.c:171:17: error: 'return' with a value, in function returning void make[1]: *** [src/providers/krb5/libsss_krb5_la-krb5_wait_queue.lo] Error 1
Otherwise, the patch looks good to me.
New patch attached.
bye, Sumit
Stephen Gallagher RHCE 804006346421761
Delivering value year after year. Red Hat ranks #1 in value among software vendors. http://www.redhat.com/promo/vendor/ -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
iEYEARECAAYFAk0L1JoACgkQeiVVYja6o6MbYACeNaiID8uqWFpXY5nMm4VZLpZn bSoAn3T1aQLNLoqhvKpccPF7lXh+kKPe =8rik -----END PGP SIGNATURE----- _______________________________________________ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/sssd-devel
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 12/20/2010 06:18 AM, Sumit Bose wrote:
On Fri, Dec 17, 2010 at 04:22:34PM -0500, Stephen Gallagher wrote:
This patch will need to be updated with the automatic ticket renewal patch (change to sss_hash_create)
Also: cc1: warnings being treated as errors ../src/providers/krb5/krb5_wait_queue.c: In function 'check_wait_queue': ../src/providers/krb5/krb5_wait_queue.c:171:17: error: 'return' with a value, in function returning void cc1: warnings being treated as errors ../src/providers/krb5/krb5_wait_queue.c: In function 'check_wait_queue': ../src/providers/krb5/krb5_wait_queue.c:171:17: error: 'return' with a value, in function returning void make[1]: *** [src/providers/krb5/libsss_krb5_la-krb5_wait_queue.lo] Error 1
Otherwise, the patch looks good to me.
New patch attached.
Ack.
- -- Stephen Gallagher RHCE 804006346421761
Delivering value year after year. Red Hat ranks #1 in value among software vendors. http://www.redhat.com/promo/vendor/
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 12/20/2010 09:31 AM, Stephen Gallagher wrote:
On 12/20/2010 06:18 AM, Sumit Bose wrote:
On Fri, Dec 17, 2010 at 04:22:34PM -0500, Stephen Gallagher wrote:
This patch will need to be updated with the automatic ticket renewal patch (change to sss_hash_create)
Also: cc1: warnings being treated as errors ../src/providers/krb5/krb5_wait_queue.c: In function 'check_wait_queue': ../src/providers/krb5/krb5_wait_queue.c:171:17: error: 'return' with a value, in function returning void cc1: warnings being treated as errors ../src/providers/krb5/krb5_wait_queue.c: In function 'check_wait_queue': ../src/providers/krb5/krb5_wait_queue.c:171:17: error: 'return' with a value, in function returning void make[1]: *** [src/providers/krb5/libsss_krb5_la-krb5_wait_queue.lo] Error 1
Otherwise, the patch looks good to me.
New patch attached.
Ack.
Pushed to master.
- -- Stephen Gallagher RHCE 804006346421761
Delivering value year after year. Red Hat ranks #1 in value among software vendors. http://www.redhat.com/promo/vendor/
sssd-devel@lists.fedorahosted.org
-
Stephen Gallagher -
Sumit Bose