[sssd PR#526][opened] SSS_PYTHON: Use PyUnicode_FromString() with py3 code

[fidencio]

URL: https://github.com/SSSD/sssd/pull/526
Author: fidencio
 Title: #526: SSS_PYTHON: Use PyUnicode_FromString() with py3 code
Action: opened

PR body:
"""
As PyString_FromString() is not available in python3 aymore, let's
use PyUnicode_FromString() with py3 code.

Resolves:
https://pagure.io/SSSD/sssd/issue/3653

Signed-off-by: Fabiano Fidêncio 
"""

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/526/head:pr526
git checkout pr526

[sssd PR#526][comment] SSS_PYTHON: Use PyUnicode_FromString() with py3 code

[lslebodn]

URL: https://github.com/SSSD/sssd/pull/526
Title: #526: SSS_PYTHON: Use PyUnicode_FromString() with py3 code

lslebodn commented:
"""
On (01/03/18 16:27), fidencio wrote:
> fidencio commented on this pull request.
> >      docobj = PyString_FromString(doc);
>
> +#endif
>
> @lslebodn, this is a valid issue but not related to this patch.
> Please, would you mind opening a ticket for it? If you don't have the time, let me know and I will open the ticket and assign it to myself.

I am so sorry if I overlook something but title of this pull request is:
**SSS_PYTHON: Use PyUnicode_FromString() with py3 code**

And this code should be used only with python2.6 and
never with python2.7 or python3. Because python2.7+ already have
`PyErr_NewExceptionWithDoc` and we needn't use alternative
implementation.

In another words, we are adding almost dead code for python3.
Or would you be so kind and could you explain what did I miss?

LS

"""

See the full comment at https://github.com/SSSD/sssd/pull/526#issuecomment-369655636

[sssd PR#526][comment] SSS_PYTHON: Use PyUnicode_FromString() with py3 code

[fidencio]

URL: https://github.com/SSSD/sssd/pull/526
Title: #526: SSS_PYTHON: Use PyUnicode_FromString() with py3 code

fidencio commented:
"""
@lslebodn, I'm sorry I totally didn't get your first message right.

You're right, about the problem and about the solution. As you also commented in the issue, I'm closing this ticket as it's for sure **not** the right solution.

Thanks for the review.
"""

See the full comment at https://github.com/SSSD/sssd/pull/526#issuecomment-369730923

[sssd PR#526][comment] SSS_PYTHON: Use PyUnicode_FromString() with py3 code

[fidencio]

URL: https://github.com/SSSD/sssd/pull/526
Title: #526: SSS_PYTHON: Use PyUnicode_FromString() with py3 code

fidencio commented:
"""
@lslebodn, I'm sorry I totally didn't get your first message right.

You're right, about the problem and about the solution. As you also commented in the issue, I'm closing this PR as it's for sure **not** the right solution.

Thanks for the review.
"""

See the full comment at https://github.com/SSSD/sssd/pull/526#issuecomment-369730923

[sssd PR#526][closed] SSS_PYTHON: Use PyUnicode_FromString() with py3 code

[fidencio]

URL: https://github.com/SSSD/sssd/pull/526
Author: fidencio
 Title: #526: SSS_PYTHON: Use PyUnicode_FromString() with py3 code
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/526/head:pr526
git checkout pr526

[sssd PR#526][+Rejected] SSS_PYTHON: Use PyUnicode_FromString() with py3 code

[fidencio]

URL: https://github.com/SSSD/sssd/pull/526
Title: #526: SSS_PYTHON: Use PyUnicode_FromString() with py3 code

Label: +Rejected