[sssd PR#592][opened] too complex if-else structure in sss_dp_get_account_msg

[amitkumar50]

   URL: https://github.com/SSSD/sssd/pull/592
Author: amitkumar50
 Title: #592: too complex if-else structure in sss_dp_get_account_msg
Action: opened

PR body:
"""
The structure of if-else statements in sss_dp_get_account_msg
become too complex. Replacing if-else with switch initially,
Will investigate more on refactoring further.

Resolves: https://pagure.io/SSSD/sssd/issue/1903
"""

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/592/head:pr592
git checkout pr592

[sssd PR#592][comment] too complex if-else structure in sss_dp_get_account_msg

[centos-ci]

  URL: https://github.com/SSSD/sssd/pull/592
Title: #592: too complex if-else structure in sss_dp_get_account_msg

centos-ci commented:
"""
Can one of the admins verify this patch?
"""

See the full comment at https://github.com/SSSD/sssd/pull/592#issuecomment-394949267

[sssd PR#592][comment] too complex if-else structure in sss_dp_get_account_msg

[centos-ci]

  URL: https://github.com/SSSD/sssd/pull/592
Title: #592: too complex if-else structure in sss_dp_get_account_msg

centos-ci commented:
"""
Can one of the admins verify this patch?
"""

See the full comment at https://github.com/SSSD/sssd/pull/592#issuecomment-394949266

[sssd PR#592][comment] too complex if-else structure in sss_dp_get_account_msg

[fidencio]

  URL: https://github.com/SSSD/sssd/pull/592
Title: #592: too complex if-else structure in sss_dp_get_account_msg

fidencio commented:
"""
ok to test
"""

See the full comment at https://github.com/SSSD/sssd/pull/592#issuecomment-394950085

[sssd PR#592][comment] too complex if-else structure in sss_dp_get_account_msg

[fidencio]

  URL: https://github.com/SSSD/sssd/pull/592
Title: #592: too complex if-else structure in sss_dp_get_account_msg

fidencio commented:
"""
I like this patch! I makes things easier to read, IMO.
"""

See the full comment at https://github.com/SSSD/sssd/pull/592#issuecomment-394950119

[sssd PR#592][comment] too complex if-else structure in sss_dp_get_account_msg

[fidencio]

  URL: https://github.com/SSSD/sssd/pull/592
Title: #592: too complex if-else structure in sss_dp_get_account_msg

fidencio commented:
"""
I like this patch! It makes things easier to read, IMO.
"""

See the full comment at https://github.com/SSSD/sssd/pull/592#issuecomment-394950119

[sssd PR#592][+Changes requested] too complex if-else structure in sss_dp_get_account_msg

[fidencio]

  URL: https://github.com/SSSD/sssd/pull/592
Title: #592: too complex if-else structure in sss_dp_get_account_msg

Label: +Changes requested

[sssd PR#592][synchronized] too complex if-else structure in sss_dp_get_account_msg

[amitkumar50]

   URL: https://github.com/SSSD/sssd/pull/592
Author: amitkumar50
 Title: #592: too complex if-else structure in sss_dp_get_account_msg
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/592/head:pr592
git checkout pr592

[sssd PR#592][comment] too complex if-else structure in sss_dp_get_account_msg

[fidencio]

  URL: https://github.com/SSSD/sssd/pull/592
Title: #592: too complex if-else structure in sss_dp_get_account_msg

fidencio commented:
"""
Removing the "Changes Requested" label as Amit updated the patchset.
"""

See the full comment at https://github.com/SSSD/sssd/pull/592#issuecomment-394988415

[sssd PR#592][-Changes requested] too complex if-else structure in sss_dp_get_account_msg

[fidencio]

  URL: https://github.com/SSSD/sssd/pull/592
Title: #592: too complex if-else structure in sss_dp_get_account_msg

Label: -Changes requested

[sssd PR#592][comment] too complex if-else structure in sss_dp_get_account_msg

[fidencio]

  URL: https://github.com/SSSD/sssd/pull/592
Title: #592: too complex if-else structure in sss_dp_get_account_msg

fidencio commented:
"""
Patch is fine, CI has passed:  http://vm-031.${abc}/logs/job/90/14/summary.html

@amitkumar50, I'd like to ask you whether you're familiar with the commit template
that we follow in the project. It can be seen here:
https://github.com/SSSD/sssd/blob/master/.git-commit-template

So, for this patch, it should be in the following format:
```
responder: simplify if-else structure in sss_dp_get_account_msg()

The structure of if-else statements in sss_dp_get_account_msg
become too complex. Replacing if-else with switch initially,
Will investigate more on refactoring further.

Resolves:
https://pagure.io/SSSD/sssd/issue/1903
```
Personally, I wouldn't bother you to submit the patch again fixing those things.
I'd rather fix it myself and push the patch, as long as you agree with the
modifications.

But I'm leaving it up to you. Please, just let me know what you think that would be
the best/faster way for you.

And thanks for the contribution!
"""

See the full comment at https://github.com/SSSD/sssd/pull/592#issuecomment-395427169

[sssd PR#592][synchronized] too complex if-else structure in sss_dp_get_account_msg

[amitkumar50]

   URL: https://github.com/SSSD/sssd/pull/592
Author: amitkumar50
 Title: #592: too complex if-else structure in sss_dp_get_account_msg
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/592/head:pr592
git checkout pr592

[sssd PR#592][comment] too complex if-else structure in sss_dp_get_account_msg

[amitkumar50]

  URL: https://github.com/SSSD/sssd/pull/592
Title: #592: too complex if-else structure in sss_dp_get_account_msg

amitkumar50 commented:
"""
@fidencio Apologies Yes I know about template. I submit PR with template most time.
Skipped this time. Will remember.

> And thanks for the contribution!
>  
Pleasure is always mine.
"""

See the full comment at https://github.com/SSSD/sssd/pull/592#issuecomment-395686853

[sssd PR#592][edited] Responder: simplify if-else structure in sss_dp_get_account_msg()

[amitkumar50]

   URL: https://github.com/SSSD/sssd/pull/592
Author: amitkumar50
 Title: #592: Responder: simplify if-else structure in sss_dp_get_account_msg()
Action: edited

 Changed field: title
Original value:
"""
too complex if-else structure in sss_dp_get_account_msg
"""

[sssd PR#592][comment] Responder: simplify if-else structure in sss_dp_get_account_msg()

[fidencio]

  URL: https://github.com/SSSD/sssd/pull/592
Title: #592: Responder: simplify if-else structure in sss_dp_get_account_msg()

fidencio commented:
"""
Ack!
"""

See the full comment at https://github.com/SSSD/sssd/pull/592#issuecomment-395706268

[sssd PR#592][+Accepted] Responder: simplify if-else structure in sss_dp_get_account_msg()

[fidencio]

  URL: https://github.com/SSSD/sssd/pull/592
Title: #592: Responder: simplify if-else structure in sss_dp_get_account_msg()

Label: +Accepted

[sssd PR#592][comment] Responder: simplify if-else structure in sss_dp_get_account_msg()

[fidencio]

  URL: https://github.com/SSSD/sssd/pull/592
Title: #592: Responder: simplify if-else structure in sss_dp_get_account_msg()

fidencio commented:
"""
@jhrozek, although this one is ack'ed, I don't see a reason why it should be
merged *before* the release.

So, please, if you agree, let's merged it next week.
"""

See the full comment at https://github.com/SSSD/sssd/pull/592#issuecomment-395706477

[sssd PR#592][+Pushed] Responder: simplify if-else structure in sss_dp_get_account_msg()

[fidencio]

  URL: https://github.com/SSSD/sssd/pull/592
Title: #592: Responder: simplify if-else structure in sss_dp_get_account_msg()

Label: +Pushed

[sssd PR#592][-Accepted] Responder: simplify if-else structure in sss_dp_get_account_msg()

[fidencio]

  URL: https://github.com/SSSD/sssd/pull/592
Title: #592: Responder: simplify if-else structure in sss_dp_get_account_msg()

Label: -Accepted

[sssd PR#592][comment] Responder: simplify if-else structure in sss_dp_get_account_msg()

[fidencio]

  URL: https://github.com/SSSD/sssd/pull/592
Title: #592: Responder: simplify if-else structure in sss_dp_get_account_msg()

fidencio commented:
"""
master:
 1038473
"""

See the full comment at https://github.com/SSSD/sssd/pull/592#issuecomment-397391372

[sssd PR#592][closed] Responder: simplify if-else structure in sss_dp_get_account_msg()

[fidencio]

   URL: https://github.com/SSSD/sssd/pull/592
Author: amitkumar50
 Title: #592: Responder: simplify if-else structure in sss_dp_get_account_msg()
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/592/head:pr592
git checkout pr592