[sssd PR#518][opened] PYSSS_MURMUR: Fix [-Wsign-compare] found by gcc

[fidencio]

   URL: https://github.com/SSSD/sssd/pull/518
Author: fidencio
 Title: #518: PYSSS_MURMUR: Fix [-Wsign-compare] found by gcc
Action: opened

PR body:
"""
While building the project I've noticed the following warning:
../src/python/pysss_murmur.c: In function ‘py_murmurhash3’:
../src/python/pysss_murmur.c:50:25: warning: comparison between signed and unsigned
integer expressions [-Wsign-compare]
         (size_t)key_len > input_len) {
                         ^

Previously we were comparing key_len(long) with the output of strlen(key)
(size_t), thus the (size_t) cast.

Currently, we can jut compare key_len with input_len without issues and
without the needed to the cast.

Issue has been introduced as part of 41454a64c7.

Signed-off-by: Fabiano Fidêncio <fidencio(a)redhat.com&gt;
"""

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/518/head:pr518
git checkout pr518

[sssd PR#518][comment] PYSSS_MURMUR: Fix [-Wsign-compare] found by gcc

[fidencio]

  URL: https://github.com/SSSD/sssd/pull/518
Title: #518: PYSSS_MURMUR: Fix [-Wsign-compare] found by gcc

fidencio commented:
"""
As the patches which introduced the warning have been backported to 1-13 and 1-14 branch,
this patch (or the version of this patch that will end up accepted) will also have to be
backported.
"""

See the full comment at https://github.com/SSSD/sssd/pull/518#issuecomment-366231410

[sssd PR#518][comment] PYSSS_MURMUR: Fix [-Wsign-compare] found by gcc

[lslebodn]

  URL: https://github.com/SSSD/sssd/pull/518
Title: #518: PYSSS_MURMUR: Fix [-Wsign-compare] found by gcc

lslebodn commented:
"""
ACK

"""

See the full comment at https://github.com/SSSD/sssd/pull/518#issuecomment-366244091

[sssd PR#518][+Accepted] PYSSS_MURMUR: Fix [-Wsign-compare] found by gcc

[lslebodn]

  URL: https://github.com/SSSD/sssd/pull/518
Title: #518: PYSSS_MURMUR: Fix [-Wsign-compare] found by gcc

Label: +Accepted

[sssd PR#518][comment] PYSSS_MURMUR: Fix [-Wsign-compare] found by gcc

[lslebodn]

  URL: https://github.com/SSSD/sssd/pull/518
Title: #518: PYSSS_MURMUR: Fix [-Wsign-compare] found by gcc

lslebodn commented:
"""
master:
* 1c42c3962577ea4b2d9ed6a8a07179d33756b3b4
"""

See the full comment at https://github.com/SSSD/sssd/pull/518#issuecomment-366244837

[sssd PR#518][closed] PYSSS_MURMUR: Fix [-Wsign-compare] found by gcc

[lslebodn]

   URL: https://github.com/SSSD/sssd/pull/518
Author: fidencio
 Title: #518: PYSSS_MURMUR: Fix [-Wsign-compare] found by gcc
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/518/head:pr518
git checkout pr518

[sssd PR#518][+Pushed] PYSSS_MURMUR: Fix [-Wsign-compare] found by gcc

[lslebodn]

  URL: https://github.com/SSSD/sssd/pull/518
Title: #518: PYSSS_MURMUR: Fix [-Wsign-compare] found by gcc

Label: +Pushed

[sssd PR#518][comment] PYSSS_MURMUR: Fix [-Wsign-compare] found by gcc

[fidencio]

  URL: https://github.com/SSSD/sssd/pull/518
Title: #518: PYSSS_MURMUR: Fix [-Wsign-compare] found by gcc

fidencio commented:
"""
Just for the record, the comment
https://github.com/SSSD/sssd/pull/518#issuecomment-366231410 is not accurate as the
versions backported already contained the change proposed by this patch.
"""

See the full comment at https://github.com/SSSD/sssd/pull/518#issuecomment-366260845