[sssd PR#901][opened] Update sss_ssh.c

[alexal]

URL: https://github.com/SSSD/sssd/pull/901
Author: alexal
 Title: #901: Update sss_ssh.c
Action: opened

PR body:
"""
SSH: Adds a message to the syslog if an SSH key is malformed

If an SSH key contains trailing whitespace (or newlines), it will be considered as malformed by sss_ssh_format_pubkey() function. With the current version the only way to detect that problem is to enable --debug option for /usr/bin/sss_ssh_authorizedkeys utility. I'm adding an additional message to the syslog which will help to determine such problems without enabling debug.

Resolves: https://pagure.io/SSSD/sssd/issue/3864
"""

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/901/head:pr901
git checkout pr901

[sssd PR#901][comment] Update sss_ssh.c

[centos-ci]

URL: https://github.com/SSSD/sssd/pull/901
Title: #901: Update sss_ssh.c

centos-ci commented:
"""
Can one of the admins verify this patch?
"""

See the full comment at https://github.com/SSSD/sssd/pull/901#issuecomment-541858825

[sssd PR#901][comment] Update sss_ssh.c

[alexal]

URL: https://github.com/SSSD/sssd/pull/901
Title: #901: Update sss_ssh.c

alexal commented:
"""
Here is a message from journalctl:
> Oct 14 18:43:31 fedora.novalocal /usr/bin/sss_ssh_authorizedkeys[32700]: SSH key is malformed: Invalid argument

"""

See the full comment at https://github.com/SSSD/sssd/pull/901#issuecomment-541859192

[sssd PR#901][comment] Update sss_ssh.c

[alexey-tikhonov]

URL: https://github.com/SSSD/sssd/pull/901
Title: #901: Update sss_ssh.c

alexey-tikhonov commented:
"""
ok to test
"""

See the full comment at https://github.com/SSSD/sssd/pull/901#issuecomment-542101243

[sssd PR#901][comment] Update sss_ssh.c

[mzidek-rh]

URL: https://github.com/SSSD/sssd/pull/901
Title: #901: Update sss_ssh.c

mzidek-rh commented:
"""
This patch looks OK. I will test it and ack if it will work (do not see why it should not, but you never know :) ). I plan to resolve this today.
"""

See the full comment at https://github.com/SSSD/sssd/pull/901#issuecomment-542613213

[sssd PR#901][+Accepted] Update sss_ssh.c

[mzidek-rh]

URL: https://github.com/SSSD/sssd/pull/901
Title: #901: Update sss_ssh.c

Label: +Accepted

[sssd PR#901][comment] Update sss_ssh.c

[mzidek-rh]

URL: https://github.com/SSSD/sssd/pull/901
Title: #901: Update sss_ssh.c

mzidek-rh commented:
"""
ACK.
"""

See the full comment at https://github.com/SSSD/sssd/pull/901#issuecomment-542743625

[sssd PR#901][+Ready to push] Update sss_ssh.c

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/901
Title: #901: Update sss_ssh.c

Label: +Ready to push

[sssd PR#901][comment] Update sss_ssh.c

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/901
Title: #901: Update sss_ssh.c

pbrezina commented:
"""
* `master`
    * 111144cdbbf7c1e6bf69f4b6d55d98f948dbace9 - Update sss_ssh.c

"""

See the full comment at https://github.com/SSSD/sssd/pull/901#issuecomment-543172856

[sssd PR#901][+Pushed] Update sss_ssh.c

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/901
Title: #901: Update sss_ssh.c

Label: +Pushed

[sssd PR#901][-Accepted] Update sss_ssh.c

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/901
Title: #901: Update sss_ssh.c

Label: -Accepted

[sssd PR#901][-Ready to push] Update sss_ssh.c

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/901
Title: #901: Update sss_ssh.c

Label: -Ready to push

[sssd PR#901][closed] Update sss_ssh.c

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/901
Author: alexal
 Title: #901: Update sss_ssh.c
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/901/head:pr901
git checkout pr901