6:13 a.m.
URL: https://github.com/SSSD/sssd/pull/325
Author: amitkumar50
Title: #325: MAN: Improve description of 'trusted domain section' in
sssd.conf's man page
Action: opened
PR body:
"""
PR generated to include explaination for ipa ad trust sssd configuration where ad has a
child domain. Explanation is added to 'TRUSTED DOMAIN SECTION'. Also an example is
included to better understanding.
Resolves: https://pagure.io/SSSD/sssd/issue/3399
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/325/head:pr325
git checkout pr325
6:14 a.m.
New subject: [sssd PR#325][comment] MAN: Improve description of 'trusted domain section' in sssd.conf's man page
URL: https://github.com/SSSD/sssd/pull/325
Title: #325: MAN: Improve description of 'trusted domain section' in
sssd.conf's man page
centos-ci commented:
"""
Can one of the admins verify this patch?
"""
See the full comment at https://github.com/SSSD/sssd/pull/325#issuecomment-316032911
6:14 a.m.
New subject: [sssd PR#325][comment] MAN: Improve description of 'trusted domain section' in sssd.conf's man page
URL: https://github.com/SSSD/sssd/pull/325
Title: #325: MAN: Improve description of 'trusted domain section' in
sssd.conf's man page
centos-ci commented:
"""
Can one of the admins verify this patch?
"""
See the full comment at https://github.com/SSSD/sssd/pull/325#issuecomment-316032916
6:24 a.m.
New subject: [sssd PR#325][comment] MAN: Improve description of 'trusted domain section' in sssd.conf's man page
URL: https://github.com/SSSD/sssd/pull/325
Title: #325: MAN: Improve description of 'trusted domain section' in
sssd.conf's man page
fidencio commented:
"""
ok to test
"""
See the full comment at https://github.com/SSSD/sssd/pull/325#issuecomment-316035098
4:44 p.m.
New subject: [sssd PR#325][comment] MAN: Improve description of 'trusted domain section' in sssd.conf's man page
URL: https://github.com/SSSD/sssd/pull/325
Title: #325: MAN: Improve description of 'trusted domain section' in
sssd.conf's man page
fidencio commented:
"""
I'm adding "Changes Requested" label as per my review.
"""
See the full comment at https://github.com/SSSD/sssd/pull/325#issuecomment-318495236
4:45 p.m.
New subject: [sssd PR#325][+Changes requested] MAN: Improve description of 'trusted domain section' in sssd.conf's man page
URL: https://github.com/SSSD/sssd/pull/325
Title: #325: MAN: Improve description of 'trusted domain section' in
sssd.conf's man page
Label: +Changes requested
7:25 a.m.
New subject: [sssd PR#325][synchronized] MAN: Improve description of 'trusted domain section' in sssd.conf's man page
URL: https://github.com/SSSD/sssd/pull/325
Author: amitkumar50
Title: #325: MAN: Improve description of 'trusted domain section' in
sssd.conf's man page
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/325/head:pr325
git checkout pr325
3:39 a.m.
New subject: [sssd PR#325][-Changes requested] MAN: Improve description of 'trusted domain section' in sssd.conf's man page
URL: https://github.com/SSSD/sssd/pull/325
Title: #325: MAN: Improve description of 'trusted domain section' in
sssd.conf's man page
Label: -Changes requested
2:28 p.m.
New subject: [sssd PR#325][+Changes requested] MAN: Improve description of 'trusted domain section' in sssd.conf's man page
URL: https://github.com/SSSD/sssd/pull/325
Title: #325: MAN: Improve description of 'trusted domain section' in
sssd.conf's man page
Label: +Changes requested
7:59 a.m.
New subject: [sssd PR#325][synchronized] MAN: Improve description of 'trusted domain section' in sssd.conf's man page
URL: https://github.com/SSSD/sssd/pull/325
Author: amitkumar50
Title: #325: MAN: Improve description of 'trusted domain section' in
sssd.conf's man page
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/325/head:pr325
git checkout pr325
8 a.m.
New subject: [sssd PR#325][comment] MAN: Improve description of 'trusted domain section' in sssd.conf's man page
URL: https://github.com/SSSD/sssd/pull/325
Title: #325: MAN: Improve description of 'trusted domain section' in
sssd.conf's man page
amitkumar50 commented:
"""
@jhrozek Thanks for comment. Done changes in 3rd patch.
Please review. Once ok. I will rebase these.
"""
See the full comment at https://github.com/SSSD/sssd/pull/325#issuecomment-325982558
8:16 a.m.
New subject: [sssd PR#325][comment] MAN: Improve description of 'trusted domain section' in sssd.conf's man page
URL: https://github.com/SSSD/sssd/pull/325
Title: #325: MAN: Improve description of 'trusted domain section' in
sssd.conf's man page
jhrozek commented:
"""
I would say "in *the* child domain", but otherwise LGTM, thank you.
"""
See the full comment at https://github.com/SSSD/sssd/pull/325#issuecomment-325986773
10:30 a.m.
New subject: [sssd PR#325][-Changes requested] MAN: Improve description of 'trusted domain section' in sssd.conf's man page
URL: https://github.com/SSSD/sssd/pull/325
Title: #325: MAN: Improve description of 'trusted domain section' in
sssd.conf's man page
Label: -Changes requested
10:30 a.m.
New subject: [sssd PR#325][+Accepted] MAN: Improve description of 'trusted domain section' in sssd.conf's man page
URL: https://github.com/SSSD/sssd/pull/325
Title: #325: MAN: Improve description of 'trusted domain section' in
sssd.conf's man page
Label: +Accepted
10:32 a.m.
New subject: [sssd PR#325][synchronized] MAN: Improve description of 'trusted domain section' in sssd.conf's man page
URL: https://github.com/SSSD/sssd/pull/325
Author: amitkumar50
Title: #325: MAN: Improve description of 'trusted domain section' in
sssd.conf's man page
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/325/head:pr325
git checkout pr325
10:33 a.m.
New subject: [sssd PR#325][comment] MAN: Improve description of 'trusted domain section' in sssd.conf's man page
URL: https://github.com/SSSD/sssd/pull/325
Title: #325: MAN: Improve description of 'trusted domain section' in
sssd.conf's man page
jhrozek commented:
"""
I force-pushed to @amitkumar50 branch and added the Approved tag. The only changes I did
was added a missing "the" and removed tabs in favor of spaces at two lines.
I'll push later if nobody objects.
"""
See the full comment at https://github.com/SSSD/sssd/pull/325#issuecomment-326988892
4:19 a.m.
New subject: [sssd PR#325][closed] MAN: Improve description of 'trusted domain section' in sssd.conf's man page
URL: https://github.com/SSSD/sssd/pull/325
Author: amitkumar50
Title: #325: MAN: Improve description of 'trusted domain section' in
sssd.conf's man page
Action: closed
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/325/head:pr325
git checkout pr325
4:19 a.m.
New subject: [sssd PR#325][comment] MAN: Improve description of 'trusted domain section' in sssd.conf's man page
URL: https://github.com/SSSD/sssd/pull/325
Title: #325: MAN: Improve description of 'trusted domain section' in
sssd.conf's man page
jhrozek commented:
"""
* master: 781d231a12eb0c772353cc15e2c3ae1e7545e663
"""
See the full comment at https://github.com/SSSD/sssd/pull/325#issuecomment-327120140
4:19 a.m.
New subject: [sssd PR#325][+Pushed] MAN: Improve description of 'trusted domain section' in sssd.conf's man page
URL: https://github.com/SSSD/sssd/pull/325
Title: #325: MAN: Improve description of 'trusted domain section' in
sssd.conf's man page
Label: +Pushed
2418
days inactive
2467
days old
sssd-devel@lists.fedorahosted.org
18 comments
4 participants
participants (4)
-
amitkumar50 -
centos-ci
-
fidencio
-
jhrozek