Patch for pysss.c : getgrouplist

[Martin Karto Andersen]

Hello,

I had a chat with lslebodn in #sssd and here is my patch.
It’s a fix for pysss getgrouplist return test, thats different between
linux and freebsd.
The fix if for this code:
https://git.fedorahosted.org/cgit/sssd.git/tree/src/python/pysss.c#n783
I discovered the bug because salt-minion stalls when calling
pysss.getgrouplist.

Best regards,
Martin Andersen

[Jakub Hrozek]

On Tue, Jun 23, 2015 at 03:45:26PM +0200, Martin Karto Andersen wrote:
> Hello,
>
> I had a chat with lslebodn in #sssd and here is my patch.
> It’s a fix for pysss getgrouplist return test, thats different between
> linux and freebsd.
> The fix if for this code:
> https://git.fedorahosted.org/cgit/sssd.git/tree/src/python/pysss.c#n783
> I discovered the bug because salt-minion stalls when calling
> pysss.getgrouplist.

Hi,

thanks for the patch!

Could you please send it in the "git format-patch" format?

I also wonder what do you use pysss for? To be honest, I was considering
removing it from SSSD, I'm really suprised someone uses it (and also a
bit surprised it works).

Not related to your patch, but we should stop using malloc/realloc and
start using talloc/talloc_realloc in pysss..

[Lukas Slebodnik]

On (24/06/15 10:59), Jakub Hrozek wrote:
> On Tue, Jun 23, 2015 at 03:45:26PM +0200, Martin Karto Andersen wrote:
> > Hello,
> >
> > I had a chat with lslebodn in #sssd and here is my patch.
> > It’s a fix for pysss getgrouplist return test, thats different between
> > linux and freebsd.
> > The fix if for this code:
> > https://git.fedorahosted.org/cgit/sssd.git/tree/src/python/pysss.c#n783
> > I discovered the bug because salt-minion stalls when calling
> > pysss.getgrouplist.
>
> Hi,
>
> thanks for the patch!
>
> Could you please send it in the "git format-patch" format?
>
> I also wonder what do you use pysss for? To be honest, I was considering
> removing it from SSSD, I'm really suprised someone uses it (and also a
> bit surprised it works).

python module pysss contains 2 classes and on function:
sss.local -- SSS local DB manipulation
sss.password -- SSS password obfuscation
sss.getgrouplist -- Get list of groups user belongs to.

The patch touches the function sss.getgrouplist.

LS

[Jakub Hrozek]

On Wed, Jun 24, 2015 at 04:15:27PM +0200, Lukas Slebodnik wrote:
> On (24/06/15 10:59), Jakub Hrozek wrote:
> > On Tue, Jun 23, 2015 at 03:45:26PM +0200, Martin Karto Andersen wrote:
> > > Hello,
> > >
> > > I had a chat with lslebodn in #sssd and here is my patch.
> > > It’s a fix for pysss getgrouplist return test, thats different between
> > > linux and freebsd.
> > > The fix if for this code:
> > > https://git.fedorahosted.org/cgit/sssd.git/tree/src/python/pysss.c#n783
> > > I discovered the bug because salt-minion stalls when calling
> > > pysss.getgrouplist.
> >
> > Hi,
> >
> > thanks for the patch!
> >
> > Could you please send it in the "git format-patch" format?
> >
> > I also wonder what do you use pysss for? To be honest, I was considering
> > removing it from SSSD, I'm really suprised someone uses it (and also a
> > bit surprised it works).
>
> python module pysss contains 2 classes and on function:
> sss.local -- SSS local DB manipulation

OK, it's sss.local I was thinking of removing
> sss.password -- SSS password obfuscation
> sss.getgrouplist -- Get list of groups user belongs to.

These two are still needed.