[PATCH] Fix segfault when using SSS tools with no local provider

[Stephen Gallagher]

There was a double-free here. I removed the free()s within
setup_db, because upon returning to sss_init_tools(), if
ret != EOK, the context is freed as well.

-- 
Stephen Gallagher
RHCE 804006346421761

Looking to carve out IT costs?
www.redhat.com/carveoutcosts/

[Simo Sorce]

On Fri, 2009-10-16 at 10:57 -0400, Stephen Gallagher wrote:
>  There was a double-free here. I removed the free()s within
>  setup_db, because upon returning to sss_init_tools(), if
>  ret != EOK, the context is freed as well. 
ACK

we should *never* free a context that is passed to us, unless we are a
"termination" function. Only the allocating function should free
contexts.

Simo.

-- 
Simo Sorce * Red Hat, Inc * New York

[Stephen Gallagher]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 10/16/2009 01:40 PM, Simo Sorce wrote:
>  On Fri, 2009-10-16 at 10:57 -0400, Stephen Gallagher wrote:
> > There was a double-free here. I removed the free()s within
> > setup_db, because upon returning to sss_init_tools(), if
> > ret != EOK, the context is freed as well.
>  
>  ACK
>  
>  we should *never* free a context that is passed to us, unless we are a
>  "termination" function. Only the allocating function should free
>  contexts.
>  
>  Simo.
>   
Pushed to master.

- -- 
Stephen Gallagher
RHCE 804006346421761

Looking to carve out IT costs?
www.redhat.com/carveoutcosts/
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.9 (GNU/Linux)
> Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
>
> iEYEARECAAYFAkrYu00ACgkQeiVVYja6o6NUCgCeOH7Jo2TADLStx6DMQ+38HJxZ
> dfwAnArQYq8kAlinUuZf9Z49meO3atjy
> =4Ls6
> -----END PGP SIGNATURE-----