Hi,
the attached patches fix https://fedorahosted.org/sssd/ticket/2571 for me.
Sumit was kind to provide first round of review comments on IRC. I hope I managed to implement them all. Feel free to suggest even better name for the new async request.
On Fri, Jan 30, 2015 at 11:33:42AM +0100, Jakub Hrozek wrote:
Hi,
the attached patches fix https://fedorahosted.org/sssd/ticket/2571 for me.
Sumit was kind to provide first round of review comments on IRC. I hope I managed to implement them all. Feel free to suggest even better name for the new async request.
test builds and works fine and all my concerns were addressed, so ACK. (It would nice is someone else can start the CI because I have to run for some errand).
bye, Sumit
On Fri, Jan 30, 2015 at 12:23:56PM +0100, Sumit Bose wrote:
On Fri, Jan 30, 2015 at 11:33:42AM +0100, Jakub Hrozek wrote:
Hi,
the attached patches fix https://fedorahosted.org/sssd/ticket/2571 for me.
Sumit was kind to provide first round of review comments on IRC. I hope I managed to implement them all. Feel free to suggest even better name for the new async request.
test builds and works fine and all my concerns were addressed, so ACK. (It would nice is someone else can start the CI because I have to run for some errand).
bye, Sumit
Here are the CI results: http://sssd-ci.duckdns.org/logs/commit/b5/21f8346594d14314cda1d2d121b5c1edac...
On rawhide, the dyndns test failed, but that's completely unrelated. Also the dyndns-test is known to be flaky.
I pushed the patches to master: * b2c3722b9a1eaf265f6b102043958f6d4378788c * 108db0e3b9e06e530364ef8228634f5e3f6bd3b5 and sssd-1-12: * d18bd28fb09f104e2b13382c430247cad731f867 * 74d708790a202b78242bd2951178f0a2483327be
sssd-devel@lists.fedorahosted.org