[PATCH] Save alias of the service primary name, too

[Jakub Hrozek]

After the recent changes to sysdb_attrs_get_aliases() we stopped saving
the lowercased alias of the primary name.

Services are a different beast than the rest of the entries, because
with everything else the nss responder only uses the alias to match the
entry. With services, we also need to print the aliases.

The attached patch changes the behaviour so that all aliases are saved
lowercased in an insensitive domain, including the primary name, but
when returning the service, the alias that matches the primary name is
filtered out. Because all aliases are lowercased now, I also removed the
sss_get_cased_name() call, it is no longer needed.

[Jan Zelený]

>  After the recent changes to sysdb_attrs_get_aliases() we stopped
> saving
>  the lowercased alias of the primary name.
>  
>  Services are a different beast than the rest of the entries, because
>  with everything else the nss responder only uses the alias to match the
>  entry. With services, we also need to print the aliases.
>  
>  The attached patch changes the behaviour so that all aliases are saved
>  lowercased in an insensitive domain, including the primary name, but
>  when returning the service, the alias that matches the primary name is
>  filtered out. Because all aliases are lowercased now, I also removed the
>  sss_get_cased_name() call, it is no longer needed. 
Ack,
code checked, only sanity testing performed.

Thanks
Jan

[Stephen Gallagher]

On Wed, 2012-03-21 at 09:13 +0100, Jan Zelený wrote:
>  > After the recent changes to sysdb_attrs_get_aliases() we stopped
> saving
>  > the lowercased alias of the primary name.
>  > 
>  > Services are a different beast than the rest of the entries, because
>  > with everything else the nss responder only uses the alias to match the
>  > entry. With services, we also need to print the aliases.
>  > 
>  > The attached patch changes the behaviour so that all aliases are saved
>  > lowercased in an insensitive domain, including the primary name, but
>  > when returning the service, the alias that matches the primary name is
>  > filtered out. Because all aliases are lowercased now, I also removed the
>  > sss_get_cased_name() call, it is no longer needed.
>  
>  Ack,
>  code checked, only sanity testing performed. 

Pushed to master and sssd-1-8.