[PATCH] Possible use of NULL pointer in function, sss_mmap_cache_init.

[Michal Židek]

NULL pointer was passed to unlink() if memory allocation
for mc_ctx->file failed.

Patch attached.

Michal

[Stephen Gallagher]

On Wed 26 Sep 2012 12:52:07 PM EDT, Michal Židek wrote:
> NULL pointer was passed to unlink() if memory allocation
> for mc_ctx->file failed.

Nack. We should be checking for the allocation failure and handling 
that earlier.

[Michal Židek]

On 09/26/2012 07:27 PM, Stephen Gallagher wrote:
> On Wed 26 Sep 2012 12:52:07 PM EDT, Michal Židek wrote:
> > NULL pointer was passed to unlink() if memory allocation
> > for mc_ctx->file failed.
>
> Nack. We should be checking for the allocation failure and handling that
> earlier.

Actually, this is part of the clean-up process, when the allocation was 
unsuccessful, but I've checked the code flow, that clang's static 
analysis reported as problematic again and it is impossible to happen, 
so the patch is not needed.

Michal