URL: https://github.com/SSSD/sssd/pull/5910 Author: alexey-tikhonov Title: #5910: SPEC: avoid weak dependencies Action: opened
PR body: """ Require packages if really needed, suggest otherwise.
This is related to https://bugzilla.redhat.com/show_bug.cgi?id=1947918
I'm not sure what to do with: ``` Recommends: bind-utils Recommends: adcli ``` `bind-utils` provides `nsupdate` used by IPA and AD backends, but SSSD can work without it. And `adcli` is used by AD backend to renew machine password. """
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5910/head:pr5910 git checkout pr5910
URL: https://github.com/SSSD/sssd/pull/5910 Title: #5910: SPEC: avoid weak dependencies
sumit-bose commented: """ Hi,
thanks for the patch. The boolean dependencies seem to work as expected, at least on RHEL-8 where I tested them. Please see my in-line comments.
bye, Sumit """
See the full comment at https://github.com/SSSD/sssd/pull/5910#issuecomment-990662858
URL: https://github.com/SSSD/sssd/pull/5910 Title: #5910: SPEC: avoid weak dependencies
Label: +Changes requested
URL: https://github.com/SSSD/sssd/pull/5910 Author: alexey-tikhonov Title: #5910: SPEC: avoid weak dependencies Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5910/head:pr5910 git checkout pr5910
URL: https://github.com/SSSD/sssd/pull/5910 Title: #5910: SPEC: avoid weak dependencies
alexey-tikhonov commented: """
Please see my in-line comments.
Thank you. I updated the patch.
But what do you think about:
I'm not sure what to do with:
Recommends: bind-utils Recommends: adcli
? """
See the full comment at https://github.com/SSSD/sssd/pull/5910#issuecomment-991238201
URL: https://github.com/SSSD/sssd/pull/5910 Title: #5910: SPEC: avoid weak dependencies
alexey-tikhonov commented: """
Please see my in-line comments.
Thank you. I updated the patch.
But what do you think about:
I'm not sure what to do with:
Recommends: bind-utils Recommends: adclibind-utils provides nsupdate used by IPA and AD backends, but SSSD can work without it. And adcli is used by AD backend to renew machine password.
? """
See the full comment at https://github.com/SSSD/sssd/pull/5910#issuecomment-991238201
URL: https://github.com/SSSD/sssd/pull/5910 Title: #5910: SPEC: avoid weak dependencies
Label: -Changes requested
URL: https://github.com/SSSD/sssd/pull/5910 Title: #5910: SPEC: avoid weak dependencies
Label: +Waiting for review
URL: https://github.com/SSSD/sssd/pull/5910 Title: #5910: SPEC: avoid weak dependencies
sumit-bose commented: """
Please see my in-line comments.
Thank you. I updated the patch.
But what do you think about:
I'm not sure what to do with:
Recommends: bind-utils Recommends: adclibind-utils provides nsupdate used by IPA and AD backends, but SSSD can work without it. And adcli is used by AD backend to renew machine password.
?
Hi,
since the related features are enabled in SSSD by default it would be good if the two packages will be installed together with `sssd-ad` or `sssd-ipa`. But since both features can be disabled a user might want to removed those packages if not needed. So `Recommends` would be best.
If I understood the original bugzilla ticket correctly we can keep `Recommends:` because neither `sssd-ad` nor `sssd-ipa` are in the `core` group (only `sssd-common` and `sssd-kcm` are).
HTH
bye, Sumit
"""
See the full comment at https://github.com/SSSD/sssd/pull/5910#issuecomment-992344439
URL: https://github.com/SSSD/sssd/pull/5910 Title: #5910: SPEC: avoid weak dependencies
alexey-tikhonov commented: """
If I understood the original bugzilla ticket correctly we can keep `Recommends:` because neither `sssd-ad` nor `sssd-ipa` are in the `core` group (only `sssd-common` and `sssd-kcm` are).
It says "weak dependencies in BaseOS are allowed, but discouraged" (and sssd-ad/ipa are in BaseOS). But I don't insist. Would you mind accepting this patch then? """
See the full comment at https://github.com/SSSD/sssd/pull/5910#issuecomment-992412667
URL: https://github.com/SSSD/sssd/pull/5910 Title: #5910: SPEC: avoid weak dependencies
sumit-bose commented: """ Hi,
sure, ACK.
bye, Sumit """
See the full comment at https://github.com/SSSD/sssd/pull/5910#issuecomment-992421744
URL: https://github.com/SSSD/sssd/pull/5910 Title: #5910: SPEC: avoid weak dependencies
Label: -Waiting for review
URL: https://github.com/SSSD/sssd/pull/5910 Title: #5910: SPEC: avoid weak dependencies
Label: +Accepted
URL: https://github.com/SSSD/sssd/pull/5910 Title: #5910: SPEC: avoid weak dependencies
Label: +Ready to push
URL: https://github.com/SSSD/sssd/pull/5910 Title: #5910: SPEC: avoid weak dependencies
pbrezina commented: """ Pushed PR: https://github.com/SSSD/sssd/pull/5910
* `master` * 5ee8657c38f4849694bcb3f2ce958012f072ace0 - SPEC: avoid weak dependencies
"""
See the full comment at https://github.com/SSSD/sssd/pull/5910#issuecomment-992788853
URL: https://github.com/SSSD/sssd/pull/5910 Title: #5910: SPEC: avoid weak dependencies
Label: +Pushed
URL: https://github.com/SSSD/sssd/pull/5910 Title: #5910: SPEC: avoid weak dependencies
Label: -Accepted
URL: https://github.com/SSSD/sssd/pull/5910 Title: #5910: SPEC: avoid weak dependencies
Label: -Ready to push
URL: https://github.com/SSSD/sssd/pull/5910 Author: alexey-tikhonov Title: #5910: SPEC: avoid weak dependencies Action: closed
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5910/head:pr5910 git checkout pr5910
sssd-devel@lists.fedorahosted.org
-
alexey-tikhonov -
pbrezina
-
sumit-bose