URL: https://github.com/SSSD/sssd/pull/5516 Author: pbrezina Title: #5516: fix selinux warnings Action: opened
PR body: """ selinux: fix warning ‘matchpathcon’ is deprecated
``` src/util/selinux.c: In function ‘selinux_file_context’: src/util/selinux.c:50:9: error: ‘matchpathcon’ is deprecated: Use selabel_lookup instead [-Werror=deprecated-declarations] 50 | if (matchpathcon(dst_name, 0, &scontext) < 0) { ```
selinux: fix warning ‘security_context_t’ is deprecated
The type is now deprecated, char * should be used instead https://github.com/SELinuxProject/selinux/commit/9eb9c9327563014ad6a807814e7... """
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5516/head:pr5516 git checkout pr5516
URL: https://github.com/SSSD/sssd/pull/5516 Title: #5516: fix selinux warnings
Label: +Changes requested
URL: https://github.com/SSSD/sssd/pull/5516 Author: pbrezina Title: #5516: fix selinux warnings Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5516/head:pr5516 git checkout pr5516
URL: https://github.com/SSSD/sssd/pull/5516 Title: #5516: fix selinux warnings
Label: -Changes requested
URL: https://github.com/SSSD/sssd/pull/5516 Title: #5516: fix selinux warnings
Label: +Accepted
URL: https://github.com/SSSD/sssd/pull/5516 Title: #5516: fix selinux warnings
Label: -Accepted
URL: https://github.com/SSSD/sssd/pull/5516 Title: #5516: fix selinux warnings
Label: +Changes requested
URL: https://github.com/SSSD/sssd/pull/5516 Title: #5516: fix selinux warnings
elkoniu commented: """ As @sumit-bose has some questions I restored "Changes requested" flag. """
See the full comment at https://github.com/SSSD/sssd/pull/5516#issuecomment-793073196
URL: https://github.com/SSSD/sssd/pull/5516 Author: pbrezina Title: #5516: fix selinux warnings Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5516/head:pr5516 git checkout pr5516
URL: https://github.com/SSSD/sssd/pull/5516 Author: pbrezina Title: #5516: fix selinux warnings Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5516/head:pr5516 git checkout pr5516
URL: https://github.com/SSSD/sssd/pull/5516 Title: #5516: fix selinux warnings
pbrezina commented: """ See the new patch set please. """
See the full comment at https://github.com/SSSD/sssd/pull/5516#issuecomment-801003041
URL: https://github.com/SSSD/sssd/pull/5516 Title: #5516: fix selinux warnings
Label: +Waiting for review
URL: https://github.com/SSSD/sssd/pull/5516 Title: #5516: fix selinux warnings
sumit-bose commented: """ Hi,
thanks for the new version, my older comments are resolved. I found some wrong tab-based indentation and some issue with `selabel_close()`, see comments inline.
bye, Sumit """
See the full comment at https://github.com/SSSD/sssd/pull/5516#issuecomment-801787523
URL: https://github.com/SSSD/sssd/pull/5516 Author: pbrezina Title: #5516: fix selinux warnings Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5516/head:pr5516 git checkout pr5516
URL: https://github.com/SSSD/sssd/pull/5516 Title: #5516: fix selinux warnings
pbrezina commented: """ Thank you. Done. """
See the full comment at https://github.com/SSSD/sssd/pull/5516#issuecomment-801797683
URL: https://github.com/SSSD/sssd/pull/5516 Title: #5516: fix selinux warnings
Label: -Changes requested
URL: https://github.com/SSSD/sssd/pull/5516 Title: #5516: fix selinux warnings
sumit-bose commented: """ Hi,
thanks for the update, I have no further comments. ACK.
bye, Sumit """
See the full comment at https://github.com/SSSD/sssd/pull/5516#issuecomment-801831316
URL: https://github.com/SSSD/sssd/pull/5516 Title: #5516: fix selinux warnings
Label: -Waiting for review
URL: https://github.com/SSSD/sssd/pull/5516 Title: #5516: fix selinux warnings
Label: +Accepted
URL: https://github.com/SSSD/sssd/pull/5516 Title: #5516: fix selinux warnings
Label: +Ready to push
URL: https://github.com/SSSD/sssd/pull/5516 Title: #5516: fix selinux warnings
pbrezina commented: """ Pushed PR: https://github.com/SSSD/sssd/pull/5516
* `master` * ecf26727c30a9a5b9adfba0ce6f23572b6f4957a - selinux: make SEC_CTX and SELINUX_CTX typedef instead of macro * 3fba29f98069960ab9c2684a925e258b1003a9ae - selinux: fix warning ‘matchpathcon’ is deprecated * c796088ea9cade211f65ac202416691ad2be6349 - selinux: fix warning ‘security_context_t’ is deprecated
"""
See the full comment at https://github.com/SSSD/sssd/pull/5516#issuecomment-803922755
URL: https://github.com/SSSD/sssd/pull/5516 Title: #5516: fix selinux warnings
Label: +Pushed
URL: https://github.com/SSSD/sssd/pull/5516 Title: #5516: fix selinux warnings
Label: -Accepted
URL: https://github.com/SSSD/sssd/pull/5516 Title: #5516: fix selinux warnings
Label: -Ready to push
URL: https://github.com/SSSD/sssd/pull/5516 Author: pbrezina Title: #5516: fix selinux warnings Action: closed
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5516/head:pr5516 git checkout pr5516
sssd-devel@lists.fedorahosted.org
-
elkoniu -
pbrezina
-
sumit-bose