URL: https://github.com/SSSD/sssd/pull/625 Author: mzidek-rh Title: #625: Revert "CRYPTO: Suppress warning Wstringop-truncation" Action: opened
PR body: """ This reverts commit 2951a9a84bd85f384213a3e071ffc167907df2d7.
The original use stpncpy was correct. Changing it to memcpy changed the resulting hash. This resulted in users from local domain to not be able to authenticate (offline authentication was also probably broken) if their hash was created before this change.
https://pagure.io/SSSD/sssd/issue/3791 """
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/625/head:pr625 git checkout pr625
URL: https://github.com/SSSD/sssd/pull/625 Title: #625: Revert "CRYPTO: Suppress warning Wstringop-truncation"
mzidek-rh commented: """ Note: The issue was that stpncpy returns pointer to the end of the copied string not to the beginning. """
See the full comment at https://github.com/SSSD/sssd/pull/625#issuecomment-408373150
URL: https://github.com/SSSD/sssd/pull/625 Title: #625: Revert "CRYPTO: Suppress warning Wstringop-truncation"
Label: +Accepted
URL: https://github.com/SSSD/sssd/pull/625 Author: mzidek-rh Title: #625: Revert "CRYPTO: Suppress warning Wstringop-truncation" Action: closed
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/625/head:pr625 git checkout pr625
URL: https://github.com/SSSD/sssd/pull/625 Title: #625: Revert "CRYPTO: Suppress warning Wstringop-truncation"
jhrozek commented: """ * master: bb20d5160faed5e0076887ac4a83e550be15a8b2 """
See the full comment at https://github.com/SSSD/sssd/pull/625#issuecomment-408998072
URL: https://github.com/SSSD/sssd/pull/625 Title: #625: Revert "CRYPTO: Suppress warning Wstringop-truncation"
Label: +Pushed
sssd-devel@lists.fedorahosted.org
-
jhrozek -
mzidek-rh