ehlo,
The boolean variable found_nss could be used uninitialized in test test_known_service if service "nss" would not be found. We would catch it with valgind.
Simple patch is attached.
LS
On 04/07/2015 04:33 PM, Lukas Slebodnik wrote:
ehlo,
The boolean variable found_nss could be used uninitialized in test test_known_service if service "nss" would not be found. We would catch it with valgind.
Simple patch is attached.
LS
sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
Obvious ACK, ci passed:
On Wed, Apr 08, 2015 at 11:10:42AM +0200, Pavel Reichl wrote:
On 04/07/2015 04:33 PM, Lukas Slebodnik wrote:
ehlo,
The boolean variable found_nss could be used uninitialized in test test_known_service if service "nss" would not be found. We would catch it with valgind.
Simple patch is attached.
LS
sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
Obvious ACK, ci passed:
I think we should also commit the attached one-liner because the condition in the test is wrong.
On (08/04/15 11:18), Jakub Hrozek wrote:
On Wed, Apr 08, 2015 at 11:10:42AM +0200, Pavel Reichl wrote:
On 04/07/2015 04:33 PM, Lukas Slebodnik wrote:
ehlo,
The boolean variable found_nss could be used uninitialized in test test_known_service if service "nss" would not be found. We would catch it with valgind.
Simple patch is attached.
LS
Obvious ACK, ci passed:
I think we should also commit the attached one-liner because the condition in the test is wrong.
From 840bfdb115d326ef3b3134c3dbf4a9df73b93be9 Mon Sep 17 00:00:00 2001 From: Jakub Hrozek jhrozek@redhat.com Date: Wed, 8 Apr 2015 11:17:44 +0200 Subject: [PATCH] tests: Revert strcmp condition
src/tests/util-tests.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/tests/util-tests.c b/src/tests/util-tests.c index 1cff0bb678ad60f857b28927a8f5a21df4f557d1..7270887377bf05d2a3387b7f4e459ac1678e233d 100644 --- a/src/tests/util-tests.c +++ b/src/tests/util-tests.c @@ -1013,7 +1013,7 @@ START_TEST(test_known_service) svcs = get_known_services(); for (i = 0; svcs[i]; i++) { ck_assert_str_ne(svcs[i], "nosuchservice");
if (strcmp(svcs[i], "nss")) {
if (strcmp(svcs[i], "nss") == 0) { found_nss = true; }
We would catch it if we had a negative test :-)
ACK
http://sssd-ci.duckdns.org/logs/job/12/69/summary.html
LS
On Wed, Apr 08, 2015 at 03:17:42PM +0200, Lukas Slebodnik wrote:
ACK
http://sssd-ci.duckdns.org/logs/job/12/69/summary.html
LS
Thanks for the review, pushed to master: e11b9f85b5ad0454cdf3828c4876ec7de3f4799a
On (08/04/15 15:25), Jakub Hrozek wrote:
On Wed, Apr 08, 2015 at 03:17:42PM +0200, Lukas Slebodnik wrote:
ACK
http://sssd-ci.duckdns.org/logs/job/12/69/summary.html
LS
Thanks for the review, pushed to master: e11b9f85b5ad0454cdf3828c4876ec7de3f4799a
* sssd-1-12: 573c25869df246a48a1a82b282b71061851d4d87
LS
On Wed, Apr 08, 2015 at 11:10:42AM +0200, Pavel Reichl wrote:
On 04/07/2015 04:33 PM, Lukas Slebodnik wrote:
ehlo,
The boolean variable found_nss could be used uninitialized in test test_known_service if service "nss" would not be found. We would catch it with valgind.
Simple patch is attached.
LS
sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
Obvious ACK, ci passed:
* master: 2f84032c28ac414b77a5c1ad470eb69ed6c6a1b4
On (08/04/15 11:35), Jakub Hrozek wrote:
On Wed, Apr 08, 2015 at 11:10:42AM +0200, Pavel Reichl wrote:
On 04/07/2015 04:33 PM, Lukas Slebodnik wrote:
ehlo,
The boolean variable found_nss could be used uninitialized in test test_known_service if service "nss" would not be found. We would catch it with valgind.
Simple patch is attached.
LS
sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
Obvious ACK, ci passed:
- master: 2f84032c28ac414b77a5c1ad470eb69ed6c6a1b4
* sssd-1-12: d0fd102be43ccfd95f2d189fcdceb443fdfdafcd
LS
sssd-devel@lists.fedorahosted.org