On 10/17/2012 03:52 PM, Stephen Gallagher wrote:
Hi Stephen, I was looking at the patch, and this part seems a bit useless
sss_cache*)echo \%lang\(${lang}\) \%{_mandir}/${man}\* >> sssd.lang
---------------^ also alignment issue
;;
since the following part of code does the same
*) echo \%lang\(${lang}\) \%{_mandir}/${man}\* >> sssd.lang ;;
could you please explain to me the purpose of this ?
Thanks
O.
On Thu, Oct 18, 2012 at 04:28:52PM +0200, Ondrej Kos wrote:
On 10/17/2012 03:52 PM, Stephen Gallagher wrote:
Hi Stephen, I was looking at the patch, and this part seems a bit useless
sss_cache*)echo \%lang\(${lang}\) \%{_mandir}/${man}\* >> sssd.lang---------------^ also alignment issue
;;since the following part of code does the same
It's because we want the first case to catch sss_cache before the second one (sss_*) does.
*) echo \%lang\(${lang}\) \%{_mandir}/${man}\* >> sssd.lang ;;could you please explain to me the purpose of this ?
Thanks
Ack. I'll fix the whitespace issue before pushing.
On Thu, Oct 18, 2012 at 07:48:38PM +0200, Jakub Hrozek wrote:
On Thu, Oct 18, 2012 at 04:28:52PM +0200, Ondrej Kos wrote:
On 10/17/2012 03:52 PM, Stephen Gallagher wrote:
Hi Stephen, I was looking at the patch, and this part seems a bit useless
sss_cache*)echo \%lang\(${lang}\) \%{_mandir}/${man}\* >> sssd.lang---------------^ also alignment issue
;;since the following part of code does the same
It's because we want the first case to catch sss_cache before the second one (sss_*) does.
*) echo \%lang\(${lang}\) \%{_mandir}/${man}\* >> sssd.lang ;;could you please explain to me the purpose of this ?
Thanks
Ack. I'll fix the whitespace issue before pushing.
Pushed to master.
On Thu, Oct 18, 2012 at 08:03:19PM +0200, Jakub Hrozek wrote:
On Thu, Oct 18, 2012 at 07:48:38PM +0200, Jakub Hrozek wrote:
On Thu, Oct 18, 2012 at 04:28:52PM +0200, Ondrej Kos wrote:
On 10/17/2012 03:52 PM, Stephen Gallagher wrote:
Hi Stephen, I was looking at the patch, and this part seems a bit useless
sss_cache*)echo \%lang\(${lang}\) \%{_mandir}/${man}\* >> sssd.lang---------------^ also alignment issue
;;since the following part of code does the same
It's because we want the first case to catch sss_cache before the second one (sss_*) does.
*) echo \%lang\(${lang}\) \%{_mandir}/${man}\* >> sssd.lang ;;could you please explain to me the purpose of this ?
Thanks
Ack. I'll fix the whitespace issue before pushing.
Pushed to master.
Also pushed to sssd-1-9
sssd-devel@lists.fedorahosted.org